You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/08 03:15:56 UTC
[GitHub] [spark] beliefer opened a new pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
beliefer opened a new pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495
### What changes were proposed in this pull request?
Spark SQL support single comments and bracketed comments now. This PR will support nested bracketed comments.
There are some mainstream database support the syntax.
**PostgreSQL:**
https://www.postgresql.org/docs/11/sql-syntax-lexical.html#SQL-SYNTAX-COMMENTS
**Vertica:**
https://www.vertica.com/docs/9.2.x/HTML/Content/Authoring/SQLReferenceManual/LanguageElements/Expressions/Comments.htm?zoom_highlight=comments
Note: Because Spark SQL not exists UT for single comments and bracketed comments, so I add some UT for them.
### Why are the changes needed?
nested bracketed comments is ANSI standard.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
New UT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587240081
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23359/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587348038
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589630212
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583720822
**[Test build #118066 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118066/testReport)** for PR 27495 at commit [`0a21b5e`](https://github.com/apache/spark/commit/0a21b5eb526b72bdf36840b92ad0b2efb8c6f888).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583720822
**[Test build #118066 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118066/testReport)** for PR 27495 at commit [`0a21b5e`](https://github.com/apache/spark/commit/0a21b5eb526b72bdf36840b92ad0b2efb8c6f888).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586892230
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586350509
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586345416
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23194/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586549083
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23220/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583720921
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22832/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r379900468
##########
File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/comments.sql
##########
@@ -47,4 +45,5 @@ Now just one deep...
*/
'deeply nested example' AS sixth;
--QUERY-DELIMITER-END
-/* and this is the end of the file */
+-- [SPARK-30824] Support submit sql content only contains comments.
Review comment:
OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-585572150
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583840340
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118095/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586548022
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r381040836
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -1797,11 +1797,11 @@ SIMPLE_COMMENT
;
BRACKETED_EMPTY_COMMENT
- : '/**/' -> channel(HIDDEN)
+ : '/*' BRACKETED_EMPTY_COMMENT* '*/' -> channel(HIDDEN)
;
BRACKETED_COMMENT
- : '/*' ~[+] .*? '*/' -> channel(HIDDEN)
+ : '/*' (BRACKETED_COMMENT .*? | ~[+] (BRACKETED_COMMENT|.)*?)*? '*/' -> channel(HIDDEN)
Review comment:
It can't pass `PlanParserSuite`.
```
- SPARK-20854: multiple hints *** FAILED *** (6 milliseconds)
[info] == FAIL: Plans do not match ===
[info] !'Project [*] 'UnresolvedHint HINT1, ['a, 1]
[info] !+- 'UnresolvedRelation [t] +- 'UnresolvedHint hint2, ['b, 2]
[info] ! +- 'Project [*]
[info] ! +- 'UnresolvedRelation [t] (PlanTest.scala:147)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586057296
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118383/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r378496367
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
##########
@@ -55,6 +55,65 @@ class PlanParserSuite extends AnalysisTest {
With(plan, ctes)
}
+ test("single comment") {
+ val plan = table("a").select(star())
+ assertEqual("-- single comment\nSELECT * FROM a", plan)
+ }
+
+ test("bracketed comment case one") {
+ val plan = table("a").select(star())
+ assertEqual(
+ """
+ |/* This is an example of SQL which should not execute:
+ | * select 'multi-line';
+ | */
+ |SELECT * FROM a
+ """.stripMargin, plan)
+ }
+
+ test("bracketed comment case two") {
+ val plan = table("a").select(star())
+ assertEqual(
+ """
+ |/*
+ |SELECT 'trailing' as x1; -- inside block comment
+ |*/
+ |SELECT * FROM a
+ """.stripMargin, plan)
+ }
+
+ test("nexted bracketed comment case one") {
Review comment:
nit: `nexted` => `nested`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r376698097
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
##########
@@ -55,6 +55,54 @@ class PlanParserSuite extends AnalysisTest {
With(plan, ctes)
}
+ test("single comment") {
+ val plan = table("a").select(star())
+ assertEqual("-- single comment\nSELECT * FROM a", plan)
+ }
+
+ test("bracketed comment case one") {
+ val plan = table("a").select(star())
+ assertEqual("/* This is an example of SQL which should not execute:\n" +
Review comment:
Could you follow a format like this?
```
assertEqual(
"""
|/*
| XXX
| */
|SELECT ...
""".stripMargin,
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r376700666
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
##########
@@ -55,6 +55,54 @@ class PlanParserSuite extends AnalysisTest {
With(plan, ctes)
}
+ test("single comment") {
+ val plan = table("a").select(star())
+ assertEqual("-- single comment\nSELECT * FROM a", plan)
+ }
+
+ test("bracketed comment case one") {
+ val plan = table("a").select(star())
+ assertEqual("/* This is an example of SQL which should not execute:\n" +
+ " * select 'multi-line';\n" +
+ " */\n" +
+ "SELECT * FROM a", plan)
+ }
+
+ test("bracketed comment case two") {
+ val plan = table("a").select(star())
+ assertEqual("/*\n" +
+ "SELECT 'trailing' as x1; -- inside block comment\n" +
+ "*/\n" +
+ "SELECT * FROM a", plan)
+ }
+
+ test("nexted bracketed comment case one") {
+ val plan = table("a").select(star())
+ assertEqual("/* This block comment surrounds a query which itself has a block comment...\n" +
+ "SELECT /* embedded single line */ 'embedded' AS x2;\n" +
+ "*/\n" +
+ "SELECT * FROM a", plan)
+ }
+
+ test("nexted bracketed comment case two") {
+ val plan = table("a").select(star())
+ assertEqual("SELECT -- continued after the following block comments...\n" +
+ "/* Deeply nested comment.\n" +
+ " This includes a single apostrophe to make sure we aren't decoding this part as a " +
+ "string.\n" +
+ "SELECT 'deep nest' AS n1;\n" +
+ "/* Second level of nesting...\n" +
+ "SELECT 'deeper nest' as n2;\n" +
+ "/* Third level of nesting...\n" +
+ "SELECT 'deepest nest' as n3;\n" +
+ "*/\n" +
+ "Hoo boy. Still two deep...\n" +
+ "*/\n" +
+ "Now just one deep...\n" +
+ "*/\n" +
+ "* FROM a", plan)
+ }
Review comment:
I probably miss something though, why does not this change affect `postgreSQL/comments.sql.out`? It seems they have nested bracketed comments.
> Is it enough with sql/core/src/test/resources/sql-tests/inputs/postgreSQL/comments.sql ？
They are regression tests just ported from the pgSQL codebase to check behaviour differences beteween Spark/PostgreSQL. So, to check new behaviours implemented by this pr, I think its ok to put some basic end-to-end tests in `sql-tests/inputs/comments.sql`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587495701
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586414044
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118430/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
gengliangwang removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-590202541
Merging to master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589636951
**[Test build #118790 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118790/testReport)** for PR 27495 at commit [`48814c3`](https://github.com/apache/spark/commit/48814c356794ea97191c09416958296be5b01e7f).
* This patch **fails to generate documentation**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583726715
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-588788696
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23460/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-588631892
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23451/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589617823
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23540/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r378496425
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
##########
@@ -55,6 +55,65 @@ class PlanParserSuite extends AnalysisTest {
With(plan, ctes)
}
+ test("single comment") {
+ val plan = table("a").select(star())
+ assertEqual("-- single comment\nSELECT * FROM a", plan)
+ }
+
+ test("bracketed comment case one") {
+ val plan = table("a").select(star())
+ assertEqual(
+ """
+ |/* This is an example of SQL which should not execute:
+ | * select 'multi-line';
+ | */
+ |SELECT * FROM a
+ """.stripMargin, plan)
+ }
+
+ test("bracketed comment case two") {
+ val plan = table("a").select(star())
+ assertEqual(
+ """
+ |/*
+ |SELECT 'trailing' as x1; -- inside block comment
+ |*/
+ |SELECT * FROM a
+ """.stripMargin, plan)
+ }
+
+ test("nexted bracketed comment case one") {
+ val plan = table("a").select(star())
+ assertEqual(
+ """
+ |/* This block comment surrounds a query which itself has a block comment...
+ |SELECT /* embedded single line */ 'embedded' AS x2;
+ |*/
+ |SELECT * FROM a
+ """.stripMargin, plan)
+ }
+
+ test("nexted bracketed comment case two") {
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587305720
**[Test build #118606 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118606/testReport)** for PR 27495 at commit [`25d0863`](https://github.com/apache/spark/commit/25d0863015e881819c67fdeb2e85c47dfb08f098).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589561616
@cloud-fan This is a very very good idea. I learned it and will make a try.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583744311
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118069/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r380404092
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -1801,7 +1801,7 @@ BRACKETED_EMPTY_COMMENT
;
BRACKETED_COMMENT
- : '/*' ~[+] .*? '*/' -> channel(HIDDEN)
+ : '/*' ~[+] (BRACKETED_COMMENT|.)*? '*/' -> channel(HIDDEN)
Review comment:
@beliefer my point of the case
```
/*/**/*/
```
is not about empty comment. It is about another `/*` after `/*`.
We can change the case to
```
/*/*foo*/*/
```
The latest fix will still failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583725587
> Can you remove the jira numbers below?
>
> https://github.com/apache/spark/blob/12e1bbaddbb2ef304b5880a62df6683fcc94ea54/sql/core/src/test/resources/sql-tests/inputs/postgreSQL/comments.sql#L14
>
>
> https://github.com/apache/spark/blob/12e1bbaddbb2ef304b5880a62df6683fcc94ea54/sql/core/src/test/resources/sql-tests/inputs/postgreSQL/comments.sql#L20
I want remove the jira numbers with #27481. Golden files can't generated correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583715079
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22829/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r378500238
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -1794,7 +1794,7 @@ BRACKETED_EMPTY_COMMENT
;
BRACKETED_COMMENT
- : '/*' ~[+] .*? '*/' -> channel(HIDDEN)
+ : '/*' ~[+] ( ~'/' | ~'*' '/' ~'*' )*? BRACKETED_COMMENT? ( ~'/' | ~'*' '/' ~'*' )*? '*/' -> channel(HIDDEN)
Review comment:
how about
```
'/*' ~[+] ~[/]*? BRACKETED_COMMENT? ~[/]*? '*/' -> channel(HIDDEN)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r378516806
##########
File path: sql/core/src/test/resources/sql-tests/inputs/comments.sql
##########
@@ -0,0 +1,70 @@
+-- Test comments.
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated golden files
+-- bracketed comment case one
+/* This is the first example of bracketed comment.
+SELECT 'ommented out content' AS first;
+*/
+SELECT 'selected content' AS first;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated golden files
+-- bracketed comment case two
+/* This is the second example of bracketed comment.
+SELECT '/', 'ommented out content' AS second;
+*/
+SELECT '/', 'selected content' AS second;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated golden files
+-- bracketed comment case three
+/* This is the third example of bracketed comment.
+ *SELECT '*', 'ommented out content' AS third;
+ */
+SELECT '*', 'selected content' AS third;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated golden files
+-- nested bracketed comment case one
+/* This is the first example of nested bracketed comment.
+/* I am a nested bracketed comment.*/
+*/
+SELECT 'selected content' AS four;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated golden files
+-- nested bracketed comment case two
+/* This is the second example of nested bracketed comment.
+/* I am a nested bracketed comment.
+ */
+ */
+SELECT 'selected content' AS five;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated golden files
+-- nested bracketed comment case three
+/*
+ * This is the third example of nested bracketed comment.
+ /*
+ * I am a nested bracketed comment.
+ */
+ */
+SELECT 'selected content' AS six;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated golden files
+-- nested bracketed comment case four
+/*
+ * This is the four example of nested bracketed comment.
Review comment:
nit: four => fourth
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586144473
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118394/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r382512243
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -1797,11 +1810,11 @@ SIMPLE_COMMENT
;
BRACKETED_EMPTY_COMMENT
Review comment:
`(BRACKETED_COMMENT|.)*?` should work for empty comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587495714
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118630/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-588787017
**[Test build #118709 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118709/testReport)** for PR 27495 at commit [`0a42a59`](https://github.com/apache/spark/commit/0a42a59df69ab262f78a9f6158eb8fad593b5579).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587537503
**[Test build #118645 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118645/testReport)** for PR 27495 at commit [`93eb3c5`](https://github.com/apache/spark/commit/93eb3c5f3d07da70468f55d49ef1853d663a8288).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587306306
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589605671
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118785/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583834283
**[Test build #118095 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118095/testReport)** for PR 27495 at commit [`7760f91`](https://github.com/apache/spark/commit/7760f9181259ee3493fb5c02d1d2b9b6dd70f2bb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583931896
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22870/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583711770
**[Test build #118054 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118054/testReport)** for PR 27495 at commit [`464cd03`](https://github.com/apache/spark/commit/464cd03a546ccb72e1a2efe70900df03872e3fb9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r376700795
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -1794,7 +1794,7 @@ BRACKETED_EMPTY_COMMENT
;
BRACKETED_COMMENT
- : '/*' ~[+] .*? '*/' -> channel(HIDDEN)
+ : '/*' ~[+] ( ~'/' | ~'*' '/' ~'*' )*? BRACKETED_COMMENT? ( ~'/' | ~'*' '/' ~'*' )*? '*/' -> channel(HIDDEN)
Review comment:
`: '/*' ~[+] (BRACKETED_COMMENT|.)*? '*/' -> channel(HIDDEN)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583799092
> Ah, I got it now. The reason not to generate the output correctly is an issue in the testing logic itself in `SQLQueryTestSuite`, right? (I thought that's an issue in how-to-write `postgreSQL/comments.sql`). If so, they're different issues as you said above.
@maropu Yes, thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583840340
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118095/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586163543
**[Test build #118410 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118410/testReport)** for PR 27495 at commit [`519f47f`](https://github.com/apache/spark/commit/519f47fc7de0f753c6202bada0fa6972111d115f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583737466
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r379415105
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -1801,7 +1801,7 @@ BRACKETED_EMPTY_COMMENT
;
BRACKETED_COMMENT
- : '/*' ~[+] .*? '*/' -> channel(HIDDEN)
+ : '/*' ~[+] ~'/'*? ( ~'*' '/' ~'*' )*? ~'*'+ BRACKETED_COMMENT? ~'*'+ ( ~'*' '/' ~'*' )*? ~'/'*? '*/' -> channel(HIDDEN)
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583731692
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586323120
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118413/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-585508951
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23088/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586305041
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118410/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r379392464
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -1801,7 +1801,7 @@ BRACKETED_EMPTY_COMMENT
;
BRACKETED_COMMENT
- : '/*' ~[+] .*? '*/' -> channel(HIDDEN)
+ : '/*' ~[+] ~'/'*? ( ~'*' '/' ~'*' )*? ~'*'+ BRACKETED_COMMENT? ~'*'+ ( ~'*' '/' ~'*' )*? ~'/'*? '*/' -> channel(HIDDEN)
Review comment:
we may need some comments to explain what it does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-588788662
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586305028
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583735156
**[Test build #118071 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118071/testReport)** for PR 27495 at commit [`596d905`](https://github.com/apache/spark/commit/596d905b3cdf0aa6ba84ae545e0a458abf91bb98).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586057292
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583726639
**[Test build #118069 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118069/testReport)** for PR 27495 at commit [`1b9d1da`](https://github.com/apache/spark/commit/1b9d1da8bd7942c7a37ca1fff6cc67d0113784da).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583744311
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118069/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589829781
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589717537
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586549081
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586892235
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23316/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586547792
**[Test build #118462 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118462/testReport)** for PR 27495 at commit [`8e89a87`](https://github.com/apache/spark/commit/8e89a87d90aff36b45e018ed9a10cdaaa1007995).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r381951502
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -1797,11 +1797,11 @@ SIMPLE_COMMENT
;
BRACKETED_EMPTY_COMMENT
- : '/**/' -> channel(HIDDEN)
+ : '/*' BRACKETED_EMPTY_COMMENT? '*/' -> channel(HIDDEN)
;
BRACKETED_COMMENT
Review comment:
Since hint can appear at any position, it's not possible to create a parser rule for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587538167
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23398/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-588725437
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118700/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587240076
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r382511174
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -61,6 +61,19 @@ grammar SqlBase;
* When true, the behavior of keywords follows ANSI SQL standard.
*/
public boolean SQL_standard_keyword_behavior = false;
+
+ /**
+ * Verify whether current token is a valid hint token (which follows '/*' and is '+').
+ * Returns true if the first character is '+'.
+ */
+ public boolean isHint() {
+ int firstChar = _input.LA(1);
Review comment:
`_input.LA(1)` returns next char, shall we name it `nextChar`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r382511831
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -61,6 +61,19 @@ grammar SqlBase;
* When true, the behavior of keywords follows ANSI SQL standard.
*/
public boolean SQL_standard_keyword_behavior = false;
+
+ /**
+ * Verify whether current token is a valid hint token (which follows '/*' and is '+').
Review comment:
I'd like to enrich this comment:
```
This is called when we see '/*' and try to match it as a comment. If the next char is '+', this should
be parsed as hint later and we can't match it as a comment.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589016766
**[Test build #118709 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118709/testReport)** for PR 27495 at commit [`0a42a59`](https://github.com/apache/spark/commit/0a42a59df69ab262f78a9f6158eb8fad593b5579).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583933034
**[Test build #118105 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118105/testReport)** for PR 27495 at commit [`efe98fa`](https://github.com/apache/spark/commit/efe98fad056dbedf43a41256a2e4245c3e3372dd).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583720919
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589632018
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589629199
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118789/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587331163
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r382534334
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -61,6 +61,22 @@ grammar SqlBase;
* When true, the behavior of keywords follows ANSI SQL standard.
*/
public boolean SQL_standard_keyword_behavior = false;
+
+ /**
+ * This method will be called when we see '/*' and try to match it as a bracketed comment.
+ * If the next character is '+', it should be parsed as hint later, otherwise we cannot match
+ * it as a bracketed comment.
+ *
+ * Returns true if the first character is '+'.
Review comment:
My fault.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586457253
**[Test build #118435 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118435/testReport)** for PR 27495 at commit [`f5a817f`](https://github.com/apache/spark/commit/f5a817f594473677990e15676d59a3dde1201ce0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586548830
**[Test build #118463 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118463/testReport)** for PR 27495 at commit [`8118ab5`](https://github.com/apache/spark/commit/8118ab545d80ff32a73b71353ec6d788e18f5448).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r379264511
##########
File path: sql/core/src/test/resources/sql-tests/inputs/comments.sql
##########
@@ -0,0 +1,78 @@
+-- Test comments.
+
+-- bracketed comment case one
+--QUERY-DELIMITER-START
+/* This is the first example of bracketed comment.
+SELECT 'ommented out content' AS first;
+*/
+SELECT 'selected content' AS first;
+--QUERY-DELIMITER-END
+
+-- bracketed comment case two
+--QUERY-DELIMITER-START
+/* This is the second example of bracketed comment.
+SELECT '/', 'ommented out content' AS second;
+*/
+SELECT '/', 'selected content' AS second;
+--QUERY-DELIMITER-END
+
+-- bracketed comment case three
+--QUERY-DELIMITER-START
+/* This is the third example of bracketed comment.
+ *SELECT '*', 'ommented out content' AS third;
+ */
+SELECT '*', 'selected content' AS third;
+--QUERY-DELIMITER-END
+
+-- nested bracketed comment case one
+--QUERY-DELIMITER-START
+/* This is the first example of nested bracketed comment.
+/* I am a nested bracketed comment.*/
+*/
Review comment:
LOL even github can't highlight the nested bracketed comment correctly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587332411
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587332000
**[Test build #118620 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118620/testReport)** for PR 27495 at commit [`f1806ef`](https://github.com/apache/spark/commit/f1806ef7c41cc0fc757a407066ef49a40bb10be9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586350522
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118437/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583755523
**[Test build #118070 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118070/testReport)** for PR 27495 at commit [`3d03688`](https://github.com/apache/spark/commit/3d036886df60ec77f66e35142156803569577935).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gatorsmile commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
gatorsmile commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583702527
cc @maropu @gengliangwang @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r380404092
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -1801,7 +1801,7 @@ BRACKETED_EMPTY_COMMENT
;
BRACKETED_COMMENT
- : '/*' ~[+] .*? '*/' -> channel(HIDDEN)
+ : '/*' ~[+] (BRACKETED_COMMENT|.)*? '*/' -> channel(HIDDEN)
Review comment:
@beliefer my point of the case
```
/*/**/*/
```
is not about empty comment. It is about matching the begining of another comment ( `/*` after `/*`).
We can change the case to
```
/*/*foo*/*/
```
The latest fix will still failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583737471
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118066/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586163543
**[Test build #118410 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118410/testReport)** for PR 27495 at commit [`519f47f`](https://github.com/apache/spark/commit/519f47fc7de0f753c6202bada0fa6972111d115f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r380000649
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -1801,7 +1801,7 @@ BRACKETED_EMPTY_COMMENT
;
BRACKETED_COMMENT
- : '/*' ~[+] .*? '*/' -> channel(HIDDEN)
+ : '/*' ~[+] (BRACKETED_COMMENT|.)*? '*/' -> channel(HIDDEN)
Review comment:
Yea!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589636980
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586087069
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r376698165
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
##########
@@ -55,6 +55,54 @@ class PlanParserSuite extends AnalysisTest {
With(plan, ctes)
}
+ test("single comment") {
+ val plan = table("a").select(star())
+ assertEqual("-- single comment\nSELECT * FROM a", plan)
+ }
+
+ test("bracketed comment case one") {
+ val plan = table("a").select(star())
+ assertEqual("/* This is an example of SQL which should not execute:\n" +
+ " * select 'multi-line';\n" +
+ " */\n" +
+ "SELECT * FROM a", plan)
+ }
+
+ test("bracketed comment case two") {
+ val plan = table("a").select(star())
+ assertEqual("/*\n" +
+ "SELECT 'trailing' as x1; -- inside block comment\n" +
+ "*/\n" +
+ "SELECT * FROM a", plan)
+ }
+
+ test("nexted bracketed comment case one") {
+ val plan = table("a").select(star())
+ assertEqual("/* This block comment surrounds a query which itself has a block comment...\n" +
+ "SELECT /* embedded single line */ 'embedded' AS x2;\n" +
+ "*/\n" +
+ "SELECT * FROM a", plan)
+ }
+
+ test("nexted bracketed comment case two") {
+ val plan = table("a").select(star())
+ assertEqual("SELECT -- continued after the following block comments...\n" +
+ "/* Deeply nested comment.\n" +
+ " This includes a single apostrophe to make sure we aren't decoding this part as a " +
+ "string.\n" +
+ "SELECT 'deep nest' AS n1;\n" +
+ "/* Second level of nesting...\n" +
+ "SELECT 'deeper nest' as n2;\n" +
+ "/* Third level of nesting...\n" +
+ "SELECT 'deepest nest' as n3;\n" +
+ "*/\n" +
+ "Hoo boy. Still two deep...\n" +
+ "*/\n" +
+ "Now just one deep...\n" +
+ "*/\n" +
+ "* FROM a", plan)
+ }
Review comment:
I want update with https://github.com/apache/spark/pull/27481 after this PR merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583731693
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118063/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583833683
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583726715
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587411648
**[Test build #118630 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118630/testReport)** for PR 27495 at commit [`f1806ef`](https://github.com/apache/spark/commit/f1806ef7c41cc0fc757a407066ef49a40bb10be9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r378516856
##########
File path: sql/core/src/test/resources/sql-tests/inputs/comments.sql
##########
@@ -0,0 +1,70 @@
+-- Test comments.
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated golden files
+-- bracketed comment case one
+/* This is the first example of bracketed comment.
+SELECT 'ommented out content' AS first;
+*/
+SELECT 'selected content' AS first;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated golden files
+-- bracketed comment case two
+/* This is the second example of bracketed comment.
+SELECT '/', 'ommented out content' AS second;
+*/
+SELECT '/', 'selected content' AS second;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated golden files
+-- bracketed comment case three
+/* This is the third example of bracketed comment.
+ *SELECT '*', 'ommented out content' AS third;
+ */
+SELECT '*', 'selected content' AS third;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated golden files
+-- nested bracketed comment case one
+/* This is the first example of nested bracketed comment.
+/* I am a nested bracketed comment.*/
+*/
+SELECT 'selected content' AS four;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated golden files
+-- nested bracketed comment case two
+/* This is the second example of nested bracketed comment.
+/* I am a nested bracketed comment.
+ */
+ */
+SELECT 'selected content' AS five;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated golden files
+-- nested bracketed comment case three
+/*
+ * This is the third example of nested bracketed comment.
+ /*
+ * I am a nested bracketed comment.
+ */
+ */
+SELECT 'selected content' AS six;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated golden files
+-- nested bracketed comment case four
+/*
+ * This is the four example of nested bracketed comment.
+SELECT /* I am a nested bracketed comment.*/ * FROM testData;
+ */
+SELECT 'selected content' AS seven;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated golden files
+-- nested bracketed comment case five
+SELECT /*
+ * This is the five example of nested bracketed comment.
Review comment:
five => fifth
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589622499
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587292575
**[Test build #118612 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118612/testReport)** for PR 27495 at commit [`f1806ef`](https://github.com/apache/spark/commit/f1806ef7c41cc0fc757a407066ef49a40bb10be9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-585508946
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r382512937
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -61,6 +61,19 @@ grammar SqlBase;
* When true, the behavior of keywords follows ANSI SQL standard.
*/
public boolean SQL_standard_keyword_behavior = false;
+
+ /**
+ * Verify whether current token is a valid hint token (which follows '/*' and is '+').
+ * Returns true if the first character is '+'.
+ */
+ public boolean isHint() {
+ int firstChar = _input.LA(1);
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586284702
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23187/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r381028709
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -1797,11 +1797,11 @@ SIMPLE_COMMENT
;
BRACKETED_EMPTY_COMMENT
- : '/**/' -> channel(HIDDEN)
+ : '/*' BRACKETED_EMPTY_COMMENT* '*/' -> channel(HIDDEN)
;
BRACKETED_COMMENT
- : '/*' ~[+] .*? '*/' -> channel(HIDDEN)
+ : '/*' (BRACKETED_COMMENT .*? | ~[+] (BRACKETED_COMMENT|.)*?)*? '*/' -> channel(HIDDEN)
Review comment:
I tried it and found that there is a parse conflict with hint.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589624448
**[Test build #118789 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118789/testReport)** for PR 27495 at commit [`48814c3`](https://github.com/apache/spark/commit/48814c356794ea97191c09416958296be5b01e7f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r378606843
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
##########
@@ -55,6 +55,65 @@ class PlanParserSuite extends AnalysisTest {
With(plan, ctes)
}
+ test("single comment") {
+ val plan = table("a").select(star())
+ assertEqual("-- single comment\nSELECT * FROM a", plan)
+ }
+
+ test("bracketed comment case one") {
+ val plan = table("a").select(star())
+ assertEqual(
+ """
+ |/* This is an example of SQL which should not execute:
+ | * select 'multi-line';
+ | */
+ |SELECT * FROM a
+ """.stripMargin, plan)
+ }
+
+ test("bracketed comment case two") {
+ val plan = table("a").select(star())
+ assertEqual(
+ """
+ |/*
+ |SELECT 'trailing' as x1; -- inside block comment
+ |*/
+ |SELECT * FROM a
+ """.stripMargin, plan)
+ }
+
+ test("nexted bracketed comment case one") {
+ val plan = table("a").select(star())
+ assertEqual(
+ """
+ |/* This block comment surrounds a query which itself has a block comment...
+ |SELECT /* embedded single line */ 'embedded' AS x2;
+ |*/
+ |SELECT * FROM a
+ """.stripMargin, plan)
+ }
+
+ test("nexted bracketed comment case two") {
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r378500238
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -1794,7 +1794,7 @@ BRACKETED_EMPTY_COMMENT
;
BRACKETED_COMMENT
- : '/*' ~[+] .*? '*/' -> channel(HIDDEN)
+ : '/*' ~[+] ( ~'/' | ~'*' '/' ~'*' )*? BRACKETED_COMMENT? ( ~'/' | ~'*' '/' ~'*' )*? '*/' -> channel(HIDDEN)
Review comment:
how about
```
'/*' ~[+] ~[/]*? BRACKETED_COMMENT? ~[/]*? '*/' -> channel(HIDDEN)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589622507
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23541/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589607741
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586895391
**[Test build #118561 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118561/testReport)** for PR 27495 at commit [`116e9b8`](https://github.com/apache/spark/commit/116e9b80846c8a4a87deafd58c77053296c0d702).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589716967
**[Test build #118798 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118798/testReport)** for PR 27495 at commit [`48814c3`](https://github.com/apache/spark/commit/48814c356794ea97191c09416958296be5b01e7f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu edited a comment on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
maropu edited a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583796191
Ah, I got it now. The reason not to generate the output correctly is an issue in the testing logic itself in `SQLQueryTestSuite`, right? If so, they're different issues as you said above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583697652
**[Test build #118054 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118054/testReport)** for PR 27495 at commit [`464cd03`](https://github.com/apache/spark/commit/464cd03a546ccb72e1a2efe70900df03872e3fb9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589629199
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118789/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-588724737
**[Test build #118694 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118694/testReport)** for PR 27495 at commit [`20452bc`](https://github.com/apache/spark/commit/20452bcac119694798d5c088201cc4b5aaa26322).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589829795
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118798/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587495701
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586279668
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583990907
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583711860
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586164439
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23167/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586350449
**[Test build #118437 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118437/testReport)** for PR 27495 at commit [`99d9187`](https://github.com/apache/spark/commit/99d918708474e798696f38e8b85464603903efa1).
* This patch **fails MiMa tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586458005
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118435/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586563704
**[Test build #118463 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118463/testReport)** for PR 27495 at commit [`8118ab5`](https://github.com/apache/spark/commit/8118ab545d80ff32a73b71353ec6d788e18f5448).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583755686
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118070/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586284702
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23187/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586090159
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586053606
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586895391
**[Test build #118561 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118561/testReport)** for PR 27495 at commit [`116e9b8`](https://github.com/apache/spark/commit/116e9b80846c8a4a87deafd58c77053296c0d702).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587306310
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118606/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r376697757
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
##########
@@ -55,6 +55,54 @@ class PlanParserSuite extends AnalysisTest {
With(plan, ctes)
}
+ test("single comment") {
+ val plan = table("a").select(star())
+ assertEqual("-- single comment\nSELECT * FROM a", plan)
+ }
+
+ test("bracketed comment case one") {
+ val plan = table("a").select(star())
+ assertEqual("/* This is an example of SQL which should not execute:\n" +
+ " * select 'multi-line';\n" +
+ " */\n" +
+ "SELECT * FROM a", plan)
+ }
+
+ test("bracketed comment case two") {
+ val plan = table("a").select(star())
+ assertEqual("/*\n" +
+ "SELECT 'trailing' as x1; -- inside block comment\n" +
+ "*/\n" +
+ "SELECT * FROM a", plan)
+ }
+
+ test("nexted bracketed comment case one") {
+ val plan = table("a").select(star())
+ assertEqual("/* This block comment surrounds a query which itself has a block comment...\n" +
+ "SELECT /* embedded single line */ 'embedded' AS x2;\n" +
+ "*/\n" +
+ "SELECT * FROM a", plan)
+ }
+
+ test("nexted bracketed comment case two") {
+ val plan = table("a").select(star())
+ assertEqual("SELECT -- continued after the following block comments...\n" +
+ "/* Deeply nested comment.\n" +
+ " This includes a single apostrophe to make sure we aren't decoding this part as a " +
+ "string.\n" +
+ "SELECT 'deep nest' AS n1;\n" +
+ "/* Second level of nesting...\n" +
+ "SELECT 'deeper nest' as n2;\n" +
+ "/* Third level of nesting...\n" +
+ "SELECT 'deepest nest' as n3;\n" +
+ "*/\n" +
+ "Hoo boy. Still two deep...\n" +
+ "*/\n" +
+ "Now just one deep...\n" +
+ "*/\n" +
+ "* FROM a", plan)
+ }
Review comment:
Is it enough with sql/core/src/test/resources/sql-tests/inputs/postgreSQL/comments.sql ？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-585572158
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118331/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586377939
**[Test build #118425 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118425/testReport)** for PR 27495 at commit [`1b188d7`](https://github.com/apache/spark/commit/1b188d792a1a2d67ec70415d8c22a21b5314a8ad).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586378707
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118425/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586090171
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23151/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587347973
**[Test build #118622 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118622/testReport)** for PR 27495 at commit [`f1806ef`](https://github.com/apache/spark/commit/f1806ef7c41cc0fc757a407066ef49a40bb10be9).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587052477
**[Test build #118561 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118561/testReport)** for PR 27495 at commit [`116e9b8`](https://github.com/apache/spark/commit/116e9b80846c8a4a87deafd58c77053296c0d702).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r379997276
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -1801,7 +1801,7 @@ BRACKETED_EMPTY_COMMENT
;
BRACKETED_COMMENT
- : '/*' ~[+] .*? '*/' -> channel(HIDDEN)
+ : '/*' ~[+] (BRACKETED_COMMENT|.)*? '*/' -> channel(HIDDEN)
Review comment:
For hints?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586345404
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586182160
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r382530975
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -61,6 +61,22 @@ grammar SqlBase;
* When true, the behavior of keywords follows ANSI SQL standard.
*/
public boolean SQL_standard_keyword_behavior = false;
+
+ /**
+ * This method will be called when we see '/*' and try to match it as a bracketed comment.
+ * If the next character is '+', it should be parsed as hint later, otherwise we cannot match
Review comment:
`otherwise` -> `and`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r382531059
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -61,6 +61,22 @@ grammar SqlBase;
* When true, the behavior of keywords follows ANSI SQL standard.
*/
public boolean SQL_standard_keyword_behavior = false;
+
+ /**
+ * This method will be called when we see '/*' and try to match it as a bracketed comment.
+ * If the next character is '+', it should be parsed as hint later, otherwise we cannot match
+ * it as a bracketed comment.
+ *
+ * Returns true if the first character is '+'.
Review comment:
`next character`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-588601296
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23445/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583697186
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22820/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587348038
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589636991
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118790/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589599357
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23537/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586182169
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23170/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r380466134
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -1797,11 +1797,11 @@ SIMPLE_COMMENT
;
BRACKETED_EMPTY_COMMENT
- : '/**/' -> channel(HIDDEN)
+ : '/*' BRACKETED_EMPTY_COMMENT? '*/' -> channel(HIDDEN)
;
BRACKETED_COMMENT
Review comment:
I think even though to create a plan, we still need to distinguish hint and comment syntax.
@gengliangwang I improve the syntax again, please take a look again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586303944
**[Test build #118410 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118410/testReport)** for PR 27495 at commit [`519f47f`](https://github.com/apache/spark/commit/519f47fc7de0f753c6202bada0fa6972111d115f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r376701608
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -1794,7 +1794,7 @@ BRACKETED_EMPTY_COMMENT
;
BRACKETED_COMMENT
- : '/*' ~[+] .*? '*/' -> channel(HIDDEN)
+ : '/*' ~[+] ( ~'/' | ~'*' '/' ~'*' )*? BRACKETED_COMMENT? ( ~'/' | ~'*' '/' ~'*' )*? '*/' -> channel(HIDDEN)
Review comment:
I'm sorry. Maybe I lost some information.
I try to use this again and found it works well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583734727
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22836/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587331807
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r381050531
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -1797,11 +1797,11 @@ SIMPLE_COMMENT
;
BRACKETED_EMPTY_COMMENT
- : '/**/' -> channel(HIDDEN)
+ : '/*' BRACKETED_EMPTY_COMMENT* '*/' -> channel(HIDDEN)
;
BRACKETED_COMMENT
- : '/*' ~[+] .*? '*/' -> channel(HIDDEN)
+ : '/*' (BRACKETED_COMMENT .*? | ~[+] (BRACKETED_COMMENT|.)*?)*? '*/' -> channel(HIDDEN)
Review comment:
Ah, I see.
I am not sure about the latest code now. I think it is more reasonable to follow @cloud-fan 's advice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586323109
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583711860
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586401767
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118429/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r376697914
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
##########
@@ -55,6 +55,54 @@ class PlanParserSuite extends AnalysisTest {
With(plan, ctes)
}
+ test("single comment") {
+ val plan = table("a").select(star())
+ assertEqual("-- single comment\nSELECT * FROM a", plan)
+ }
+
+ test("bracketed comment case one") {
+ val plan = table("a").select(star())
+ assertEqual("/* This is an example of SQL which should not execute:\n" +
+ " * select 'multi-line';\n" +
+ " */\n" +
+ "SELECT * FROM a", plan)
+ }
+
+ test("bracketed comment case two") {
+ val plan = table("a").select(star())
+ assertEqual("/*\n" +
+ "SELECT 'trailing' as x1; -- inside block comment\n" +
+ "*/\n" +
+ "SELECT * FROM a", plan)
+ }
+
+ test("nexted bracketed comment case one") {
+ val plan = table("a").select(star())
+ assertEqual("/* This block comment surrounds a query which itself has a block comment...\n" +
+ "SELECT /* embedded single line */ 'embedded' AS x2;\n" +
+ "*/\n" +
+ "SELECT * FROM a", plan)
+ }
+
+ test("nexted bracketed comment case two") {
+ val plan = table("a").select(star())
+ assertEqual("SELECT -- continued after the following block comments...\n" +
+ "/* Deeply nested comment.\n" +
+ " This includes a single apostrophe to make sure we aren't decoding this part as a " +
+ "string.\n" +
+ "SELECT 'deep nest' AS n1;\n" +
+ "/* Second level of nesting...\n" +
+ "SELECT 'deeper nest' as n2;\n" +
+ "/* Third level of nesting...\n" +
+ "SELECT 'deepest nest' as n3;\n" +
+ "*/\n" +
+ "Hoo boy. Still two deep...\n" +
+ "*/\n" +
+ "Now just one deep...\n" +
+ "*/\n" +
+ "* FROM a", plan)
+ }
Review comment:
You forgot to update the golden file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586053611
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23140/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r380395636
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -1801,7 +1801,7 @@ BRACKETED_EMPTY_COMMENT
;
BRACKETED_COMMENT
- : '/*' ~[+] .*? '*/' -> channel(HIDDEN)
+ : '/*' ~[+] (BRACKETED_COMMENT|.)*? '*/' -> channel(HIDDEN)
Review comment:
How about the @cloud-fan comment? The fix looks nice if we can. Its okay to fix it in followup though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r379888359
##########
File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/comments.sql
##########
@@ -47,4 +45,5 @@ Now just one deep...
*/
'deeply nested example' AS sixth;
--QUERY-DELIMITER-END
-/* and this is the end of the file */
+-- [SPARK-30824] Support submit sql content only contains comments.
Review comment:
Ah, I see. If so, can you move the parent ticket to https://issues.apache.org/jira/browse/SPARK-30375 ? I think this feature is implementation-dependent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589605659
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589717549
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23548/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589720895
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118786/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583720921
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22832/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587495714
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118630/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587376199
**[Test build #118620 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118620/testReport)** for PR 27495 at commit [`f1806ef`](https://github.com/apache/spark/commit/f1806ef7c41cc0fc757a407066ef49a40bb10be9).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589717549
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23548/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583711862
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118054/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586057216
**[Test build #118383 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118383/testReport)** for PR 27495 at commit [`519f47f`](https://github.com/apache/spark/commit/519f47fc7de0f753c6202bada0fa6972111d115f).
* This patch **fails MiMa tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586563978
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586563983
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118463/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587290393
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23364/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583711862
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118054/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583990907
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587790683
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118645/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589017616
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r378496425
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
##########
@@ -55,6 +55,65 @@ class PlanParserSuite extends AnalysisTest {
With(plan, ctes)
}
+ test("single comment") {
+ val plan = table("a").select(star())
+ assertEqual("-- single comment\nSELECT * FROM a", plan)
+ }
+
+ test("bracketed comment case one") {
+ val plan = table("a").select(star())
+ assertEqual(
+ """
+ |/* This is an example of SQL which should not execute:
+ | * select 'multi-line';
+ | */
+ |SELECT * FROM a
+ """.stripMargin, plan)
+ }
+
+ test("bracketed comment case two") {
+ val plan = table("a").select(star())
+ assertEqual(
+ """
+ |/*
+ |SELECT 'trailing' as x1; -- inside block comment
+ |*/
+ |SELECT * FROM a
+ """.stripMargin, plan)
+ }
+
+ test("nexted bracketed comment case one") {
+ val plan = table("a").select(star())
+ assertEqual(
+ """
+ |/* This block comment surrounds a query which itself has a block comment...
+ |SELECT /* embedded single line */ 'embedded' AS x2;
+ |*/
+ |SELECT * FROM a
+ """.stripMargin, plan)
+ }
+
+ test("nexted bracketed comment case two") {
Review comment:
ditoo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583726639
**[Test build #118069 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118069/testReport)** for PR 27495 at commit [`1b9d1da`](https://github.com/apache/spark/commit/1b9d1da8bd7942c7a37ca1fff6cc67d0113784da).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586345404
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer edited a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer edited a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583787726
> Since that's a minor fix, plz include it in this pr.
I have no idea that `SQLQueryTestSuite` treats nested bracketed comments well now.
https://github.com/apache/spark/pull/27481 treats bracketed comments well now.
I don't want the work for `SQLQueryTestSuite` blocks support for nested bracketed comments.
And I think these are two things.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587239864
**[Test build #118606 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118606/testReport)** for PR 27495 at commit [`25d0863`](https://github.com/apache/spark/commit/25d0863015e881819c67fdeb2e85c47dfb08f098).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583840338
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586563983
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118463/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583833685
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22860/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586257434
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23183/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586144462
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-585508951
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23088/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583755684
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583744307
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586181231
**[Test build #118413 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118413/testReport)** for PR 27495 at commit [`f2e7fb5`](https://github.com/apache/spark/commit/f2e7fb50e088203a3e3f45780a702e5afdd3a5e0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586333779
**[Test build #118435 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118435/testReport)** for PR 27495 at commit [`f5a817f`](https://github.com/apache/spark/commit/f5a817f594473677990e15676d59a3dde1201ce0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586378707
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118425/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586378697
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589575677
@cloud-fan
`'/*' (BRACKETED_COMMENT|.)*? '*/' {isHint()}? -> channel(HIDDEN)`
exists a issue that antlr matches bracketed comments or hint first and then call method `isHint`, so the matches will throw parse exception first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587331163
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586305028
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586278702
**[Test build #118429 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118429/testReport)** for PR 27495 at commit [`e1d3b3b`](https://github.com/apache/spark/commit/e1d3b3bbefebdcf14a27aeb2b5a1a051893d4001).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587054264
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586678147
Looks fine now except for one comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583990397
**[Test build #118105 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118105/testReport)** for PR 27495 at commit [`efe98fa`](https://github.com/apache/spark/commit/efe98fad056dbedf43a41256a2e4245c3e3372dd).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583787726
> Since that's a minor fix, plz include it in this pr.
I have no idea that `SQLQueryTestSuite` treats nested bracketed comments well.
https://github.com/apache/spark/pull/27481 treats bracketed comments well now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586562760
**[Test build #118462 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118462/testReport)** for PR 27495 at commit [`8e89a87`](https://github.com/apache/spark/commit/8e89a87d90aff36b45e018ed9a10cdaaa1007995).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r379996732
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -1801,7 +1801,7 @@ BRACKETED_EMPTY_COMMENT
;
BRACKETED_COMMENT
- : '/*' ~[+] .*? '*/' -> channel(HIDDEN)
+ : '/*' ~[+] (BRACKETED_COMMENT|.)*? '*/' -> channel(HIDDEN)
Review comment:
Actually does anyone know why there is `~[+]` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586457994
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586144473
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118394/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586278702
**[Test build #118429 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118429/testReport)** for PR 27495 at commit [`e1d3b3b`](https://github.com/apache/spark/commit/e1d3b3bbefebdcf14a27aeb2b5a1a051893d4001).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583734727
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22836/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu edited a comment on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
maropu edited a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583716990
I personally think that these supported comment syntax are documented in the Spark SQL Guide (along with the PostgreSQL/Vertica docs above). WDYT? cc: @dilipbiswal
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583755686
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118070/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583734612
**[Test build #118070 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118070/testReport)** for PR 27495 at commit [`3d03688`](https://github.com/apache/spark/commit/3d036886df60ec77f66e35142156803569577935).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583731692
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589829795
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118798/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-587411648
**[Test build #118630 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118630/testReport)** for PR 27495 at commit [`f1806ef`](https://github.com/apache/spark/commit/f1806ef7c41cc0fc757a407066ef49a40bb10be9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586089578
**[Test build #118394 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118394/testReport)** for PR 27495 at commit [`519f47f`](https://github.com/apache/spark/commit/519f47fc7de0f753c6202bada0fa6972111d115f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583723623
Can you remove the jira numbers below?
https://github.com/apache/spark/blob/12e1bbaddbb2ef304b5880a62df6683fcc94ea54/sql/core/src/test/resources/sql-tests/inputs/postgreSQL/comments.sql#L14
https://github.com/apache/spark/blob/12e1bbaddbb2ef304b5880a62df6683fcc94ea54/sql/core/src/test/resources/sql-tests/inputs/postgreSQL/comments.sql#L20
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583731693
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118063/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583833685
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22860/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586256534
**[Test build #118425 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118425/testReport)** for PR 27495 at commit [`1b188d7`](https://github.com/apache/spark/commit/1b188d792a1a2d67ec70415d8c22a21b5314a8ad).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586322181
**[Test build #118413 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118413/testReport)** for PR 27495 at commit [`f2e7fb5`](https://github.com/apache/spark/commit/f2e7fb50e088203a3e3f45780a702e5afdd3a5e0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583756431
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589605659
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-588725412
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586350522
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118437/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589617823
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23540/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-588725437
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118700/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r380007309
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -1801,7 +1801,7 @@ BRACKETED_EMPTY_COMMENT
;
BRACKETED_COMMENT
- : '/*' ~[+] .*? '*/' -> channel(HIDDEN)
+ : '/*' ~[+] (BRACKETED_COMMENT|.)*? '*/' -> channel(HIDDEN)
Review comment:
I will take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r380007905
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -1801,7 +1801,7 @@ BRACKETED_EMPTY_COMMENT
;
BRACKETED_COMMENT
- : '/*' ~[+] .*? '*/' -> channel(HIDDEN)
+ : '/*' ~[+] (BRACKETED_COMMENT|.)*? '*/' -> channel(HIDDEN)
Review comment:
can we create a lexer rule for hint and put it before this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583715077
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586164433
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583737471
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118066/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586257420
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589636980
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589717537
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586414044
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118430/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r376698708
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
##########
@@ -55,6 +55,54 @@ class PlanParserSuite extends AnalysisTest {
With(plan, ctes)
}
+ test("single comment") {
+ val plan = table("a").select(star())
+ assertEqual("-- single comment\nSELECT * FROM a", plan)
+ }
+
+ test("bracketed comment case one") {
+ val plan = table("a").select(star())
+ assertEqual("/* This is an example of SQL which should not execute:\n" +
+ " * select 'multi-line';\n" +
+ " */\n" +
+ "SELECT * FROM a", plan)
+ }
+
+ test("bracketed comment case two") {
+ val plan = table("a").select(star())
+ assertEqual("/*\n" +
+ "SELECT 'trailing' as x1; -- inside block comment\n" +
+ "*/\n" +
+ "SELECT * FROM a", plan)
+ }
+
+ test("nexted bracketed comment case one") {
+ val plan = table("a").select(star())
+ assertEqual("/* This block comment surrounds a query which itself has a block comment...\n" +
+ "SELECT /* embedded single line */ 'embedded' AS x2;\n" +
+ "*/\n" +
+ "SELECT * FROM a", plan)
+ }
+
+ test("nexted bracketed comment case two") {
+ val plan = table("a").select(star())
+ assertEqual("SELECT -- continued after the following block comments...\n" +
+ "/* Deeply nested comment.\n" +
+ " This includes a single apostrophe to make sure we aren't decoding this part as a " +
+ "string.\n" +
+ "SELECT 'deep nest' AS n1;\n" +
+ "/* Second level of nesting...\n" +
+ "SELECT 'deeper nest' as n2;\n" +
+ "/* Third level of nesting...\n" +
+ "SELECT 'deepest nest' as n3;\n" +
+ "*/\n" +
+ "Hoo boy. Still two deep...\n" +
+ "*/\n" +
+ "Now just one deep...\n" +
+ "*/\n" +
+ "* FROM a", plan)
+ }
Review comment:
Because that PR mainly to improve `SQLQueryTestSuite`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589599009
**[Test build #118785 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118785/testReport)** for PR 27495 at commit [`660cd34`](https://github.com/apache/spark/commit/660cd3424ef86ee43b1a8b04fad6ce00345049e9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r378611269
##########
File path: sql/core/src/test/resources/sql-tests/inputs/comments.sql
##########
@@ -0,0 +1,70 @@
+-- Test comments.
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated golden files
+-- bracketed comment case one
+/* This is the first example of bracketed comment.
+SELECT 'ommented out content' AS first;
+*/
+SELECT 'selected content' AS first;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated golden files
+-- bracketed comment case two
+/* This is the second example of bracketed comment.
+SELECT '/', 'ommented out content' AS second;
+*/
+SELECT '/', 'selected content' AS second;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated golden files
+-- bracketed comment case three
+/* This is the third example of bracketed comment.
+ *SELECT '*', 'ommented out content' AS third;
+ */
+SELECT '*', 'selected content' AS third;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated golden files
+-- nested bracketed comment case one
+/* This is the first example of nested bracketed comment.
+/* I am a nested bracketed comment.*/
+*/
+SELECT 'selected content' AS four;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated golden files
+-- nested bracketed comment case two
+/* This is the second example of nested bracketed comment.
+/* I am a nested bracketed comment.
+ */
+ */
+SELECT 'selected content' AS five;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated golden files
+-- nested bracketed comment case three
+/*
+ * This is the third example of nested bracketed comment.
+ /*
+ * I am a nested bracketed comment.
+ */
+ */
+SELECT 'selected content' AS six;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated golden files
+-- nested bracketed comment case four
+/*
+ * This is the four example of nested bracketed comment.
+SELECT /* I am a nested bracketed comment.*/ * FROM testData;
+ */
+SELECT 'selected content' AS seven;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated golden files
+-- nested bracketed comment case five
+SELECT /*
+ * This is the five example of nested bracketed comment.
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583715077
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583731538
**[Test build #118063 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118063/testReport)** for PR 27495 at commit [`c782bac`](https://github.com/apache/spark/commit/c782bacc785eee3441cc8e58a5bf85114a57a60f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589636991
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118790/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27495:
[SPARK-28880][SQL] Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589720880
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-586549083
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23220/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-585571402
**[Test build #118331 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118331/testReport)** for PR 27495 at commit [`a2241ae`](https://github.com/apache/spark/commit/a2241aea0c600f209f5cba8427bb74fd70123de7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-583714995
**[Test build #118063 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118063/testReport)** for PR 27495 at commit [`c782bac`](https://github.com/apache/spark/commit/c782bacc785eee3441cc8e58a5bf85114a57a60f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#issuecomment-589829134
**[Test build #118798 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118798/testReport)** for PR 27495 at commit [`48814c3`](https://github.com/apache/spark/commit/48814c356794ea97191c09416958296be5b01e7f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org