You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "jp0317 (via GitHub)" <gi...@apache.org> on 2024/12/12 22:40:12 UTC
[PR] check overflow on getting field id [thrift]
jp0317 opened a new pull request, #3075:
URL: https://github.com/apache/thrift/pull/3075
Add overflow checking when getting field id based on field delta.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] check overflow on getting field id [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #3075:
URL: https://github.com/apache/thrift/pull/3075#issuecomment-2692345522
Maybe but it breaks the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] check overflow on getting field id [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G merged PR #3075:
URL: https://github.com/apache/thrift/pull/3075
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] check overflow on getting field id [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #3075:
URL: https://github.com/apache/thrift/pull/3075#issuecomment-2691575557
Sth is not right here
error: use of `ok_or` followed by a function call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] check overflow on getting field id [thrift]
Posted by "jp0317 (via GitHub)" <gi...@apache.org>.
jp0317 commented on PR #3075:
URL: https://github.com/apache/thrift/pull/3075#issuecomment-2691725293
yeah, it's should be fine to use `ok_or` there. this seems to be a false alarm (found a similar issue [here](https://github.com/rust-lang/rust-clippy/issues/1609))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] check overflow on getting field id [thrift]
Posted by "jimexist (via GitHub)" <gi...@apache.org>.
jimexist commented on PR #3075:
URL: https://github.com/apache/thrift/pull/3075#issuecomment-2746309303
ok or else saves one allocation, it's trivial to change to that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] check overflow on getting field id [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #3075:
URL: https://github.com/apache/thrift/pull/3075#issuecomment-2815048081
> trivial to change to that
Seems not the case ... or is it? 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] check overflow on getting field id [thrift]
Posted by "jp0317 (via GitHub)" <gi...@apache.org>.
jp0317 commented on PR #3075:
URL: https://github.com/apache/thrift/pull/3075#issuecomment-3555818758
sorry for the late reply. I've updated to use `ok_or_else`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] check overflow on getting field id [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #3075:
URL: https://github.com/apache/thrift/pull/3075#issuecomment-3553608794
Any progress here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org