You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/11/05 12:31:49 UTC

[GitHub] [camel-quarkus] JiriOndrusek opened a new pull request #3272: Sql doc update because of the failure with external oracle database #…

JiriOndrusek opened a new pull request #3272:
URL: https://github.com/apache/camel-quarkus/pull/3272


   Doc update for (does not fix the issue) https://github.com/apache/camel-quarkus/issues/3256
   
   <!-- Uncomment and fill this section if your PR is not trivial
   [ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
   [ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
   [ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
   [ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
   [ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
   [ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #3272: Sql doc update because of the failure with external oracle database #…

Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #3272:
URL: https://github.com/apache/camel-quarkus/pull/3272#discussion_r743697604



##########
File path: docs/modules/ROOT/pages/reference/extensions/sql.adoc
##########
@@ -40,6 +40,14 @@ Or add the coordinates to your existing project:
 
 Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
 
+== Camel Quarkus limitations
+
+While you can use any of the available database types in JVM mode, Oracle database type negatively affects serialization in native mode.
+See quarkus issue https://github.com/quarkusio/quarkus/issues/20396[#https://github.com/quarkusio/quarkus/issues/20396] for more dtails.
+
+https://camel.apache.org/components/next/sql-component.html#_using_the_jdbc_based_aggregation_repository[Aggregation repository] does not work in native mode with Oracle db, because of this issue.

Review comment:
       Tentative: maybe @jamesnetherton or @zhfeng would remember having done that in a previous PR ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #3272: Sql doc update because of the failure with external oracle database #…

Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #3272:
URL: https://github.com/apache/camel-quarkus/pull/3272#discussion_r743662839



##########
File path: docs/modules/ROOT/pages/reference/extensions/sql.adoc
##########
@@ -40,6 +40,14 @@ Or add the coordinates to your existing project:
 
 Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
 
+== Camel Quarkus limitations
+
+While you can use any of the available database types in JVM mode, Oracle database type negatively affects serialization in native mode.
+See quarkus issue https://github.com/quarkusio/quarkus/issues/20396[#https://github.com/quarkusio/quarkus/issues/20396] for more dtails.

Review comment:
       Small rephrase: for more **details** ?

##########
File path: docs/modules/ROOT/pages/reference/extensions/sql.adoc
##########
@@ -40,6 +40,14 @@ Or add the coordinates to your existing project:
 
 Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
 
+== Camel Quarkus limitations
+
+While you can use any of the available database types in JVM mode, Oracle database type negatively affects serialization in native mode.
+See quarkus issue https://github.com/quarkusio/quarkus/issues/20396[#https://github.com/quarkusio/quarkus/issues/20396] for more dtails.
+
+https://camel.apache.org/components/next/sql-component.html#_using_the_jdbc_based_aggregation_repository[Aggregation repository] does not work in native mode with Oracle db, because of this issue.

Review comment:
       I thought it was possible to link this in a relative way but can't find it anymore.

##########
File path: docs/modules/ROOT/pages/reference/extensions/sql.adoc
##########
@@ -40,6 +40,14 @@ Or add the coordinates to your existing project:
 
 Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
 
+== Camel Quarkus limitations
+
+While you can use any of the available database types in JVM mode, Oracle database type negatively affects serialization in native mode.
+See quarkus issue https://github.com/quarkusio/quarkus/issues/20396[#https://github.com/quarkusio/quarkus/issues/20396] for more dtails.
+
+https://camel.apache.org/components/next/sql-component.html#_using_the_jdbc_based_aggregation_repository[Aggregation repository] does not work in native mode with Oracle db, because of this issue.

Review comment:
       Tentative: maybe @jamesnetherton or @zhfeng would remember having done that in a previous PR ?

##########
File path: docs/modules/ROOT/pages/reference/extensions/sql.adoc
##########
@@ -40,6 +40,14 @@ Or add the coordinates to your existing project:
 
 Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
 
+== Camel Quarkus limitations
+
+While you can use any of the available database types in JVM mode, Oracle database type negatively affects serialization in native mode.
+See quarkus issue https://github.com/quarkusio/quarkus/issues/20396[#https://github.com/quarkusio/quarkus/issues/20396] for more dtails.

Review comment:
       Small rephrase: for more **details** ?

##########
File path: docs/modules/ROOT/pages/reference/extensions/sql.adoc
##########
@@ -40,6 +40,14 @@ Or add the coordinates to your existing project:
 
 Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
 
+== Camel Quarkus limitations
+
+While you can use any of the available database types in JVM mode, Oracle database type negatively affects serialization in native mode.
+See quarkus issue https://github.com/quarkusio/quarkus/issues/20396[#https://github.com/quarkusio/quarkus/issues/20396] for more dtails.
+
+https://camel.apache.org/components/next/sql-component.html#_using_the_jdbc_based_aggregation_repository[Aggregation repository] does not work in native mode with Oracle db, because of this issue.

Review comment:
       I thought it was possible to link this in a relative way but can't find it anymore.

##########
File path: docs/modules/ROOT/pages/reference/extensions/sql.adoc
##########
@@ -40,6 +40,14 @@ Or add the coordinates to your existing project:
 
 Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
 
+== Camel Quarkus limitations
+
+While you can use any of the available database types in JVM mode, Oracle database type negatively affects serialization in native mode.
+See quarkus issue https://github.com/quarkusio/quarkus/issues/20396[#https://github.com/quarkusio/quarkus/issues/20396] for more dtails.
+
+https://camel.apache.org/components/next/sql-component.html#_using_the_jdbc_based_aggregation_repository[Aggregation repository] does not work in native mode with Oracle db, because of this issue.

Review comment:
       Tentative: maybe @jamesnetherton or @zhfeng would remember having done that in a previous PR ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #3272: Sql doc update because of the failure with external oracle database #…

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #3272:
URL: https://github.com/apache/camel-quarkus/pull/3272#discussion_r743668348



##########
File path: docs/modules/ROOT/pages/reference/extensions/sql.adoc
##########
@@ -40,6 +40,14 @@ Or add the coordinates to your existing project:
 
 Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
 
+== Camel Quarkus limitations
+
+While you can use any of the available database types in JVM mode, Oracle database type negatively affects serialization in native mode.
+See quarkus issue https://github.com/quarkusio/quarkus/issues/20396[#https://github.com/quarkusio/quarkus/issues/20396] for more dtails.

Review comment:
       I'll fix it, thanks for noticing it

##########
File path: docs/modules/ROOT/pages/reference/extensions/sql.adoc
##########
@@ -40,6 +40,14 @@ Or add the coordinates to your existing project:
 
 Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
 
+== Camel Quarkus limitations
+
+While you can use any of the available database types in JVM mode, Oracle database type negatively affects serialization in native mode.
+See quarkus issue https://github.com/quarkusio/quarkus/issues/20396[#https://github.com/quarkusio/quarkus/issues/20396] for more dtails.
+
+https://camel.apache.org/components/next/sql-component.html#_using_the_jdbc_based_aggregation_repository[Aggregation repository] does not work in native mode with Oracle db, because of this issue.

Review comment:
       Relative link would be much better. I quickly went through doc files in extensions and didn't find it either.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] ppalaga merged pull request #3272: Sql doc update because of the failure with external oracle database #…

Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #3272:
URL: https://github.com/apache/camel-quarkus/pull/3272


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #3272: Sql doc update because of the failure with external oracle database #…

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #3272:
URL: https://github.com/apache/camel-quarkus/pull/3272#issuecomment-992632149


   @aldetinger Yes you are right, only small fixes (mainly doc) is need to be done. Unfortunately I'm not sure when I'll be able to fix it (maybe end of this week). But feel free to fix those small issues if you have a free capacity.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #3272: Sql doc update because of the failure with external oracle database #…

Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #3272:
URL: https://github.com/apache/camel-quarkus/pull/3272#discussion_r747643587



##########
File path: docs/modules/ROOT/pages/reference/extensions/sql.adoc
##########
@@ -40,6 +40,14 @@ Or add the coordinates to your existing project:
 
 Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
 
+== Camel Quarkus limitations
+
+While you can use any of the available database types in JVM mode, Oracle database type negatively affects serialization in native mode.
+See quarkus issue https://github.com/quarkusio/quarkus/issues/20396[#https://github.com/quarkusio/quarkus/issues/20396] for more dtails.
+
+https://camel.apache.org/components/next/sql-component.html#_using_the_jdbc_based_aggregation_repository[Aggregation repository] does not work in native mode with Oracle db, because of this issue.

Review comment:
       `xref:{cq-camel-components}::sql-component.adoc` as proposed below




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #3272: Sql doc update because of the failure with external oracle database #…

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #3272:
URL: https://github.com/apache/camel-quarkus/pull/3272#discussion_r743676654



##########
File path: docs/modules/ROOT/pages/reference/extensions/sql.adoc
##########
@@ -40,6 +40,14 @@ Or add the coordinates to your existing project:
 
 Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
 
+== Camel Quarkus limitations
+
+While you can use any of the available database types in JVM mode, Oracle database type negatively affects serialization in native mode.
+See quarkus issue https://github.com/quarkusio/quarkus/issues/20396[#https://github.com/quarkusio/quarkus/issues/20396] for more dtails.
+
+https://camel.apache.org/components/next/sql-component.html#_using_the_jdbc_based_aggregation_repository[Aggregation repository] does not work in native mode with Oracle db, because of this issue.

Review comment:
       Relative link would be much better. I quickly went through doc files in extensions and didn't find it either.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #3272: Sql doc update because of the failure with external oracle database #…

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #3272:
URL: https://github.com/apache/camel-quarkus/pull/3272#issuecomment-993272479


   @aldettinger PR is fixed, it could be merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #3272: Sql doc update because of the failure with external oracle database #…

Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #3272:
URL: https://github.com/apache/camel-quarkus/pull/3272#discussion_r743662839



##########
File path: docs/modules/ROOT/pages/reference/extensions/sql.adoc
##########
@@ -40,6 +40,14 @@ Or add the coordinates to your existing project:
 
 Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
 
+== Camel Quarkus limitations
+
+While you can use any of the available database types in JVM mode, Oracle database type negatively affects serialization in native mode.
+See quarkus issue https://github.com/quarkusio/quarkus/issues/20396[#https://github.com/quarkusio/quarkus/issues/20396] for more dtails.

Review comment:
       Small rephrase: for more **details** ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] aldettinger commented on pull request #3272: Sql doc update because of the failure with external oracle database #…

Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #3272:
URL: https://github.com/apache/camel-quarkus/pull/3272#issuecomment-992617932


   @JiriOndrusek A small up on this PR. My understanding is that it just needs few fixes ? Or am I missing some context ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #3272: Sql doc update because of the failure with external oracle database #…

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #3272:
URL: https://github.com/apache/camel-quarkus/pull/3272#discussion_r768410303



##########
File path: docs/modules/ROOT/pages/reference/extensions/sql.adoc
##########
@@ -40,6 +40,14 @@ Or add the coordinates to your existing project:
 
 Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
 
+== Camel Quarkus limitations
+
+While you can use any of the available database types in JVM mode, Oracle database type negatively affects serialization in native mode.
+See quarkus issue https://github.com/quarkusio/quarkus/issues/20396[#https://github.com/quarkusio/quarkus/issues/20396] for more dtails.
+
+https://camel.apache.org/components/next/sql-component.html#_using_the_jdbc_based_aggregation_repository[Aggregation repository] does not work in native mode with Oracle db, because of this issue.

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #3272: Sql doc update because of the failure with external oracle database #…

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #3272:
URL: https://github.com/apache/camel-quarkus/pull/3272#discussion_r743668348



##########
File path: docs/modules/ROOT/pages/reference/extensions/sql.adoc
##########
@@ -40,6 +40,14 @@ Or add the coordinates to your existing project:
 
 Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
 
+== Camel Quarkus limitations
+
+While you can use any of the available database types in JVM mode, Oracle database type negatively affects serialization in native mode.
+See quarkus issue https://github.com/quarkusio/quarkus/issues/20396[#https://github.com/quarkusio/quarkus/issues/20396] for more dtails.

Review comment:
       I'll fix it, thanks for noticing it

##########
File path: docs/modules/ROOT/pages/reference/extensions/sql.adoc
##########
@@ -40,6 +40,14 @@ Or add the coordinates to your existing project:
 
 Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
 
+== Camel Quarkus limitations
+
+While you can use any of the available database types in JVM mode, Oracle database type negatively affects serialization in native mode.
+See quarkus issue https://github.com/quarkusio/quarkus/issues/20396[#https://github.com/quarkusio/quarkus/issues/20396] for more dtails.
+
+https://camel.apache.org/components/next/sql-component.html#_using_the_jdbc_based_aggregation_repository[Aggregation repository] does not work in native mode with Oracle db, because of this issue.

Review comment:
       Relative link would be much better. I quickly went through doc files in extensions and didn't find it either.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek edited a comment on pull request #3272: Sql doc update because of the failure with external oracle database #…

Posted by GitBox <gi...@apache.org>.
JiriOndrusek edited a comment on pull request #3272:
URL: https://github.com/apache/camel-quarkus/pull/3272#issuecomment-992632149


   @aldettinger  Yes you are right, only small fixes (mainly doc) is need to be done. ~~Unfortunately I'm not sure when I'll be able to fix it (maybe end of this week). But feel free to fix those small issues if you have a free capacity.~~
   
   edited:
   
   I should fix it today.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #3272: Sql doc update because of the failure with external oracle database #…

Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #3272:
URL: https://github.com/apache/camel-quarkus/pull/3272#discussion_r743669158



##########
File path: docs/modules/ROOT/pages/reference/extensions/sql.adoc
##########
@@ -40,6 +40,14 @@ Or add the coordinates to your existing project:
 
 Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
 
+== Camel Quarkus limitations
+
+While you can use any of the available database types in JVM mode, Oracle database type negatively affects serialization in native mode.
+See quarkus issue https://github.com/quarkusio/quarkus/issues/20396[#https://github.com/quarkusio/quarkus/issues/20396] for more dtails.
+
+https://camel.apache.org/components/next/sql-component.html#_using_the_jdbc_based_aggregation_repository[Aggregation repository] does not work in native mode with Oracle db, because of this issue.

Review comment:
       I thought it was possible to link this in a relative way but can't find it anymore.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] aldettinger commented on pull request #3272: Sql doc update because of the failure with external oracle database #…

Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #3272:
URL: https://github.com/apache/camel-quarkus/pull/3272#issuecomment-993311223


   @JiriOndrusek @ppalaga Thanks all.
   
   Sorry for this late comment. It turns out that quarkusio/quarkus#20396 was fixed in the mean time. My understanding is that we still have #3256 to manage it on our side, so that's ok.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #3272: Sql doc update because of the failure with external oracle database #…

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #3272:
URL: https://github.com/apache/camel-quarkus/pull/3272#discussion_r768410415



##########
File path: extensions/sql/runtime/src/main/doc/limitations.adoc
##########
@@ -0,0 +1,4 @@
+While you can use any of the available database types in JVM mode, Oracle database type negatively affects serialization in native mode.
+See quarkus issue https://github.com/quarkusio/quarkus/issues/20396[#https://github.com/quarkusio/quarkus/issues/20396] for more details.
+
+https://camel.apache.org/components/next/sql-component.html#_using_the_jdbc_based_aggregation_repository[Aggregation repository] does not work in native mode with Oracle db, because of this issue.

Review comment:
       done 

##########
File path: extensions/sql/runtime/src/main/doc/limitations.adoc
##########
@@ -0,0 +1,4 @@
+While you can use any of the available database types in JVM mode, Oracle database type negatively affects serialization in native mode.
+See quarkus issue https://github.com/quarkusio/quarkus/issues/20396[#https://github.com/quarkusio/quarkus/issues/20396] for more details.
+

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #3272: Sql doc update because of the failure with external oracle database #…

Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #3272:
URL: https://github.com/apache/camel-quarkus/pull/3272#discussion_r747641035



##########
File path: extensions/sql/runtime/src/main/doc/limitations.adoc
##########
@@ -0,0 +1,4 @@
+While you can use any of the available database types in JVM mode, Oracle database type negatively affects serialization in native mode.
+See quarkus issue https://github.com/quarkusio/quarkus/issues/20396[#https://github.com/quarkusio/quarkus/issues/20396] for more details.
+

Review comment:
       ```suggestion
   Oracle JDBC driver brings some GraalVM native-image configuration that breaks the serialization support in Camel Quarkus and Quarkus in general. See this https://github.com/quarkusio/quarkus/issues/20396[quarkus issue] for more details.
   ```

##########
File path: extensions/sql/runtime/src/main/doc/limitations.adoc
##########
@@ -0,0 +1,4 @@
+While you can use any of the available database types in JVM mode, Oracle database type negatively affects serialization in native mode.
+See quarkus issue https://github.com/quarkusio/quarkus/issues/20396[#https://github.com/quarkusio/quarkus/issues/20396] for more details.
+
+https://camel.apache.org/components/next/sql-component.html#_using_the_jdbc_based_aggregation_repository[Aggregation repository] does not work in native mode with Oracle db, because of this issue.

Review comment:
       ```suggestion
   xref:{cq-camel-components}::sql-component.adoc#_using_the_jdbc_based_aggregation_repository[Aggregation repository] does not work in native mode with Oracle DB, because of this issue.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #3272: Sql doc update because of the failure with external oracle database #…

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #3272:
URL: https://github.com/apache/camel-quarkus/pull/3272#discussion_r743668348



##########
File path: docs/modules/ROOT/pages/reference/extensions/sql.adoc
##########
@@ -40,6 +40,14 @@ Or add the coordinates to your existing project:
 
 Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
 
+== Camel Quarkus limitations
+
+While you can use any of the available database types in JVM mode, Oracle database type negatively affects serialization in native mode.
+See quarkus issue https://github.com/quarkusio/quarkus/issues/20396[#https://github.com/quarkusio/quarkus/issues/20396] for more dtails.

Review comment:
       I'll fix it, thanks for noticing it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org