You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/05 23:45:42 UTC
[GitHub] [geode] mhansonp commented on a change in pull request #5188: GEODE-8099: add dlock around cms create/delete operations.
mhansonp commented on a change in pull request #5188:
URL: https://github.com/apache/geode/pull/5188#discussion_r436208620
##########
File path: geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/InternalLocatorClusterManagementServiceIntegrationTest.java
##########
@@ -56,13 +57,38 @@ public void tearDown() {
}
}
+ @Before
+ public void setup() throws URISyntaxException {
+ distributionConfig = mock(DistributionConfigImpl.class);
+ cache = mock(InternalCacheForClientAccess.class);
+ managementService = mock(BaseManagementService.class);
Review comment:
With these changes does this test need to become a unit test rather than an integration test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org