You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oodt.apache.org by brian Foster <ho...@juno.com> on 2012/03/06 08:57:51 UTC
Review Request: Ability for File Manager to stage an ingested Product to one
of its clients
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4195/
-----------------------------------------------------------
Review request for oodt, Chris Mattmann and Paul Ramirez.
Summary
-------
$ ./filemgr-client -h retrieveFilesById
** Action Help for 'retrieveFilesById' **
> DESCRIPTION:
Retrieve a Product's files by Product ID
> USAGE:
Required:
-dest [--destination] <classpath>
-op [--operation]
-rfbyid [--retrieveFilesById] (required)
-pid [--productId] <product-id>
-trans [--transferer] <classpath>
-u [--url] <url>
Optional:
> EXAMPLES:
- N/A
$ ./filemgr-client -h retrieveFilesByName
** Action Help for 'retrieveFilesByName' **
> DESCRIPTION:
Retrieve a Product's files by Product name
> USAGE:
Required:
-dest [--destination] <classpath>
-op [--operation]
-rfbyn [--retrieveFilesByName] (required)
-pn [--productName] <product-name>
-trans [--transferer] <classpath>
-u [--url] <url>
Optional:
> EXAMPLES:
- N/A
This addresses bug OODT-84.
https://issues.apache.org/jira/browse/OODT-84
Diffs
-----
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/LocalDataTransferer.java 1297159
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/InPlaceDataTransferer.java 1297159
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/DataTransfer.java 1297159
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/RetrieveFilesCliAction.java PRE-CREATION
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/RemoteDataTransferer.java 1297159
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/system/XmlRpcFileManager.java 1297159
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/system/XmlRpcFileManagerClient.java 1297159
trunk/filemgr/src/main/resources/cmd-line-actions.xml 1297159
trunk/filemgr/src/main/resources/cmd-line-options.xml 1297159
trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/TestFileManagerCli.java 1297159
trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/system/MockXmlRpcFileManagerClient.java 1297159
Diff: https://reviews.apache.org/r/4195/diff
Testing
-------
Added unit-tests
Thanks,
brian
Re: Review Request: Ability for File Manager to stage an ingested Product to
one of its clients
Posted by brian Foster <ho...@juno.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4195/
-----------------------------------------------------------
(Updated 2012-03-09 07:55:23.448447)
Review request for oodt, Chris Mattmann and Paul Ramirez.
Changes
-------
1) destination: <classpath> -> <directory>
2) transferer: <classpath> -> <transfer factory class>
Summary (updated)
-------
$ ./filemgr-client -h retrieveFilesById
** Action Help for 'retrieveFilesById' **
> DESCRIPTION:
Retrieve a Product's files by Product ID
> USAGE:
Required:
-dest [--destination] <directory>
-op [--operation]
-rfbyid [--retrieveFilesById] (required)
-pid [--productId] <product-id>
-trans [--transferer] <transfer factory class>
-u [--url] <url>
Optional:
> EXAMPLES:
- N/A
$ ./filemgr-client -h retrieveFilesByName
** Action Help for 'retrieveFilesByName' **
> DESCRIPTION:
Retrieve a Product's files by Product name
> USAGE:
Required:
-dest [--destination] <directory>
-op [--operation]
-rfbyn [--retrieveFilesByName] (required)
-pn [--productName] <product-name>
-trans [--transferer] <transfer factory class>
-u [--url] <url>
Optional:
> EXAMPLES:
- N/A
This addresses bug OODT-84.
https://issues.apache.org/jira/browse/OODT-84
Diffs
-----
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/LocalDataTransferer.java 1297159
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/InPlaceDataTransferer.java 1297159
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/DataTransfer.java 1297159
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/RetrieveFilesCliAction.java PRE-CREATION
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/RemoteDataTransferer.java 1297159
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/system/XmlRpcFileManager.java 1297159
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/system/XmlRpcFileManagerClient.java 1297159
trunk/filemgr/src/main/resources/cmd-line-actions.xml 1297159
trunk/filemgr/src/main/resources/cmd-line-options.xml 1297159
trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/TestFileManagerCli.java 1297159
trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/system/MockXmlRpcFileManagerClient.java 1297159
Diff: https://reviews.apache.org/r/4195/diff
Testing
-------
Added unit-tests
Thanks,
brian
Re: Review Request: Ability for File Manager to stage an ingested Product to
one of its clients
Posted by brian Foster <ho...@juno.com>.
> On 2012-03-06 23:23:24, Chris Mattmann wrote:
> > Hey Brian: couple questions:
> >
> > - is destination a versioner? I see we're calling the param "classpath". Should we use <versioner class>?
> > - same goes for transferer. I think that's a Transfer factory, right? If so, can we use <transfer factory class>?
ops... directory is supposed to be <directory>... will fix... was copy/paste happy... the action basically will retrieve a Product's file into the given "destination" directory.
- brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4195/#review5664
-----------------------------------------------------------
On 2012-03-06 07:57:51, brian Foster wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4195/
> -----------------------------------------------------------
>
> (Updated 2012-03-06 07:57:51)
>
>
> Review request for oodt, Chris Mattmann and Paul Ramirez.
>
>
> Summary
> -------
>
> $ ./filemgr-client -h retrieveFilesById
>
> ** Action Help for 'retrieveFilesById' **
> > DESCRIPTION:
> Retrieve a Product's files by Product ID
>
> > USAGE:
> Required:
> -dest [--destination] <classpath>
> -op [--operation]
> -rfbyid [--retrieveFilesById] (required)
> -pid [--productId] <product-id>
> -trans [--transferer] <classpath>
> -u [--url] <url>
> Optional:
>
> > EXAMPLES:
> - N/A
>
>
> $ ./filemgr-client -h retrieveFilesByName
>
> ** Action Help for 'retrieveFilesByName' **
> > DESCRIPTION:
> Retrieve a Product's files by Product name
>
> > USAGE:
> Required:
> -dest [--destination] <classpath>
> -op [--operation]
> -rfbyn [--retrieveFilesByName] (required)
> -pn [--productName] <product-name>
> -trans [--transferer] <classpath>
> -u [--url] <url>
> Optional:
>
> > EXAMPLES:
> - N/A
>
>
> This addresses bug OODT-84.
> https://issues.apache.org/jira/browse/OODT-84
>
>
> Diffs
> -----
>
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/LocalDataTransferer.java 1297159
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/InPlaceDataTransferer.java 1297159
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/DataTransfer.java 1297159
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/RetrieveFilesCliAction.java PRE-CREATION
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/RemoteDataTransferer.java 1297159
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/system/XmlRpcFileManager.java 1297159
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/system/XmlRpcFileManagerClient.java 1297159
> trunk/filemgr/src/main/resources/cmd-line-actions.xml 1297159
> trunk/filemgr/src/main/resources/cmd-line-options.xml 1297159
> trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/TestFileManagerCli.java 1297159
> trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/system/MockXmlRpcFileManagerClient.java 1297159
>
> Diff: https://reviews.apache.org/r/4195/diff
>
>
> Testing
> -------
>
> Added unit-tests
>
>
> Thanks,
>
> brian
>
>
Re: Review Request: Ability for File Manager to stage an ingested Product to
one of its clients
Posted by brian Foster <ho...@juno.com>.
> On 2012-03-06 23:23:24, Chris Mattmann wrote:
> > Hey Brian: couple questions:
> >
> > - is destination a versioner? I see we're calling the param "classpath". Should we use <versioner class>?
> > - same goes for transferer. I think that's a Transfer factory, right? If so, can we use <transfer factory class>?
>
> brian Foster wrote:
> ops... directory is supposed to be <directory>... will fix... was copy/paste happy... the action basically will retrieve a Product's file into the given "destination" directory.
classpath is supposed to be directory
- brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4195/#review5664
-----------------------------------------------------------
On 2012-03-06 07:57:51, brian Foster wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4195/
> -----------------------------------------------------------
>
> (Updated 2012-03-06 07:57:51)
>
>
> Review request for oodt, Chris Mattmann and Paul Ramirez.
>
>
> Summary
> -------
>
> $ ./filemgr-client -h retrieveFilesById
>
> ** Action Help for 'retrieveFilesById' **
> > DESCRIPTION:
> Retrieve a Product's files by Product ID
>
> > USAGE:
> Required:
> -dest [--destination] <classpath>
> -op [--operation]
> -rfbyid [--retrieveFilesById] (required)
> -pid [--productId] <product-id>
> -trans [--transferer] <classpath>
> -u [--url] <url>
> Optional:
>
> > EXAMPLES:
> - N/A
>
>
> $ ./filemgr-client -h retrieveFilesByName
>
> ** Action Help for 'retrieveFilesByName' **
> > DESCRIPTION:
> Retrieve a Product's files by Product name
>
> > USAGE:
> Required:
> -dest [--destination] <classpath>
> -op [--operation]
> -rfbyn [--retrieveFilesByName] (required)
> -pn [--productName] <product-name>
> -trans [--transferer] <classpath>
> -u [--url] <url>
> Optional:
>
> > EXAMPLES:
> - N/A
>
>
> This addresses bug OODT-84.
> https://issues.apache.org/jira/browse/OODT-84
>
>
> Diffs
> -----
>
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/LocalDataTransferer.java 1297159
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/InPlaceDataTransferer.java 1297159
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/DataTransfer.java 1297159
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/RetrieveFilesCliAction.java PRE-CREATION
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/RemoteDataTransferer.java 1297159
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/system/XmlRpcFileManager.java 1297159
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/system/XmlRpcFileManagerClient.java 1297159
> trunk/filemgr/src/main/resources/cmd-line-actions.xml 1297159
> trunk/filemgr/src/main/resources/cmd-line-options.xml 1297159
> trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/TestFileManagerCli.java 1297159
> trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/system/MockXmlRpcFileManagerClient.java 1297159
>
> Diff: https://reviews.apache.org/r/4195/diff
>
>
> Testing
> -------
>
> Added unit-tests
>
>
> Thanks,
>
> brian
>
>
Re: Review Request: Ability for File Manager to stage an ingested Product to
one of its clients
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4195/#review5664
-----------------------------------------------------------
Hey Brian: couple questions:
- is destination a versioner? I see we're calling the param "classpath". Should we use <versioner class>?
- same goes for transferer. I think that's a Transfer factory, right? If so, can we use <transfer factory class>?
- Chris
On 2012-03-06 07:57:51, brian Foster wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4195/
> -----------------------------------------------------------
>
> (Updated 2012-03-06 07:57:51)
>
>
> Review request for oodt, Chris Mattmann and Paul Ramirez.
>
>
> Summary
> -------
>
> $ ./filemgr-client -h retrieveFilesById
>
> ** Action Help for 'retrieveFilesById' **
> > DESCRIPTION:
> Retrieve a Product's files by Product ID
>
> > USAGE:
> Required:
> -dest [--destination] <classpath>
> -op [--operation]
> -rfbyid [--retrieveFilesById] (required)
> -pid [--productId] <product-id>
> -trans [--transferer] <classpath>
> -u [--url] <url>
> Optional:
>
> > EXAMPLES:
> - N/A
>
>
> $ ./filemgr-client -h retrieveFilesByName
>
> ** Action Help for 'retrieveFilesByName' **
> > DESCRIPTION:
> Retrieve a Product's files by Product name
>
> > USAGE:
> Required:
> -dest [--destination] <classpath>
> -op [--operation]
> -rfbyn [--retrieveFilesByName] (required)
> -pn [--productName] <product-name>
> -trans [--transferer] <classpath>
> -u [--url] <url>
> Optional:
>
> > EXAMPLES:
> - N/A
>
>
> This addresses bug OODT-84.
> https://issues.apache.org/jira/browse/OODT-84
>
>
> Diffs
> -----
>
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/LocalDataTransferer.java 1297159
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/InPlaceDataTransferer.java 1297159
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/DataTransfer.java 1297159
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/RetrieveFilesCliAction.java PRE-CREATION
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/RemoteDataTransferer.java 1297159
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/system/XmlRpcFileManager.java 1297159
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/system/XmlRpcFileManagerClient.java 1297159
> trunk/filemgr/src/main/resources/cmd-line-actions.xml 1297159
> trunk/filemgr/src/main/resources/cmd-line-options.xml 1297159
> trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/TestFileManagerCli.java 1297159
> trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/system/MockXmlRpcFileManagerClient.java 1297159
>
> Diff: https://reviews.apache.org/r/4195/diff
>
>
> Testing
> -------
>
> Added unit-tests
>
>
> Thanks,
>
> brian
>
>