[GitHub] [arrow-datafusion] alamb commented on a change in pull request #2113: issue#1967 ignore channel close

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #2113:
URL: https://github.com/apache/arrow-datafusion/pull/2113#discussion_r837299762



##########
File path: datafusion/core/src/physical_plan/file_format/parquet.rs
##########
@@ -503,8 +503,9 @@ fn read_partition(
                     let proj_batch = partition_column_projector
                         .project(adapted_batch, &partitioned_file.partition_values);
 
-                    send_result(&response_tx, proj_batch)?;
-                    if limit.map(|l| total_rows >= l).unwrap_or(false) {
+                    let send_rt = send_result(&response_tx, proj_batch);

Review comment:
       I think it makes sense not to error if `send_result` fails due to the receiver being closed. I checked that this is the only error `send_result` can make: https://github.com/apache/arrow-datafusion/blob/41b4e491663029f653e491b110d0b5e74d08a0b6/datafusion/core/src/physical_plan/file_format/parquet.rs#L309
   
   👍 

##########
File path: datafusion/core/src/physical_plan/file_format/parquet.rs
##########
@@ -515,10 +516,10 @@ fn read_partition(
                     let err_msg =
                         format!("Error reading batch from {}: {}", partitioned_file, e);
                     // send error to operator
-                    send_result(
+                    let _ = send_result(

Review comment:
       ```suggestion
                       // send_result error, if any, should not overwrite the original ArrowError, so ignore it
                       let _ = send_result(
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org