You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/09/09 16:20:39 UTC
[GitHub] [lucene-solr] uschindler opened a new pull request #1850: LUCENE-9517: Don't subclass Deflater and instead create a patch for setDictionary() using a functional interface
uschindler opened a new pull request #1850:
URL: https://github.com/apache/lucene-solr/pull/1850
Bugfix for LUCENE-9517: Instead of subclassing Deflater like in LUCENE-9500, we just provide a method reference (using a functional interface), so code can call Deflater#setDictionary.
The issue was caused by a missing AccessController#setPrivileged() in JDK's code when Deflater was subclassed. This workaround does not subclass, so the missing doPrivileged is not needed.
This also adds the faulty methods to forbiddenapis.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] uschindler merged pull request #1850: LUCENE-9517: Don't subclass Deflater and instead create a patch for setDictionary() using a functional interface
Posted by GitBox <gi...@apache.org>.
uschindler merged pull request #1850:
URL: https://github.com/apache/lucene-solr/pull/1850
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jpountz commented on pull request #1850: LUCENE-9517: Don't subclass Deflater and instead create a patch for setDictionary() using a functional interface
Posted by GitBox <gi...@apache.org>.
jpountz commented on pull request #1850:
URL: https://github.com/apache/lucene-solr/pull/1850#issuecomment-692159551
Sorry I was on vacation last week so I couldn't review it in time. Thanks @uschindler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org