You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "adnanhemani (via GitHub)" <gi...@apache.org> on 2025/04/24 23:14:41 UTC
[PR] Added link to the Spark-Jupyter Notebook Getting Started from the main Getting Started Page [polaris]
adnanhemani opened a new pull request, #1453:
URL: https://github.com/apache/polaris/pull/1453
<!--
Possible security vulnerabilities: STOP here and contact security@apache.org instead!
Please update the title of the PR with a meaningful message - do not leave it "empty" or "generated"
Please update this summary field:
The summary should cover these topics, if applicable:
* the motivation for the change
* a description of the status quo, for example the current behavior
* the desired behavior
* etc
PR checklist:
- Do a self-review of your code before opening a pull request
- Make sure that there's good test coverage for the changes included in this PR
- Run tests locally before pushing a PR (./gradlew check)
- Code should have comments where applicable. Particularly hard-to-understand
areas deserve good in-line documentation.
- Include changes and enhancements to the documentation (in site/content/in-dev/unreleased)
- For Work In Progress Pull Requests, please use the Draft PR feature.
Make sure to add the information BELOW this comment.
Everything in this comment will NOT be added to the PR description.
-->
As explained in the PR title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added link to the Spark-Jupyter Notebook Getting Started from the main Getting Started Page [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on code in PR #1453:
URL: https://github.com/apache/polaris/pull/1453#discussion_r2060668656
##########
site/content/in-dev/unreleased/getting-started/using-polaris.md:
##########
@@ -231,6 +231,8 @@ INSERT INTO quickstart_table VALUES (1, 'some data');
org.apache.iceberg.exceptions.ForbiddenException: Forbidden: Principal 'quickstart_user' with activated PrincipalRoles '[]' and activated grants via '[quickstart_catalog_role, quickstart_user_role]' is not authorized for op LOAD_TABLE_WITH_READ_DELEGATION
```
+Additionally, a Getting Started experience for using Spark with Jupyter Notebooks is documented [here](https://github.com/apache/polaris/blob/main/getting-started/spark/README.md).
Review Comment:
<revived>
Also, this line looks kind of random more generally. This doesn't seem related to the above despite saying Additionally,.
Maybe we can break out a new header called like Beyond the Quickstart or Next Steps or whatever and put this (and other relevant links) there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added link to the Spark-Jupyter Notebook Getting Started from the main Getting Started Page [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on code in PR #1453:
URL: https://github.com/apache/polaris/pull/1453#discussion_r2060724768
##########
site/content/in-dev/unreleased/getting-started/using-polaris.md:
##########
@@ -231,6 +231,8 @@ INSERT INTO quickstart_table VALUES (1, 'some data');
org.apache.iceberg.exceptions.ForbiddenException: Forbidden: Principal 'quickstart_user' with activated PrincipalRoles '[]' and activated grants via '[quickstart_catalog_role, quickstart_user_role]' is not authorized for op LOAD_TABLE_WITH_READ_DELEGATION
```
+Additionally, a Getting Started experience for using Spark with Jupyter Notebooks is documented [here](https://github.com/apache/polaris/blob/main/getting-started/spark/README.md).
Review Comment:
This is under the `Sample Commands` header where it just doesn't really belong.
I think it's fine if `Next Steps` is pretty thin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added link to the Spark-Jupyter Notebook Getting Started from the main Getting Started Page [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on code in PR #1453:
URL: https://github.com/apache/polaris/pull/1453#discussion_r2060664499
##########
site/content/in-dev/unreleased/getting-started/using-polaris.md:
##########
@@ -231,6 +231,8 @@ INSERT INTO quickstart_table VALUES (1, 'some data');
org.apache.iceberg.exceptions.ForbiddenException: Forbidden: Principal 'quickstart_user' with activated PrincipalRoles '[]' and activated grants via '[quickstart_catalog_role, quickstart_user_role]' is not authorized for op LOAD_TABLE_WITH_READ_DELEGATION
```
+Additionally, a Getting Started experience for using Spark with Jupyter Notebooks are documented [here](https://github.com/apache/polaris/blob/main/getting-started/spark/README.md).
Review Comment:
```suggestion
Additionally, a Getting Started experience for using Spark with Jupyter Notebooks is documented [here](https://github.com/apache/polaris/blob/main/getting-started/spark/README.md).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added link to the Spark-Jupyter Notebook Getting Started from the main Getting Started Page [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on code in PR #1453:
URL: https://github.com/apache/polaris/pull/1453#discussion_r2060668162
##########
site/content/in-dev/unreleased/getting-started/using-polaris.md:
##########
@@ -231,6 +231,8 @@ INSERT INTO quickstart_table VALUES (1, 'some data');
org.apache.iceberg.exceptions.ForbiddenException: Forbidden: Principal 'quickstart_user' with activated PrincipalRoles '[]' and activated grants via '[quickstart_catalog_role, quickstart_user_role]' is not authorized for op LOAD_TABLE_WITH_READ_DELEGATION
```
+Additionally, a Getting Started experience for using Spark with Jupyter Notebooks are documented [here](https://github.com/apache/polaris/blob/main/getting-started/spark/README.md).
Review Comment:
Also, this line looks kind of random more generally. This doesn't seem related to the above despite saying `Additionally,`.
Maybe we can break out a new header called like `Beyond the Quickstart` or `Next Steps` or whatever and put this (and other relevant links) there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added link to the Spark-Jupyter Notebook Getting Started from the main Getting Started Page [polaris]
Posted by "adnanhemani (via GitHub)" <gi...@apache.org>.
adnanhemani commented on code in PR #1453:
URL: https://github.com/apache/polaris/pull/1453#discussion_r2060721617
##########
site/content/in-dev/unreleased/getting-started/using-polaris.md:
##########
@@ -231,6 +231,8 @@ INSERT INTO quickstart_table VALUES (1, 'some data');
org.apache.iceberg.exceptions.ForbiddenException: Forbidden: Principal 'quickstart_user' with activated PrincipalRoles '[]' and activated grants via '[quickstart_catalog_role, quickstart_user_role]' is not authorized for op LOAD_TABLE_WITH_READ_DELEGATION
```
+Additionally, a Getting Started experience for using Spark with Jupyter Notebooks is documented [here](https://github.com/apache/polaris/blob/main/getting-started/spark/README.md).
Review Comment:
Context: I was talking to @flyrain offline and he had mentioned that he'd like us to provide a link to the Jupyter Notebook experience from the main Quickstart experience where users can explore further.
The issue with the Jupyter Notebook Getting Started is that it does not have the same amount of feature-richness as this main Getting Started page (no support for Postgres DB or Cloud Blob Storage) - so we're referring to it as an example of how to append to the current Docker Compose file.
I'm not opposed to putting a Next Steps header at the end, but today I think we will only have two links: 1) this and 2) Deploying Polaris in Production. Additionally, @flyrain would like to separate out Spark, Trino, and eventually Flink into their own pages. Do you think it's worth it to create that section at the end for two links? And I'm also slightly worried that if we do separate the engines into their own children pages, then where would this new "Next Steps" page go?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added link to the Spark-Jupyter Notebook Getting Started from the main Getting Started Page [polaris]
Posted by "adnanhemani (via GitHub)" <gi...@apache.org>.
adnanhemani commented on code in PR #1453:
URL: https://github.com/apache/polaris/pull/1453#discussion_r2060887735
##########
site/content/in-dev/unreleased/getting-started/using-polaris.md:
##########
@@ -231,6 +231,8 @@ INSERT INTO quickstart_table VALUES (1, 'some data');
org.apache.iceberg.exceptions.ForbiddenException: Forbidden: Principal 'quickstart_user' with activated PrincipalRoles '[]' and activated grants via '[quickstart_catalog_role, quickstart_user_role]' is not authorized for op LOAD_TABLE_WITH_READ_DELEGATION
```
+Additionally, a Getting Started experience for using Spark with Jupyter Notebooks is documented [here](https://github.com/apache/polaris/blob/main/getting-started/spark/README.md).
Review Comment:
Sounds good, will add the section and revise this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added link to the Spark-Jupyter Notebook Getting Started from the main Getting Started Page [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on code in PR #1453:
URL: https://github.com/apache/polaris/pull/1453#discussion_r2060668162
##########
site/content/in-dev/unreleased/getting-started/using-polaris.md:
##########
@@ -231,6 +231,8 @@ INSERT INTO quickstart_table VALUES (1, 'some data');
org.apache.iceberg.exceptions.ForbiddenException: Forbidden: Principal 'quickstart_user' with activated PrincipalRoles '[]' and activated grants via '[quickstart_catalog_role, quickstart_user_role]' is not authorized for op LOAD_TABLE_WITH_READ_DELEGATION
```
+Additionally, a Getting Started experience for using Spark with Jupyter Notebooks are documented [here](https://github.com/apache/polaris/blob/main/getting-started/spark/README.md).
Review Comment:
Also, this line looks kind of random more generally. This doesn't seem related to the above despite saying `Additionally,`.
Maybe we can break out a new header called like `Beyond the Quickstart` or `Next Steps` or whatever and put this (and other relevant links) there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added link to the Spark-Jupyter Notebook Getting Started from the main Getting Started Page [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard merged PR #1453:
URL: https://github.com/apache/polaris/pull/1453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added link to the Spark-Jupyter Notebook Getting Started from the main Getting Started Page [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on code in PR #1453:
URL: https://github.com/apache/polaris/pull/1453#discussion_r2060668656
##########
site/content/in-dev/unreleased/getting-started/using-polaris.md:
##########
@@ -231,6 +231,8 @@ INSERT INTO quickstart_table VALUES (1, 'some data');
org.apache.iceberg.exceptions.ForbiddenException: Forbidden: Principal 'quickstart_user' with activated PrincipalRoles '[]' and activated grants via '[quickstart_catalog_role, quickstart_user_role]' is not authorized for op LOAD_TABLE_WITH_READ_DELEGATION
```
+Additionally, a Getting Started experience for using Spark with Jupyter Notebooks is documented [here](https://github.com/apache/polaris/blob/main/getting-started/spark/README.md).
Review Comment:
reviving a comment:
Also, this line looks kind of random more generally. This doesn't seem related to the above despite saying Additionally,.
Maybe we can break out a new header called like Beyond the Quickstart or Next Steps or whatever and put this (and other relevant links) there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org