You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/30 15:25:23 UTC
[GitHub] [pulsar] nodece opened a new pull request #13580: [Broker] Improve get topic if the topic exists
nodece opened a new pull request #13580:
URL: https://github.com/apache/pulsar/pull/13580
Signed-off-by: Zixuan Liu <no...@gmail.com>
### Motivation
When call the `pulsarctl seek --time 1h test-reset-cursor-non-existing-topic test-reset-cursor-non-existing-topic-sub`, the Pulsar returns the status code 500, trace the code and found the `PersistentTopicsBase.getTopicReference()` always timeout, so improve this process.
### Modifications
Improves the `BrokerService.getTopicIfExists()`:
When the topic is the persistent topic, check the topic whether in the metadata if it returns true we will get the topic with stuff, otherwise quick return an `Optional.empty()`.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [ ] `no-need-doc`
(Please explain why)
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #13580: [Broker] Improve get topic if the topic exists
Posted by GitBox <gi...@apache.org>.
nodece commented on pull request #13580:
URL: https://github.com/apache/pulsar/pull/13580#issuecomment-1003240011
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #13580: [Broker] Improve get topic if the topic exists
Posted by GitBox <gi...@apache.org>.
nodece commented on pull request #13580:
URL: https://github.com/apache/pulsar/pull/13580#issuecomment-1003245416
close this PR, same with #13573.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #13580: [Broker] Improve get topic if the topic exists
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13580:
URL: https://github.com/apache/pulsar/pull/13580#issuecomment-1003075726
@nodece:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece edited a comment on pull request #13580: [Broker] Improve get topic if the topic exists
Posted by GitBox <gi...@apache.org>.
nodece edited a comment on pull request #13580:
URL: https://github.com/apache/pulsar/pull/13580#issuecomment-1003245416
Close this PR, same with #13573.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece closed pull request #13580: [Broker] Improve get topic if the topic exists
Posted by GitBox <gi...@apache.org>.
nodece closed pull request #13580:
URL: https://github.com/apache/pulsar/pull/13580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #13580: [Broker] Improve get topic if the topic exists
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13580:
URL: https://github.com/apache/pulsar/pull/13580#issuecomment-1003075556
@nodece:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org