You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@wicket.apache.org by nino martinez wael <ni...@gmail.com> on 2019/04/23 08:01:26 UTC
[8.3] Nested Forms within a table?
Hi
When nesting forms, the form tag are changed to an div and it is hard coded:
org/apache/wicket/markup/html/form/Form.java:1597
...
tag.setName("div");
...
If only I could change the tag to be tr, it would produce valid html. Are
it deliberate to be hardcoded?
--
Best regards / Med venlig hilsen
Nino Martinez
Re: [8.3] Nested Forms within a table?
Posted by Sven Meier <sv...@meiers.net>.
Thanks, good to know.
Sven
>
> On 26.04.2019 at 07:33, <nino martinez wael> wrote:
>
>
> until next version comes out, this lump of code seems to be working: Form actionForm=new Form<>("actionForm"){ @Override protected void onComponentTag(ComponentTag tag) { super.onComponentTag(tag); tag.setName("tr"); } } ; On Wed, Apr 24, 2019 at 10:28 AM Sven Meier wrote: > > > Hi Nino, > > > > I've taken the liberty of improving this with WICKET-6658: > > No need to let Form enforce a
>
> -tag when it's changed into a div > afterwards (in case of nested forms). > > > > Have fun > > Sven > > > > > > > > > > > > > > > > On 24.04.2019 at 08:45, wrote: > > > > > > normally I would agree.. But when our designer gives us the html, and > there are tables in it we need to change that stuff.. I do not like the > idea that the web framework forces you to change markup so that it can > work.. One thing are to teach the devs that there are some quirks with the > web framework (thats completely expected). But to have to teach the > designer about a web framework so they can avoid the quirky parts seems > wrong. Its not part of Wickets statement anyhow. > Just Java & HTML > > > Leverage what you know about Java or your favourite HTML editor to > write > Wicket applications. With pure Java code and HTML markup Wicket > is the > go-to web framework for purists. > /rant off :) On Wed, Apr > 2
4, 2019 at 8:24 AM Maxim Solodovnik wrote: > if something "look like a > duck, walk like a duck and sound like a duck" - > it is duck :) > CSS > table are tables, but with no HTML '' tags :) > > On Wed, 24 Apr 2019 > at 13:22, nino martinez wael < > nino.martinez. > wael@gmail.com> wrote: > > > if its CSS its not a table right? > > > > > > > > > On Wed, Apr 24, 2019 at 7:25 AM Maxim > Solodovnik > > wrote: > > > > > Actually you can :) > > > > But you need CSS tables for this :) > > > > > > On Wed, 24 > Apr 2019 at 11:53, nino martinez wael < > > > > nino.martinez.wael@gmail.com> wrote: > > > > > > > I agree > with Maxim, but I do not know the side effects, im going to > try > > > > > it.. As it is now (out of the box), we cannot have nested forms in > > > tables > > > > (for example on form per ) without breaking > html. > > > > > >
> > -Nino > > > > > > > > > On Wed, Apr 24, 2019 at 3:24 AM Maxim Solodovnik < > > solomax666@gmail.com > > > > > > > wrote: > > > > > > > > > > I would say we can create overridable method so users > can specify > > which > > > > tag > > > > > to use > > > > > > it will help with `` > > > > > > > > > > > On Wed, 24 Apr 2019 at 01:39, Sven Meier wrote: > > > > > > > > > > > > Hi, > > > > > > > > > > > > I > think we could improve nested Forms so that only > > > > tags > are > > > > > > turned into a > > > > , but anything else stays as it is. > > > > > > > > > > > > > WDYT? > > > > > > Sven > > > > > > > > > > > > > Am 23.04.19 um 10:01 schrieb nino martinez wael: > > > > > > > > Hi > > > > > > >
> > > > > > > > When nesting forms, the form tag are changed to an div and it > > is > > > hard > > > > > > coded: > > > > > > > > org/apache/wicket/markup/html/form/Form.java:1597 > > > > > > > > ... > > > > > > > > > > > > > > > tag.setName("div"); > > > > > > > > > > > > > > > ... > > > > > > > > > > > > > > If only I could > change the tag to be tr, it would produce valid > > > html. > > > > > > Are > > > > > > > it deliberate to be hardcoded? > > > > > > > > > > > > > > > > > > > > > > > ------------------------- > -------------------------------------------- > > > > > > To > unsubscribe, e-mail: users-unsubscribe@wicket.apache.org > > > > > > > For additional commands, e-mail: users-help@wicket.apache.org > >
> > > > > > > > > > > > > > > > > > > > > > -- > > > > > WBR > > > > > Maxim aka solomax > > > > > > > > > > > > > > > > > > -- > > > > > Best regards / Med venlig hilsen > > > > Nino Martinez > > > > > > > > > > > > > > -- > > > WBR > > > > Maxim aka solomax > > > > > > > > > -- > > > Best regards / Med venlig hilsen > > Nino Martinez > > > > > > -- > WBR > Maxim aka solomax > -- Best regards / Med venlig hilsen > Nino Martinez > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- Best regards / Med venlig hilsen Nino Martinez
>
Re: [8.3] Nested Forms within a table?
Posted by nino martinez wael <ni...@gmail.com>.
until next version comes out, this lump of code seems to be working:
Form<Action> actionForm=new Form<>("actionForm"){
@Override
protected void onComponentTag(ComponentTag tag) {
super.onComponentTag(tag);
tag.setName("tr");
}
}
;
On Wed, Apr 24, 2019 at 10:28 AM Sven Meier <sv...@meiers.net> wrote:
>
>
> Hi Nino,
>
>
>
> I've taken the liberty of improving this with WICKET-6658:
>
> No need to let Form enforce a <form>-tag when it's changed into a div
> afterwards (in case of nested forms).
>
>
>
> Have fun
>
> Sven
>
>
>
>
>
>
>
>
>
>
>
>
> >
> > On 24.04.2019 at 08:45, <nino martinez wael> wrote:
> >
> >
> > normally I would agree.. But when our designer gives us the html, and
> there are tables in it we need to change that stuff.. I do not like the
> idea that the web framework forces you to change markup so that it can
> work.. One thing are to teach the devs that there are some quirks with the
> web framework (thats completely expected). But to have to teach the
> designer about a web framework so they can avoid the quirky parts seems
> wrong. Its not part of Wickets statement anyhow. > Just Java & HTML >
> > Leverage what you know about Java or your favourite HTML editor to
> write > Wicket applications. With pure Java code and HTML markup Wicket
> is the > go-to web framework for purists. > /rant off :) On Wed, Apr
> 24, 2019 at 8:24 AM Maxim Solodovnik wrote: > if something "look like a
> duck, walk like a duck and sound like a duck" - > it is duck :) > CSS
> table are tables, but with no HTML '' tags :) > > On Wed, 24 Apr 2019
> at 13:22, nino martinez wael < > nino.martinez.
> wael@gmail.com> wrote: > > > if its CSS its not a table right? >
> > > > > > > > On Wed, Apr 24, 2019 at 7:25 AM Maxim
> Solodovnik > > wrote: > > > > > Actually you can :) > >
> > But you need CSS tables for this :) > > > > > > On Wed, 24
> Apr 2019 at 11:53, nino martinez wael < > > >
> nino.martinez.wael@gmail.com> wrote: > > > > > > > I agree
> with Maxim, but I do not know the side effects, im going to > try > >
> > > it.. As it is now (out of the box), we cannot have nested forms in
> > > tables > > > > (for example on form per ) without breaking
> html. > > > > > > > > -Nino > > > > > > > >
> On Wed, Apr 24, 2019 at 3:24 AM Maxim Solodovnik < >
> solomax666@gmail.com > > > > > > > wrote: > > > >
> > > > > > I would say we can create overridable method so users
> can specify > > which > > > > tag > > > > > to use >
> > > > > it will help with `` > > > > > > > > >
> > On Wed, 24 Apr 2019 at 01:39, Sven Meier wrote: > > > > > >
> > > > > > Hi, > > > > > > > > > > > > I
> think we could improve nested Forms so that only
> >
> > tags > are > > > > > > turned into a
> >
> > , but anything else stays as it is. > > > > > > > > >
> > > > WDYT? > > > > > > Sven > > > > > > >
> > > > > > Am 23.04.19 um 10:01 schrieb nino martinez wael: >
> > > > > > > Hi > > > > > > > > > > > >
> > > When nesting forms, the form tag are changed to an div and it >
> is > > > hard > > > > > > coded: > > > > > >
> > org/apache/wicket/markup/html/form/Form.java:1597 > > > > >
> > > ... > > > > > > > > > > > > > >
> tag.setName("div"); > > > > > > > > > > > > > >
> ... > > > > > > > > > > > > > > If only I could
> change the tag to be tr, it would produce valid > > > html. > >
> > > > Are > > > > > > > it deliberate to be hardcoded?
> > > > > > > > > > > > > > > > > > > >
> > > -------------------------
> -------------------------------------------- > > > > > > To
> unsubscribe, e-mail: users-unsubscribe@wicket.apache.org > > > >
> > > For additional commands, e-mail: users-help@wicket.apache.org >
> > > > > > > > > > > > > > > > > > > >
> > > -- > > > > > WBR > > > > > Maxim aka solomax
> > > > > > > > > > > > > > > > > > -- >
> > > > Best regards / Med venlig hilsen > > > > Nino Martinez
> > > > > > > > > > > > > > -- > > > WBR >
> > > Maxim aka solomax > > > > > > > > > -- > >
> Best regards / Med venlig hilsen > > Nino Martinez > > > > >
> -- > WBR > Maxim aka solomax > -- Best regards / Med venlig hilsen
> Nino Martinez
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
>
>
>
--
Best regards / Med venlig hilsen
Nino Martinez
Re: [8.3] Nested Forms within a table?
Posted by Sven Meier <sv...@meiers.net>.
Hi Nino,
I've taken the liberty of improving this with WICKET-6658:
No need to let Form enforce a <form>-tag when it's changed into a div afterwards (in case of nested forms).
Have fun
Sven
>
> On 24.04.2019 at 08:45, <nino martinez wael> wrote:
>
>
> normally I would agree.. But when our designer gives us the html, and there are tables in it we need to change that stuff.. I do not like the idea that the web framework forces you to change markup so that it can work.. One thing are to teach the devs that there are some quirks with the web framework (thats completely expected). But to have to teach the designer about a web framework so they can avoid the quirky parts seems wrong. Its not part of Wickets statement anyhow. > Just Java & HTML > > Leverage what you know about Java or your favourite HTML editor to write > Wicket applications. With pure Java code and HTML markup Wicket is the > go-to web framework for purists. > /rant off :) On Wed, Apr 24, 2019 at 8:24 AM Maxim Solodovnik wrote: > if something "look like a duck, walk like a duck and sound like a duck" - > it is duck :) > CSS table are tables, but with no HTML '' tags :) > > On Wed, 24 Apr 2019 at 13:22, nino martinez wael < > nino.martinez.
wael@gmail.com> wrote: > > > if its CSS its not a table right? > > > > > > > > On Wed, Apr 24, 2019 at 7:25 AM Maxim Solodovnik > > wrote: > > > > > Actually you can :) > > > But you need CSS tables for this :) > > > > > > On Wed, 24 Apr 2019 at 11:53, nino martinez wael < > > > nino.martinez.wael@gmail.com> wrote: > > > > > > > I agree with Maxim, but I do not know the side effects, im going to > try > > > > it.. As it is now (out of the box), we cannot have nested forms in > > tables > > > > (for example on form per ) without breaking html. > > > > > > > > -Nino > > > > > > > > On Wed, Apr 24, 2019 at 3:24 AM Maxim Solodovnik < > solomax666@gmail.com > > > > > > > wrote: > > > > > > > > > I would say we can create overridable method so users can specify > > which > > > > tag > > > > > to use >
> > > > it will help with `` > > > > > > > > > > On Wed, 24 Apr 2019 at 01:39, Sven Meier wrote: > > > > > > > > > > > Hi, > > > > > > > > > > > > I think we could improve nested Forms so that only
>
> tags > are > > > > > > turned into a
>
> , but anything else stays as it is. > > > > > > > > > > > > WDYT? > > > > > > Sven > > > > > > > > > > > > Am 23.04.19 um 10:01 schrieb nino martinez wael: > > > > > > > Hi > > > > > > > > > > > > > > When nesting forms, the form tag are changed to an div and it > is > > > hard > > > > > > coded: > > > > > > > org/apache/wicket/markup/html/form/Form.java:1597 > > > > > > > ... > > > > > > > > > > > > > > tag.setName("div"); > > > > > > > > > > > > > > ... > > > > > > > > > > > > > > If only I could change the tag to be tr, it would produce valid > > > html. > > > > > Are > > > > > > > it deliberate to be hardcoded? > > > > > > > > > > > > > > > > > > > > > -------------------------
-------------------------------------------- > > > > > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org > > > > > > For additional commands, e-mail: users-help@wicket.apache.org > > > > > > > > > > > > > > > > > > > > > > -- > > > > > WBR > > > > > Maxim aka solomax > > > > > > > > > > > > > > > > > -- > > > > Best regards / Med venlig hilsen > > > > Nino Martinez > > > > > > > > > > > > > -- > > > WBR > > > Maxim aka solomax > > > > > > > > > -- > > Best regards / Med venlig hilsen > > Nino Martinez > > > > > -- > WBR > Maxim aka solomax > -- Best regards / Med venlig hilsen Nino Martinez
>
>
>
>
>
>
>
>
>
>
>
>
>
Re: [8.3] Nested Forms within a table?
Posted by Maxim Solodovnik <so...@gmail.com>.
I totally agree,
It should be user choice :)
On Wed, 24 Apr 2019 at 13:45, nino martinez wael <
nino.martinez.wael@gmail.com> wrote:
> normally I would agree.. But when our designer gives us the html, and there
> are tables in it we need to change that stuff.. I do not like the idea that
> the web framework forces you to change markup so that it can work.. One
> thing are to teach the devs that there are some quirks with the web
> framework (thats completely expected). But to have to teach the designer
> about a web framework so they can avoid the quirky parts seems wrong.
>
> Its not part of Wickets statement anyhow.
>
> > Just Java & HTML
> >
> > Leverage what you know about Java or your favourite HTML editor to write
> > Wicket applications. With pure Java code and HTML markup Wicket is the
> > go-to web framework for purists.
> >
>
> /rant off :)
>
> On Wed, Apr 24, 2019 at 8:24 AM Maxim Solodovnik <so...@gmail.com>
> wrote:
>
> > if something "look like a duck, walk like a duck and sound like a duck" -
> > it is duck :)
> > CSS table are tables, but with no HTML '<table>' tags :)
> >
> > On Wed, 24 Apr 2019 at 13:22, nino martinez wael <
> > nino.martinez.wael@gmail.com> wrote:
> >
> > > if its CSS its not a table right?
> > >
> > >
> > >
> > > On Wed, Apr 24, 2019 at 7:25 AM Maxim Solodovnik <solomax666@gmail.com
> >
> > > wrote:
> > >
> > > > Actually you can :)
> > > > But you need CSS tables for this :)
> > > >
> > > > On Wed, 24 Apr 2019 at 11:53, nino martinez wael <
> > > > nino.martinez.wael@gmail.com> wrote:
> > > >
> > > > > I agree with Maxim, but I do not know the side effects, im going to
> > try
> > > > > it.. As it is now (out of the box), we cannot have nested forms in
> > > tables
> > > > > (for example on form per <tr>) without breaking html.
> > > > >
> > > > > -Nino
> > > > >
> > > > > On Wed, Apr 24, 2019 at 3:24 AM Maxim Solodovnik <
> > solomax666@gmail.com
> > > >
> > > > > wrote:
> > > > >
> > > > > > I would say we can create overridable method so users can specify
> > > which
> > > > > tag
> > > > > > to use
> > > > > > it will help with `<tr>`
> > > > > >
> > > > > > On Wed, 24 Apr 2019 at 01:39, Sven Meier <sv...@meiers.net>
> wrote:
> > > > > >
> > > > > > > Hi,
> > > > > > >
> > > > > > > I think we could improve nested Forms so that only <form> tags
> > are
> > > > > > > turned into a <div>, but anything else stays as it is.
> > > > > > >
> > > > > > > WDYT?
> > > > > > > Sven
> > > > > > >
> > > > > > > Am 23.04.19 um 10:01 schrieb nino martinez wael:
> > > > > > > > Hi
> > > > > > > >
> > > > > > > > When nesting forms, the form tag are changed to an div and it
> > is
> > > > hard
> > > > > > > coded:
> > > > > > > > org/apache/wicket/markup/html/form/Form.java:1597
> > > > > > > > ...
> > > > > > > >
> > > > > > > > tag.setName("div");
> > > > > > > >
> > > > > > > > ...
> > > > > > > >
> > > > > > > > If only I could change the tag to be tr, it would produce
> valid
> > > > html.
> > > > > > Are
> > > > > > > > it deliberate to be hardcoded?
> > > > > > > >
> > > > > > >
> > > > > > >
> > > ---------------------------------------------------------------------
> > > > > > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > > > > > > For additional commands, e-mail: users-help@wicket.apache.org
> > > > > > >
> > > > > > >
> > > > > >
> > > > > > --
> > > > > > WBR
> > > > > > Maxim aka solomax
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Best regards / Med venlig hilsen
> > > > > Nino Martinez
> > > > >
> > > >
> > > >
> > > > --
> > > > WBR
> > > > Maxim aka solomax
> > > >
> > >
> > >
> > > --
> > > Best regards / Med venlig hilsen
> > > Nino Martinez
> > >
> >
> >
> > --
> > WBR
> > Maxim aka solomax
> >
>
>
> --
> Best regards / Med venlig hilsen
> Nino Martinez
>
--
WBR
Maxim aka solomax
Re: [8.3] Nested Forms within a table?
Posted by nino martinez wael <ni...@gmail.com>.
normally I would agree.. But when our designer gives us the html, and there
are tables in it we need to change that stuff.. I do not like the idea that
the web framework forces you to change markup so that it can work.. One
thing are to teach the devs that there are some quirks with the web
framework (thats completely expected). But to have to teach the designer
about a web framework so they can avoid the quirky parts seems wrong.
Its not part of Wickets statement anyhow.
> Just Java & HTML
>
> Leverage what you know about Java or your favourite HTML editor to write
> Wicket applications. With pure Java code and HTML markup Wicket is the
> go-to web framework for purists.
>
/rant off :)
On Wed, Apr 24, 2019 at 8:24 AM Maxim Solodovnik <so...@gmail.com>
wrote:
> if something "look like a duck, walk like a duck and sound like a duck" -
> it is duck :)
> CSS table are tables, but with no HTML '<table>' tags :)
>
> On Wed, 24 Apr 2019 at 13:22, nino martinez wael <
> nino.martinez.wael@gmail.com> wrote:
>
> > if its CSS its not a table right?
> >
> >
> >
> > On Wed, Apr 24, 2019 at 7:25 AM Maxim Solodovnik <so...@gmail.com>
> > wrote:
> >
> > > Actually you can :)
> > > But you need CSS tables for this :)
> > >
> > > On Wed, 24 Apr 2019 at 11:53, nino martinez wael <
> > > nino.martinez.wael@gmail.com> wrote:
> > >
> > > > I agree with Maxim, but I do not know the side effects, im going to
> try
> > > > it.. As it is now (out of the box), we cannot have nested forms in
> > tables
> > > > (for example on form per <tr>) without breaking html.
> > > >
> > > > -Nino
> > > >
> > > > On Wed, Apr 24, 2019 at 3:24 AM Maxim Solodovnik <
> solomax666@gmail.com
> > >
> > > > wrote:
> > > >
> > > > > I would say we can create overridable method so users can specify
> > which
> > > > tag
> > > > > to use
> > > > > it will help with `<tr>`
> > > > >
> > > > > On Wed, 24 Apr 2019 at 01:39, Sven Meier <sv...@meiers.net> wrote:
> > > > >
> > > > > > Hi,
> > > > > >
> > > > > > I think we could improve nested Forms so that only <form> tags
> are
> > > > > > turned into a <div>, but anything else stays as it is.
> > > > > >
> > > > > > WDYT?
> > > > > > Sven
> > > > > >
> > > > > > Am 23.04.19 um 10:01 schrieb nino martinez wael:
> > > > > > > Hi
> > > > > > >
> > > > > > > When nesting forms, the form tag are changed to an div and it
> is
> > > hard
> > > > > > coded:
> > > > > > > org/apache/wicket/markup/html/form/Form.java:1597
> > > > > > > ...
> > > > > > >
> > > > > > > tag.setName("div");
> > > > > > >
> > > > > > > ...
> > > > > > >
> > > > > > > If only I could change the tag to be tr, it would produce valid
> > > html.
> > > > > Are
> > > > > > > it deliberate to be hardcoded?
> > > > > > >
> > > > > >
> > > > > >
> > ---------------------------------------------------------------------
> > > > > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > > > > > For additional commands, e-mail: users-help@wicket.apache.org
> > > > > >
> > > > > >
> > > > >
> > > > > --
> > > > > WBR
> > > > > Maxim aka solomax
> > > > >
> > > >
> > > >
> > > > --
> > > > Best regards / Med venlig hilsen
> > > > Nino Martinez
> > > >
> > >
> > >
> > > --
> > > WBR
> > > Maxim aka solomax
> > >
> >
> >
> > --
> > Best regards / Med venlig hilsen
> > Nino Martinez
> >
>
>
> --
> WBR
> Maxim aka solomax
>
--
Best regards / Med venlig hilsen
Nino Martinez
Re: [8.3] Nested Forms within a table?
Posted by Maxim Solodovnik <so...@gmail.com>.
if something "look like a duck, walk like a duck and sound like a duck" -
it is duck :)
CSS table are tables, but with no HTML '<table>' tags :)
On Wed, 24 Apr 2019 at 13:22, nino martinez wael <
nino.martinez.wael@gmail.com> wrote:
> if its CSS its not a table right?
>
>
>
> On Wed, Apr 24, 2019 at 7:25 AM Maxim Solodovnik <so...@gmail.com>
> wrote:
>
> > Actually you can :)
> > But you need CSS tables for this :)
> >
> > On Wed, 24 Apr 2019 at 11:53, nino martinez wael <
> > nino.martinez.wael@gmail.com> wrote:
> >
> > > I agree with Maxim, but I do not know the side effects, im going to try
> > > it.. As it is now (out of the box), we cannot have nested forms in
> tables
> > > (for example on form per <tr>) without breaking html.
> > >
> > > -Nino
> > >
> > > On Wed, Apr 24, 2019 at 3:24 AM Maxim Solodovnik <solomax666@gmail.com
> >
> > > wrote:
> > >
> > > > I would say we can create overridable method so users can specify
> which
> > > tag
> > > > to use
> > > > it will help with `<tr>`
> > > >
> > > > On Wed, 24 Apr 2019 at 01:39, Sven Meier <sv...@meiers.net> wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > I think we could improve nested Forms so that only <form> tags are
> > > > > turned into a <div>, but anything else stays as it is.
> > > > >
> > > > > WDYT?
> > > > > Sven
> > > > >
> > > > > Am 23.04.19 um 10:01 schrieb nino martinez wael:
> > > > > > Hi
> > > > > >
> > > > > > When nesting forms, the form tag are changed to an div and it is
> > hard
> > > > > coded:
> > > > > > org/apache/wicket/markup/html/form/Form.java:1597
> > > > > > ...
> > > > > >
> > > > > > tag.setName("div");
> > > > > >
> > > > > > ...
> > > > > >
> > > > > > If only I could change the tag to be tr, it would produce valid
> > html.
> > > > Are
> > > > > > it deliberate to be hardcoded?
> > > > > >
> > > > >
> > > > >
> ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > > > > For additional commands, e-mail: users-help@wicket.apache.org
> > > > >
> > > > >
> > > >
> > > > --
> > > > WBR
> > > > Maxim aka solomax
> > > >
> > >
> > >
> > > --
> > > Best regards / Med venlig hilsen
> > > Nino Martinez
> > >
> >
> >
> > --
> > WBR
> > Maxim aka solomax
> >
>
>
> --
> Best regards / Med venlig hilsen
> Nino Martinez
>
--
WBR
Maxim aka solomax
Re: [8.3] Nested Forms within a table?
Posted by nino martinez wael <ni...@gmail.com>.
if its CSS its not a table right?
On Wed, Apr 24, 2019 at 7:25 AM Maxim Solodovnik <so...@gmail.com>
wrote:
> Actually you can :)
> But you need CSS tables for this :)
>
> On Wed, 24 Apr 2019 at 11:53, nino martinez wael <
> nino.martinez.wael@gmail.com> wrote:
>
> > I agree with Maxim, but I do not know the side effects, im going to try
> > it.. As it is now (out of the box), we cannot have nested forms in tables
> > (for example on form per <tr>) without breaking html.
> >
> > -Nino
> >
> > On Wed, Apr 24, 2019 at 3:24 AM Maxim Solodovnik <so...@gmail.com>
> > wrote:
> >
> > > I would say we can create overridable method so users can specify which
> > tag
> > > to use
> > > it will help with `<tr>`
> > >
> > > On Wed, 24 Apr 2019 at 01:39, Sven Meier <sv...@meiers.net> wrote:
> > >
> > > > Hi,
> > > >
> > > > I think we could improve nested Forms so that only <form> tags are
> > > > turned into a <div>, but anything else stays as it is.
> > > >
> > > > WDYT?
> > > > Sven
> > > >
> > > > Am 23.04.19 um 10:01 schrieb nino martinez wael:
> > > > > Hi
> > > > >
> > > > > When nesting forms, the form tag are changed to an div and it is
> hard
> > > > coded:
> > > > > org/apache/wicket/markup/html/form/Form.java:1597
> > > > > ...
> > > > >
> > > > > tag.setName("div");
> > > > >
> > > > > ...
> > > > >
> > > > > If only I could change the tag to be tr, it would produce valid
> html.
> > > Are
> > > > > it deliberate to be hardcoded?
> > > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > > > For additional commands, e-mail: users-help@wicket.apache.org
> > > >
> > > >
> > >
> > > --
> > > WBR
> > > Maxim aka solomax
> > >
> >
> >
> > --
> > Best regards / Med venlig hilsen
> > Nino Martinez
> >
>
>
> --
> WBR
> Maxim aka solomax
>
--
Best regards / Med venlig hilsen
Nino Martinez
Re: [8.3] Nested Forms within a table?
Posted by Maxim Solodovnik <so...@gmail.com>.
Actually you can :)
But you need CSS tables for this :)
On Wed, 24 Apr 2019 at 11:53, nino martinez wael <
nino.martinez.wael@gmail.com> wrote:
> I agree with Maxim, but I do not know the side effects, im going to try
> it.. As it is now (out of the box), we cannot have nested forms in tables
> (for example on form per <tr>) without breaking html.
>
> -Nino
>
> On Wed, Apr 24, 2019 at 3:24 AM Maxim Solodovnik <so...@gmail.com>
> wrote:
>
> > I would say we can create overridable method so users can specify which
> tag
> > to use
> > it will help with `<tr>`
> >
> > On Wed, 24 Apr 2019 at 01:39, Sven Meier <sv...@meiers.net> wrote:
> >
> > > Hi,
> > >
> > > I think we could improve nested Forms so that only <form> tags are
> > > turned into a <div>, but anything else stays as it is.
> > >
> > > WDYT?
> > > Sven
> > >
> > > Am 23.04.19 um 10:01 schrieb nino martinez wael:
> > > > Hi
> > > >
> > > > When nesting forms, the form tag are changed to an div and it is hard
> > > coded:
> > > > org/apache/wicket/markup/html/form/Form.java:1597
> > > > ...
> > > >
> > > > tag.setName("div");
> > > >
> > > > ...
> > > >
> > > > If only I could change the tag to be tr, it would produce valid html.
> > Are
> > > > it deliberate to be hardcoded?
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > > For additional commands, e-mail: users-help@wicket.apache.org
> > >
> > >
> >
> > --
> > WBR
> > Maxim aka solomax
> >
>
>
> --
> Best regards / Med venlig hilsen
> Nino Martinez
>
--
WBR
Maxim aka solomax
Re: [8.3] Nested Forms within a table?
Posted by nino martinez wael <ni...@gmail.com>.
I agree with Maxim, but I do not know the side effects, im going to try
it.. As it is now (out of the box), we cannot have nested forms in tables
(for example on form per <tr>) without breaking html.
-Nino
On Wed, Apr 24, 2019 at 3:24 AM Maxim Solodovnik <so...@gmail.com>
wrote:
> I would say we can create overridable method so users can specify which tag
> to use
> it will help with `<tr>`
>
> On Wed, 24 Apr 2019 at 01:39, Sven Meier <sv...@meiers.net> wrote:
>
> > Hi,
> >
> > I think we could improve nested Forms so that only <form> tags are
> > turned into a <div>, but anything else stays as it is.
> >
> > WDYT?
> > Sven
> >
> > Am 23.04.19 um 10:01 schrieb nino martinez wael:
> > > Hi
> > >
> > > When nesting forms, the form tag are changed to an div and it is hard
> > coded:
> > > org/apache/wicket/markup/html/form/Form.java:1597
> > > ...
> > >
> > > tag.setName("div");
> > >
> > > ...
> > >
> > > If only I could change the tag to be tr, it would produce valid html.
> Are
> > > it deliberate to be hardcoded?
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > For additional commands, e-mail: users-help@wicket.apache.org
> >
> >
>
> --
> WBR
> Maxim aka solomax
>
--
Best regards / Med venlig hilsen
Nino Martinez
Re: [8.3] Nested Forms within a table?
Posted by Maxim Solodovnik <so...@gmail.com>.
I would say we can create overridable method so users can specify which tag
to use
it will help with `<tr>`
On Wed, 24 Apr 2019 at 01:39, Sven Meier <sv...@meiers.net> wrote:
> Hi,
>
> I think we could improve nested Forms so that only <form> tags are
> turned into a <div>, but anything else stays as it is.
>
> WDYT?
> Sven
>
> Am 23.04.19 um 10:01 schrieb nino martinez wael:
> > Hi
> >
> > When nesting forms, the form tag are changed to an div and it is hard
> coded:
> > org/apache/wicket/markup/html/form/Form.java:1597
> > ...
> >
> > tag.setName("div");
> >
> > ...
> >
> > If only I could change the tag to be tr, it would produce valid html. Are
> > it deliberate to be hardcoded?
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
--
WBR
Maxim aka solomax
Re: [8.3] Nested Forms within a table?
Posted by Sven Meier <sv...@meiers.net>.
Hi,
I think we could improve nested Forms so that only <form> tags are
turned into a <div>, but anything else stays as it is.
WDYT?
Sven
Am 23.04.19 um 10:01 schrieb nino martinez wael:
> Hi
>
> When nesting forms, the form tag are changed to an div and it is hard coded:
> org/apache/wicket/markup/html/form/Form.java:1597
> ...
>
> tag.setName("div");
>
> ...
>
> If only I could change the tag to be tr, it would produce valid html. Are
> it deliberate to be hardcoded?
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org