You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Slair1 <gi...@git.apache.org> on 2016/04/08 07:03:58 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9342: Site to Site VPN PFS not...
GitHub user Slair1 opened a pull request:
https://github.com/apache/cloudstack/pull/1478
CLOUDSTACK-9342: Site to Site VPN PFS not being set correctly
Bug in code set PFS to the same value (yes/no) as DPD.
file.addeq(" pfs=%s" % CsHelper.bool_to_yn(obj['dpd']))
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Slair1/cloudstack patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1478.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1478
----
commit f0dfdef139b415ac4396417b452344cf6b06882f
Author: Slair1 <sl...@ippathways.com>
Date: 2016-04-08T04:37:33Z
PFS not being set correctly
Bug in code set PFS to the same value (yes/no) as DPD.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9342: Site to Site VPN PFS not...
Posted by Slair1 <gi...@git.apache.org>.
Github user Slair1 commented on the pull request:
https://github.com/apache/cloudstack/pull/1478#issuecomment-207526795
ah, thanks @kiwiflyer . How do i change this to 4.7.x?
Also i check PR #872 and the PFS code looks good there, it is totally re-written.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9342: Site to Site VPN PFS not...
Posted by Slair1 <gi...@git.apache.org>.
Github user Slair1 commented on the pull request:
https://github.com/apache/cloudstack/pull/1478#issuecomment-207530559
@kiwiflyer thanks, how do i delete this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9342: Site to Site VPN PFS not...
Posted by Slair1 <gi...@git.apache.org>.
Github user Slair1 commented on the pull request:
https://github.com/apache/cloudstack/pull/1478#issuecomment-207543327
Create new PR #1480 in 4.7 branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9342: Site to Site VPN PFS not...
Posted by kiwiflyer <gi...@git.apache.org>.
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1478#issuecomment-207531252
@Slair1 You should have a close button below the comments section.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9342: Site to Site VPN PFS not...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1478#issuecomment-207533662
@Slair1 If you create a new PR or if a different PR solves the problem you ran into, can you please post the PR number that replaces this one? This helps me maintain my ability to track active PRs. Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9342: Site to Site VPN PFS not...
Posted by Slair1 <gi...@git.apache.org>.
Github user Slair1 closed the pull request at:
https://github.com/apache/cloudstack/pull/1478
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9342: Site to Site VPN PFS not...
Posted by kiwiflyer <gi...@git.apache.org>.
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1478#issuecomment-207524802
PR https://github.com/apache/cloudstack/pull/872 is going to replacing openswan with strongswan.
I believe PFS is depreciated in strongwan, so it might make sense to just remove PFS once 872 is committed.
It might be worth while looking at addressing this just in 4.7.x and 4.8.x.
Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9342: Site to Site VPN PFS not...
Posted by Slair1 <gi...@git.apache.org>.
Github user Slair1 commented on the pull request:
https://github.com/apache/cloudstack/pull/1478#issuecomment-207531359
@kiwiflyer , wow i feel stupid now :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9342: Site to Site VPN PFS not...
Posted by kiwiflyer <gi...@git.apache.org>.
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1478#issuecomment-207528583
@Slair1 You can checkout the 4.7 branch and then create a new branch. Apply the patch and then push that new local branch back up to your github ACS fork. Then create a pull request against ACS 4.7.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---