You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2024/12/09 20:49:13 UTC

[PR] RANGER-5066. Improve CI workflow [ranger]

adoroszlai opened a new pull request, #438:
URL: https://github.com/apache/ranger/pull/438

   ## What changes were proposed in this pull request?
   
   I would like to propose some improvements for the CI workflow:
   
   - Use `actions/cache` instead of `setup-java`'s simple cache option.  This allows restoring "similar" caches, not just exact cache hits.
   - Run `build-11` only after `build-8`.  If Java 8 build fails, no need to spend time trying with Java 11.  Run `build-11` and `docker-build` (test) concurrently.
   - Run the workflow on `push` for any branch.  This allows contributors to run the workflow in their fork, to get CI feedback before opening PR.  (Without pushing to `master` in their fork.)
   
   https://issues.apache.org/jira/browse/RANGER-5066
   
   ## How was this patch tested?
   
   CI:
   https://github.com/adoroszlai/ranger/actions/runs/12241913402


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] RANGER-5066. Improve CI workflow [ranger]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #438:
URL: https://github.com/apache/ranger/pull/438#issuecomment-2532257449

   Thanks @kumaab, @mneethiraj for the review.
   
   With this change in place, please encourage committers and contributors to follow @kumaab's example:
   - enable `CI` workflow in their fork ([example](https://github.com/kumaab/ranger/actions/workflows/maven.yml))
   - use branch in fork for dev work ([example](https://github.com/kumaab/ranger/commits/ranger-5019/) instead of branch in `apache/ranger`
   - get feedback for changes in fork ([example](https://github.com/kumaab/ranger/actions/runs/12248930041))
   - open PR after successful CI in fork
   
   This will help reduce queuing of workflow runs in `apache/ranger`, leading to faster PR turnaround times.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] RANGER-5066. Improve CI workflow [ranger]

Posted by "kumaab (via GitHub)" <gi...@apache.org>.
kumaab merged PR #438:
URL: https://github.com/apache/ranger/pull/438


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] RANGER-5066. Improve CI workflow [ranger]

Posted by "kumaab (via GitHub)" <gi...@apache.org>.
kumaab commented on PR #438:
URL: https://github.com/apache/ranger/pull/438#issuecomment-2529637856

   LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] RANGER-5066. Improve CI workflow [ranger]

Posted by "kumaab (via GitHub)" <gi...@apache.org>.
kumaab commented on PR #438:
URL: https://github.com/apache/ranger/pull/438#issuecomment-2529647637

   @mneethiraj
   It seems the changes proposed here will be helpful to resolve this as well: [INFRA-26354](https://issues.apache.org/jira/browse/INFRA-26354)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org