You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/08/19 15:33:01 UTC
[GitHub] [tvm] tkonolige opened a new pull request #8796: [FIX] Remove leftover instances of USE_GRAPH_EXECUTOR_DEBUG
tkonolige opened a new pull request #8796:
URL: https://github.com/apache/tvm/pull/8796
single flag, USE_PROFILER. This PR cleans up the last few remaining uses of USE_GRAPH_EXECUTOR_DEBUG.
@junrushao1994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jroesch commented on pull request #8796: [FIX] Remove leftover instances of USE_GRAPH_EXECUTOR_DEBUG
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #8796:
URL: https://github.com/apache/tvm/pull/8796#issuecomment-904301596
Going to land this @comaniac feel free to request follow up changes if I missed something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on a change in pull request #8796: [FIX] Remove leftover instances of USE_GRAPH_EXECUTOR_DEBUG
Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #8796:
URL: https://github.com/apache/tvm/pull/8796#discussion_r694222568
##########
File path: CMakeLists.txt
##########
@@ -343,8 +343,8 @@ endif(USE_GRAPH_RUNTIME AND NOT DEFINED USE_GRAPH_EXECUTOR)
# NOTE(areusch): USE_GRAPH_RUNTIME_DEBUG will be deleted in a future release
if(USE_GRAPH_RUNTIME_DEBUG AND NOT DEFINED USE_GRAPH_EXECUTOR_DEBUG)
Review comment:
```suggestion
if(USE_GRAPH_RUNTIME_DEBUG AND NOT DEFINED USE_PROFILER)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jroesch merged pull request #8796: [FIX] Remove leftover instances of USE_GRAPH_EXECUTOR_DEBUG
Posted by GitBox <gi...@apache.org>.
jroesch merged pull request #8796:
URL: https://github.com/apache/tvm/pull/8796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jroesch edited a comment on pull request #8796: [FIX] Remove leftover instances of USE_GRAPH_EXECUTOR_DEBUG
Posted by GitBox <gi...@apache.org>.
jroesch edited a comment on pull request #8796:
URL: https://github.com/apache/tvm/pull/8796#issuecomment-904301596
Going to land this @comaniac to empty the PR queue feel free to request follow up changes if I missed something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org