You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/24 19:44:00 UTC
[jira] [Commented] (METRON-1131) The Stellar REPL rejects valid
hostnames for zookeeper in its CLI options
[ https://issues.apache.org/jira/browse/METRON-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140583#comment-16140583 ]
ASF GitHub Bot commented on METRON-1131:
----------------------------------------
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/715
METRON-1131: The Stellar REPL rejects valid hostnames for zookeeper in its CLI options
## Contributor Comments
Currently, the REPL defines a valid zookeeper hostname is one which matches a regex rather than defining it as a hostname which is reachable by the machine. Combining this with the fact that the regex to validate the hostname is denying valid hostnames:
```
@Test
public void testBadPattern() throws Exception
{
Pattern validHostNamePattern = Pattern.compile(
"^(([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\\\\-]*[a-zA-Z0-9])\\\\.)"
+ "*([A-Za-z0-9]|[A-Za-z0-9][A-Za-z0-9\\\\-]*[A-Za-z0-9])$");
Assert.assertFalse(validHostNamePattern.matcher("gzcf0.fold.blarg.com").matches());
Assert.assertTrue(validHostNamePattern.matcher("host1").matches());
}
```
I reimplemented the hostname validator using InetAddress, which will try to resolve the hostname rather than just use a regex.
Testing this on fulldev:
* Run $METRON_HOME/bin/stellar -z node:2181 and ensure REPL starts
* Run $METRON_HOME/bin/stellar -z blarginghammetronzoinkburger:2181 and ensure REPL does not start with `Zookeeper Option blarginghammetronzoinkburger is not a valid host name or ip address blarginghammetronzoinkburger:2181`
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron repl_hostname_validator
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/715.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #715
----
commit 940eb51ce08ca171e774f7db2a5744bd5bd2be54
Author: cstella <ce...@gmail.com>
Date: 2017-08-24T19:39:50Z
METRON-1131: The Stellar REPL rejects valid hostnames for zookeeper in its CLI options
----
> The Stellar REPL rejects valid hostnames for zookeeper in its CLI options
> -------------------------------------------------------------------------
>
> Key: METRON-1131
> URL: https://issues.apache.org/jira/browse/METRON-1131
> Project: Metron
> Issue Type: Bug
> Reporter: Casey Stella
>
> Currently, the REPL defines a valid zookeeper hostname is one which matches a regex rather than defining it as a hostname which is reachable by the machine. Combining this with the fact that the regex to validate the hostname is denying valid hostnames:
> {code}
> @Test
> public void testBadPattern() throws Exception
> {
> Pattern validHostNamePattern = Pattern.compile(
> "^(([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\\\\-]*[a-zA-Z0-9])\\\\.)"
> + "*([A-Za-z0-9]|[A-Za-z0-9][A-Za-z0-9\\\\-]*[A-Za-z0-9])$");
> Assert.assertFalse(validHostNamePattern.matcher("gzcf0.fold.blarg.com").matches());
> Assert.assertTrue(validHostNamePattern.matcher("host1").matches());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)