You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by erha19 <gi...@git.apache.org> on 2017/06/22 04:12:28 UTC

[GitHub] incubator-weex pull request #464: + [html5] add webSocket api for web platfo...

GitHub user erha19 opened a pull request:

    https://github.com/apache/incubator-weex/pull/464

    + [html5] add webSocket api for web platform

    - add webSocket api for web platform.
    - add example for webSocket showcase.
    - change weex modules install config.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/erha19/incubator-weex 0.14-dev

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/464.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #464
    
----
commit f92dce15c5429f3eb8d45c0601539cecc00c7e47
Author: erha19 <75...@qq.com>
Date:   2017-06-22T03:57:45Z

    + [html5] add webSocket api for web platform

commit d8a1708f1d0806c7fc21819f3031ff82cf007bb5
Author: erha19 <75...@qq.com>
Date:   2017-06-22T03:58:32Z

    + [html5] add example for webSocket

commit 84b07513607a8bd933e7ef297ca90f843df26b63
Author: erha19 <75...@qq.com>
Date:   2017-06-22T04:05:25Z

    Merge branch '0.14-dev' of https://github.com/apache/incubator-weex into 0.14-dev

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #464: + [html5] add webSocket api for web platform

Posted by erha19 <gi...@git.apache.org>.
Github user erha19 commented on the issue:

    https://github.com/apache/incubator-weex/pull/464
  
    @sospartan It is old feature for web platform.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #464: + [html5] add webSocket api for web platfo...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/464


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #464: + [html5] add webSocket api for web platform

Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on the issue:

    https://github.com/apache/incubator-weex/pull/464
  
    Where is the JIRA issue about this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #464: + [html5] add webSocket api for web platform

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/464
  
    
    <!--
      1 failure:  This PR modify SD...
      3 warning:  No Changelog chan..., These new JS file..., This PR should up...
      1 messages
      
    -->
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Fails</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:no_entry_sign:</td>
          <td>This PR modify SDK code. Please add/modify corresponding testcases. If it is ok, please comment about it. Or put '@notdanger' in you commit message.</td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>These new JS files do not have Flow enabled: html5/render/vue/modules/websocket/index.js, html5/render/vue/modules/websocket/websocket.js</td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>This PR should update related documents as well. </td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>According to the blame info, we recommended @MrRaindrop , @Hanks10100 to be the reviewers.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---