[GitHub] [tvm] gromero commented on a diff in pull request #13377: [microTVM][Zephyr] Add 'serial_number' option

[GitBox <gi...@apache.org>]

gromero commented on code in PR #13377:
URL: https://github.com/apache/tvm/pull/13377#discussion_r1030745182


##########
apps/microtvm/zephyr/template_project/microtvm_api_server.py:
##########
@@ -310,18 +314,11 @@ def _get_nrf_device_args(options):
         help=("If given, port number to use when running the local gdbserver."),
     ),
     server.ProjectOption(
-        "nrfjprog_snr",
-        optional=["open_transport"],
-        type="int",
-        default=None,
-        help=("When used with nRF targets, serial # of the attached board to use, from nrfjprog."),
-    ),
-    server.ProjectOption(
-        "openocd_serial",
+        "serial_number",

Review Comment:
   `serial_number` is also used by the `flash` method and must be advertised accordingly, so please add the method `flash` to the `optional` list below.



##########
tests/micro/zephyr/README.md:
##########
@@ -40,3 +40,9 @@ To see the list of supported values for `--board`, run:
 ```
 $ pytest test_zephyr.py --help
 ```
+
+If you like to test with a real hardware, you have the option to pass the serial number
+for your development board.
+```
+$ pytes test_zephyr.py --board=nrf5340dk_nrf5340_cpuapp --serial="0672FF5"

Review Comment:
   Typo: `pytest`



##########
apps/microtvm/zephyr/template_project/microtvm_api_server.py:
##########
@@ -97,6 +97,10 @@ def check_call(cmd_args, *args, **kwargs):
     + [(k, False) for k in ("0", "OFF", "NO", "FALSE", "N", "IGNORE", "NOTFOUND", "")]
 )
 
+CMSIS_PATH_ERROR = (
+    "cmsis_path is not defined! Please pass it as" "an option or set the `CMSIS_PATH` env variable."

Review Comment:
   Please, concat the two strings into a single one or wrap the line adding a space at the end of the first string, otherwise in the current state it will print this way:
   
   ```
   E               assert cmsis_path, CMSIS_PATH_ERROR
   E           AssertionError: cmsis_path is not defined! Please pass it asan option or set the `CMSIS_PATH` env variable.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org