You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/01/09 16:16:41 UTC
Review Request: SQOOP-822 Sqoop2: Git repository revision is not fetched
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8907/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
Script saveVersion.sh was checking existence of local .git directory when it is running from common/ directory. However git have only one top level directory unlike svn, so I've fixed the path to correct one.
This addresses bug SQOOP-822.
https://issues.apache.org/jira/browse/SQOOP-822
Diffs
-----
common/src/saveVersion.sh 4310339aef7beebb12f9947652c26917dede4d4d
Diff: https://reviews.apache.org/r/8907/diff/
Testing
-------
Tested on real cluster:
server version:
Sqoop 2.0.0-SNAPSHOT revision 2016dedce6658ebdf6468593053ed9c7ec8134db
Compiled by jarcec on Wed Jan 9 07:04:58 PST 2013
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-822 Sqoop2: Git repository revision is not fetched
Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8907/#review15207
-----------------------------------------------------------
Ship it!
I verified that revision is no longer unknown with the patch:
{"revision":"Unknown","protocols":["1"],"date":"Wed Jan 9 11:40:14 PST 2013","user":"cheolsoo","url":"file:\/\/\/home\/cheolsoo\/workspace\/sqoop\/common","version":"2.0.0-SNAPSHOT"}
=>
{"revision":"2016dedce6658ebdf6468593053ed9c7ec8134db","protocols":["1"],"date":"Wed Jan 9 11:50:28 PST 2013","user":"cheolsoo","url":"git:\/\/localhost.localdomain\/home\/cheolsoo\/workspace\/sqoop\/common","version":"2.0.0-SNAPSHOT"}
- Cheolsoo Park
On Jan. 9, 2013, 3:16 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8907/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2013, 3:16 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Script saveVersion.sh was checking existence of local .git directory when it is running from common/ directory. However git have only one top level directory unlike svn, so I've fixed the path to correct one.
>
>
> This addresses bug SQOOP-822.
> https://issues.apache.org/jira/browse/SQOOP-822
>
>
> Diffs
> -----
>
> common/src/saveVersion.sh 4310339aef7beebb12f9947652c26917dede4d4d
>
> Diff: https://reviews.apache.org/r/8907/diff/
>
>
> Testing
> -------
>
> Tested on real cluster:
>
> server version:
> Sqoop 2.0.0-SNAPSHOT revision 2016dedce6658ebdf6468593053ed9c7ec8134db
> Compiled by jarcec on Wed Jan 9 07:04:58 PST 2013
>
>
> Thanks,
>
> Jarek Cecho
>
>