[GitHub] flink pull request #1954: [FLINK-3190] failure rate restart strategy

[fijolekProjects <gi...@git.apache.org>]

Github user fijolekProjects commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1954#discussion_r69490778
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/FixedDelayRestartStrategy.java ---
    @@ -108,22 +87,7 @@ public static FixedDelayRestartStrategyFactory createFactory(Configuration confi
     			timeoutString
     		);
     
    -		long delay;
    -
    -		try {
    -			delay = Duration.apply(delayString).toMillis();
    -		} catch (NumberFormatException nfe) {
    -			if (delayString.equals(timeoutString)) {
    -				throw new Exception("Invalid config value for " +
    -					ConfigConstants.AKKA_WATCH_HEARTBEAT_PAUSE + ": " + timeoutString +
    -					". Value must be a valid duration (such as '10 s' or '1 min')");
    -			} else {
    -				throw new Exception("Invalid config value for " +
    -					ConfigConstants.EXECUTION_RETRY_DELAY_KEY + ": " + delayString +
    -					". Value must be a valid duration (such as '100 milli' or '10 s')");
    -			}
    -		}
    -
    --- End diff --
    
    it looks like copypaste from RestartStrategyFactory and it doesn't make sense to me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---