You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/16 08:43:46 UTC
[GitHub] [spark] dongjoon-hyun edited a comment on issue #27888:
[SPARK-31116][SQL] Fix nested schema case-sensitivity in ParquetRowConverter
dongjoon-hyun edited a comment on issue #27888: [SPARK-31116][SQL] Fix nested schema case-sensitivity in ParquetRowConverter
URL: https://github.com/apache/spark/pull/27888#issuecomment-599412284
BTW, @kimtkyeom . While reviewing this PR again throughly, the original failure report on ORC looks wrong.
- https://github.com/apache/spark/pull/27888#discussion_r391521516
You wrote like the following, but it was `JSON` (`Relation[StructColumn#329] json`). Could you confirm your failure report again?
```
ORC passed case insensitive test cases, but it failed case sensitive manner.
[info] - SPARK-31116: Select nested columns correctly in case sensitive manner *** FAILED *** (871 milliseconds)
[info] Results do not match for query:
[info] Timezone: sun.util.calendar.ZoneInfo[id="America/Los_Angeles",offset=-28800000,dstSavings=3600000,useDaylight=true,transitions=185,lastRule=java.util.SimpleTimeZone[id=America/Los_Angeles,offset=-28800000,dstSavings=3600000,useDaylight=true,startYear=0,startMode=3,startMonth=2,startDay=8,startDayOfWeek=1,startTime=7200000,startTimeMode=0,endMode=3,endMonth=10,endDay=1,endDayOfWeek=1,endTime=7200000,endTimeMode=0]]
[info] Timezone Env:
[info]
[info] == Parsed Logical Plan ==
[info] Relation[StructColumn#329] json
[info]
[info] == Analyzed Logical Plan ==
[info] StructColumn: struct<LowerCase:bigint,camelcase:bigint>
[info] Relation[StructColumn#329] json
[info]
[info] == Optimized Logical Plan ==
[info] Relation[StructColumn#329] json
[info]
[info] == Physical Plan ==
[info] FileScan json [StructColumn#329] Batched: false, DataFilters: [], Format: JSON, Location: InMemoryFileIndex[file:/Users/kimtkyeom/Dev/spark_devel/target/tmp/spark-612baf76-a9d0-41e5-89f4-..., PartitionFilters: [], PushedFilters: [], ReadSchema: struct<StructColumn:struct<LowerCase:bigint,camelcase:bigint>>
[info]
[info] == Results ==
[info]
[info] == Results ==
[info] !== Correct Answer - 1 == == Spark Answer - 1 ==
[info] !struct<> struct<StructColumn:struct<LowerCase:bigint,camelcase:bigint>>
[info] ![null] [[null,null]] (QueryTest.scala:248)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org