You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "kaka11chen (via GitHub)" <gi...@apache.org> on 2026/04/11 15:18:19 UTC
[PR] [fix](be) Add missing SCOPED_ATTACH_TASK in download and move_dir callbacks [doris]
kaka11chen opened a new pull request, #62401:
URL: https://github.com/apache/doris/pull/62401
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
download_callback() and move_dir_callback() in task_worker_pool.cpp use
SnapshotLoader/CloudSnapshotLoader to perform HDFS downloads and file
moves, but do not attach the MemTracker to the thread context via
SCOPED_ATTACH_TASK. This causes memory orphan check failures when these
callbacks allocate memory through HDFS operations, as the allocations
are not tracked by any MemTrackerLimiter.
The parallel upload_callback() already has SCOPED_ATTACH_TASK correctly.
### Release note
Fix: Add SCOPED_ATTACH_TASK(loader->resource_ctx()) in all four missing
locations:
- download_callback(StorageEngine&): remote_http_download branch
- download_callback(StorageEngine&): broker download branch
- download_callback(CloudStorageEngine&): cloud download branch
- move_dir_callback(StorageEngine&): local move branch
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Add missing SCOPED_ATTACH_TASK in download and move_dir callbacks [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62401:
URL: https://github.com/apache/doris/pull/62401#issuecomment-4233472914
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Add missing SCOPED_ATTACH_TASK in download and move_dir callbacks [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #62401:
URL: https://github.com/apache/doris/pull/62401#issuecomment-4229657068
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Add missing SCOPED_ATTACH_TASK in download and move_dir callbacks [doris]
Posted by "kaka11chen (via GitHub)" <gi...@apache.org>.
kaka11chen commented on PR #62401:
URL: https://github.com/apache/doris/pull/62401#issuecomment-4229657065
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Add missing SCOPED_ATTACH_TASK in download and move_dir callbacks [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62401:
URL: https://github.com/apache/doris/pull/62401#issuecomment-4229888479
# BE Regression && UT Coverage Report
Increment line coverage `0.00% (0/4)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62401_0c7fafa40e698772eacf828e2cb5ad2362ee0ca2_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62401_0c7fafa40e698772eacf828e2cb5ad2362ee0ca2_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.31% (26193/36731) |
| Line Coverage | 54.24% (277050/510806) |
| Region Coverage | 51.53% (230092/446478) |
| Branch Coverage | 52.92% (99464/187957) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Add missing SCOPED_ATTACH_TASK in download and move_dir callbacks [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62401:
URL: https://github.com/apache/doris/pull/62401#issuecomment-4233472803
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.1: [fix](be) Add missing SCOPED_ATTACH_TASK in download and move_dir callbacks [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #62401:
URL: https://github.com/apache/doris/pull/62401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org