You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2024/01/24 03:11:32 UTC

[Impala-ASF-CR] IMPALA-12125: Support for dumping symbols from RPMs without separate symbols

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20944


Change subject: IMPALA-12125: Support for dumping symbols from RPMs without separate symbols
......................................................................

IMPALA-12125: Support for dumping symbols from RPMs without separate symbols

Some RPMs contain binaries with debug symbols with no separate
debuginfo package needed. bin/dump_breakpad_symbols.py does not
allow this combination, as it expects a corresponding symbol
package. This adds a --no_symbol_pkg option to dump_breakpad_symbols.py
to turn off the requirement that --pkg be combined with --symbol_pkg.

Testing:
 - Tested with an RPM package with an unstripped impalad binary
 - Tested with the usual RPM + debuginfo RPM combination

Change-Id: I9589b0ed7855fe49c6989ec3dcc51a9e9c4f476b
---
M bin/dump_breakpad_symbols.py
1 file changed, 22 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/20944/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9589b0ed7855fe49c6989ec3dcc51a9e9c4f476b
Gerrit-Change-Number: 20944
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-12125: Support for dumping symbols from RPMs without separate symbols

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20944 )

Change subject: IMPALA-12125: Support for dumping symbols from RPMs without separate symbols
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10202/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/20944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9589b0ed7855fe49c6989ec3dcc51a9e9c4f476b
Gerrit-Change-Number: 20944
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 29 Jan 2024 02:02:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12125: Support for dumping symbols from RPMs without separate symbols

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20944 )

Change subject: IMPALA-12125: Support for dumping symbols from RPMs without separate symbols
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9589b0ed7855fe49c6989ec3dcc51a9e9c4f476b
Gerrit-Change-Number: 20944
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jan 2024 18:33:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12125: Support for dumping symbols from RPMs without separate symbols

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20944 )

Change subject: IMPALA-12125: Support for dumping symbols from RPMs without separate symbols
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10202/


-- 
To view, visit http://gerrit.cloudera.org:8080/20944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9589b0ed7855fe49c6989ec3dcc51a9e9c4f476b
Gerrit-Change-Number: 20944
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 29 Jan 2024 06:40:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12125: Support for dumping symbols from RPMs without separate symbols

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20944 )

Change subject: IMPALA-12125: Support for dumping symbols from RPMs without separate symbols
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/15047/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9589b0ed7855fe49c6989ec3dcc51a9e9c4f476b
Gerrit-Change-Number: 20944
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jan 2024 03:39:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12125: Support for dumping symbols from RPMs without separate symbols

Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20944 )

Change subject: IMPALA-12125: Support for dumping symbols from RPMs without separate symbols
......................................................................


Patch Set 2: Verified+1

Irrelevant failure at TestEventProcessingCustomConfigs.test_skipping_older_events


-- 
To view, visit http://gerrit.cloudera.org:8080/20944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9589b0ed7855fe49c6989ec3dcc51a9e9c4f476b
Gerrit-Change-Number: 20944
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 29 Jan 2024 17:32:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12125: Support for dumping symbols from RPMs without separate symbols

Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20944 )

Change subject: IMPALA-12125: Support for dumping symbols from RPMs without separate symbols
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9589b0ed7855fe49c6989ec3dcc51a9e9c4f476b
Gerrit-Change-Number: 20944
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 29 Jan 2024 02:00:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12125: Support for dumping symbols from RPMs without separate symbols

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20944 )

Change subject: IMPALA-12125: Support for dumping symbols from RPMs without separate symbols
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9589b0ed7855fe49c6989ec3dcc51a9e9c4f476b
Gerrit-Change-Number: 20944
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 29 Jan 2024 02:02:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12125: Support for dumping symbols from RPMs without separate symbols

Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20944 )

Change subject: IMPALA-12125: Support for dumping symbols from RPMs without separate symbols
......................................................................

IMPALA-12125: Support for dumping symbols from RPMs without separate symbols

Some RPMs contain binaries with debug symbols with no separate
debuginfo package needed. bin/dump_breakpad_symbols.py does not
allow this combination, as it expects a corresponding symbol
package. This adds a --no_symbol_pkg option to dump_breakpad_symbols.py
to turn off the requirement that --pkg be combined with --symbol_pkg.

Testing:
 - Tested with an RPM package with an unstripped impalad binary
 - Tested with the usual RPM + debuginfo RPM combination

Change-Id: I9589b0ed7855fe49c6989ec3dcc51a9e9c4f476b
Reviewed-on: http://gerrit.cloudera.org:8080/20944
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Yida Wu <wy...@gmail.com>
---
M bin/dump_breakpad_symbols.py
1 file changed, 22 insertions(+), 13 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved
  Yida Wu: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/20944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9589b0ed7855fe49c6989ec3dcc51a9e9c4f476b
Gerrit-Change-Number: 20944
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>

[Impala-ASF-CR] IMPALA-12125: Support for dumping symbols from RPMs without separate symbols

Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has removed a vote on this change.

Change subject: IMPALA-12125: Support for dumping symbols from RPMs without separate symbols
......................................................................


Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/20944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I9589b0ed7855fe49c6989ec3dcc51a9e9c4f476b
Gerrit-Change-Number: 20944
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>