You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/05/21 09:38:57 UTC
[GitHub] [rocketmq] aaron-ai opened a new pull request, #4358: [ISSUE #3949] Add support for gRPC client
aaron-ai opened a new pull request, #4358:
URL: https://github.com/apache/rocketmq/pull/4358
## What is the purpose of the change
As we mentioned in #3949 , provides a thin client based on gRPC.
## Brief changelog
* Add new module `thinclient`;
* Provides an implementation of `apis` module based on gRPC;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #4358: [ISSUE #3949] Add support for gRPC client
Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #4358:
URL: https://github.com/apache/rocketmq/pull/4358#issuecomment-1135367661
[](https://coveralls.io/builds/49388689)
Coverage increased (+0.5%) to 47.715% when pulling **b9a241c7730765a1249bcca0eb41fd2828586126 on aaron-ai:pr** into **c6fbd749746da23620fd44a60d40b60d008427e4 on apache:5.0.0-beta**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #4358: [ISSUE #3949] Add support for gRPC client
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #4358:
URL: https://github.com/apache/rocketmq/pull/4358#issuecomment-1135367280
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4358?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4358](https://codecov.io/gh/apache/rocketmq/pull/4358?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b9a241c) into [5.0.0-beta](https://codecov.io/gh/apache/rocketmq/commit/d8c9bd38cb69039cee92eb37622130ac5970ef14?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d8c9bd3) will **increase** coverage by `0.48%`.
> The diff coverage is `53.53%`.
```diff
@@ Coverage Diff @@
## 5.0.0-beta #4358 +/- ##
================================================
+ Coverage 43.04% 43.53% +0.48%
- Complexity 6018 6456 +438
================================================
Files 796 859 +63
Lines 56948 60153 +3205
Branches 7797 8051 +254
================================================
+ Hits 24514 26186 +1672
- Misses 29225 30610 +1385
- Partials 3209 3357 +148
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4358?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...hinclient/exception/ResourceNotFoundException.java](https://codecov.io/gh/apache/rocketmq/pull/4358/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGhpbmNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGhpbmNsaWVudC9leGNlcHRpb24vUmVzb3VyY2VOb3RGb3VuZEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...rocketmq/thinclient/impl/consumer/ConsumeTask.java](https://codecov.io/gh/apache/rocketmq/pull/4358/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGhpbmNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGhpbmNsaWVudC9pbXBsL2NvbnN1bWVyL0NvbnN1bWVUYXNrLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...q/thinclient/impl/consumer/FifoConsumeService.java](https://codecov.io/gh/apache/rocketmq/pull/4358/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGhpbmNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGhpbmNsaWVudC9pbXBsL2NvbnN1bWVyL0ZpZm9Db25zdW1lU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...lient/impl/consumer/SimpleConsumerBuilderImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4358/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGhpbmNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGhpbmNsaWVudC9pbXBsL2NvbnN1bWVyL1NpbXBsZUNvbnN1bWVyQnVpbGRlckltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...etmq/thinclient/impl/producer/TransactionImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4358/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGhpbmNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGhpbmNsaWVudC9pbXBsL3Byb2R1Y2VyL1RyYW5zYWN0aW9uSW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...mq/thinclient/retry/BackOffRetryPolicyBuilder.java](https://codecov.io/gh/apache/rocketmq/pull/4358/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGhpbmNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGhpbmNsaWVudC9yZXRyeS9CYWNrT2ZmUmV0cnlQb2xpY3lCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../rocketmq/thinclient/retry/BackoffRetryPolicy.java](https://codecov.io/gh/apache/rocketmq/pull/4358/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGhpbmNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGhpbmNsaWVudC9yZXRyeS9CYWNrb2ZmUmV0cnlQb2xpY3kuamF2YQ==) | `0.00% <ø> (ø)` | |
| [.../org/apache/rocketmq/thinclient/rpc/TLSHelper.java](https://codecov.io/gh/apache/rocketmq/pull/4358/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGhpbmNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGhpbmNsaWVudC9ycGMvVExTSGVscGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...inclient/impl/consumer/StandardConsumeService.java](https://codecov.io/gh/apache/rocketmq/pull/4358/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGhpbmNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGhpbmNsaWVudC9pbXBsL2NvbnN1bWVyL1N0YW5kYXJkQ29uc3VtZVNlcnZpY2UuamF2YQ==) | `12.50% <12.50%> (ø)` | |
| [...rg/apache/rocketmq/thinclient/misc/Dispatcher.java](https://codecov.io/gh/apache/rocketmq/pull/4358/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGhpbmNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGhpbmNsaWVudC9taXNjL0Rpc3BhdGNoZXIuamF2YQ==) | `25.00% <25.00%> (ø)` | |
| ... and [69 more](https://codecov.io/gh/apache/rocketmq/pull/4358/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/4358?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4358?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d8c9bd3...b9a241c](https://codecov.io/gh/apache/rocketmq/pull/4358?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] aaron-ai commented on pull request #4358: [ISSUE #3949] Add support for gRPC client
Posted by GitBox <gi...@apache.org>.
aaron-ai commented on PR #4358:
URL: https://github.com/apache/rocketmq/pull/4358#issuecomment-1159919053
The gRPC based client will moved to [rocketmq-clients](https://github.com/apache/rocketmq-clients), this pull request will be deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] aaron-ai closed pull request #4358: [ISSUE #3949] Add support for gRPC client
Posted by GitBox <gi...@apache.org>.
aaron-ai closed pull request #4358: [ISSUE #3949] Add support for gRPC client
URL: https://github.com/apache/rocketmq/pull/4358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui commented on pull request #4358: [ISSUE #3949] Add support for gRPC client
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #4358:
URL: https://github.com/apache/rocketmq/pull/4358#issuecomment-1134089216
It's a huge pull request and would be very challenging to review thoroughly. Any idea to split it into multiple mini-components?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] aaron-ai commented on pull request #4358: [ISSUE #3949] Add support for gRPC client
Posted by GitBox <gi...@apache.org>.
aaron-ai commented on PR #4358:
URL: https://github.com/apache/rocketmq/pull/4358#issuecomment-1133589369
There may be some CI issues in this pull request, which would be solved later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org