You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/09/04 03:57:03 UTC
[GitHub] [kafka] showuon opened a new pull request #9251: KAFKA-10459: Document IQ APIs where order does not hold between stores
showuon opened a new pull request #9251:
URL: https://github.com/apache/kafka/pull/9251
Referring to https://github.com/apache/kafka/pull/9138#discussion_r480469688 , documented on the `ReadOnlyWindowStore` class. Thanks.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax merged pull request #9251: KAFKA-10459: Document IQ APIs where order does not hold between stores
Posted by GitBox <gi...@apache.org>.
mjsax merged pull request #9251:
URL: https://github.com/apache/kafka/pull/9251
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #9251: KAFKA-10459: Document IQ APIs where order does not hold between stores
Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #9251:
URL: https://github.com/apache/kafka/pull/9251#issuecomment-696467547
Thanks for the PR @showuon!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #9251: KAFKA-10459: Document IQ APIs where order does not hold between stores
Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #9251:
URL: https://github.com/apache/kafka/pull/9251#issuecomment-696467547
Thanks for the PR @showuon!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax merged pull request #9251: KAFKA-10459: Document IQ APIs where order does not hold between stores
Posted by GitBox <gi...@apache.org>.
mjsax merged pull request #9251:
URL: https://github.com/apache/kafka/pull/9251
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on a change in pull request #9251: KAFKA-10459: Document IQ APIs where order does not hold between stores
Posted by GitBox <gi...@apache.org>.
mjsax commented on a change in pull request #9251:
URL: https://github.com/apache/kafka/pull/9251#discussion_r492434090
##########
File path: streams/src/main/java/org/apache/kafka/streams/state/ReadOnlyWindowStore.java
##########
@@ -25,6 +25,11 @@
* A window store that only supports read operations.
* Implementations should be thread-safe as concurrent reads and writes are expected.
*
+ * Note: The current implementation of either forward or backward fetches on range-key-range-time does not
Review comment:
```suggestion
* <p>Note: The current implementation of either forward or backward fetches on range-key-range-time does not
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on a change in pull request #9251: KAFKA-10459: Document IQ APIs where order does not hold between stores
Posted by GitBox <gi...@apache.org>.
mjsax commented on a change in pull request #9251:
URL: https://github.com/apache/kafka/pull/9251#discussion_r492434090
##########
File path: streams/src/main/java/org/apache/kafka/streams/state/ReadOnlyWindowStore.java
##########
@@ -25,6 +25,11 @@
* A window store that only supports read operations.
* Implementations should be thread-safe as concurrent reads and writes are expected.
*
+ * Note: The current implementation of either forward or backward fetches on range-key-range-time does not
Review comment:
```suggestion
* <p>Note: The current implementation of either forward or backward fetches on range-key-range-time does not
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on a change in pull request #9251: KAFKA-10459: Document IQ APIs where order does not hold between stores
Posted by GitBox <gi...@apache.org>.
mjsax commented on a change in pull request #9251:
URL: https://github.com/apache/kafka/pull/9251#discussion_r492434090
##########
File path: streams/src/main/java/org/apache/kafka/streams/state/ReadOnlyWindowStore.java
##########
@@ -25,6 +25,11 @@
* A window store that only supports read operations.
* Implementations should be thread-safe as concurrent reads and writes are expected.
*
+ * Note: The current implementation of either forward or backward fetches on range-key-range-time does not
Review comment:
```suggestion
* <p>Note: The current implementation of either forward or backward fetches on range-key-range-time does not
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax merged pull request #9251: KAFKA-10459: Document IQ APIs where order does not hold between stores
Posted by GitBox <gi...@apache.org>.
mjsax merged pull request #9251:
URL: https://github.com/apache/kafka/pull/9251
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #9251: KAFKA-10459: Document IQ APIs where order does not hold between stores
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #9251:
URL: https://github.com/apache/kafka/pull/9251#issuecomment-686888639
@jeqo @guozhangwang , could you review this PR to improve javadoc? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #9251: KAFKA-10459: Document IQ APIs where order does not hold between stores
Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #9251:
URL: https://github.com/apache/kafka/pull/9251#issuecomment-696467547
Thanks for the PR @showuon!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org