You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "tvalentyn (via GitHub)" <gi...@apache.org> on 2023/05/19 00:02:56 UTC
[GitHub] [beam] tvalentyn opened a new pull request, #26778: Set Dataflow container to release version.
tvalentyn opened a new pull request, #26778:
URL: https://github.com/apache/beam/pull/26778
Cherrypick #26753 to the release branch.
This removes a usability regression that affects users of custom containers, particularly those using custom Ubuntu-based images, such as off-the-shelf GPU images for RunInference transform.
Asking to CP to the release branch if still possible. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #26778: Don't fail if creating a venv didn't succeed - CP of #26753
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #26778:
URL: https://github.com/apache/beam/pull/26778#issuecomment-1553859722
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/26778?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> :exclamation: No coverage uploaded for pull request base (`release-2.48.0@68aa814`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit).
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## release-2.48.0 #26778 +/- ##
=================================================
Coverage ? 72.04%
=================================================
Files ? 745
Lines ? 101204
Branches ? 0
=================================================
Hits ? 72916
Misses ? 26829
Partials ? 1459
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `81.07% <0.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on pull request #26778: Don't fail if creating a venv didn't succeed - CP of #26753
Posted by "riteshghorse (via GitHub)" <gi...@apache.org>.
riteshghorse commented on PR #26778:
URL: https://github.com/apache/beam/pull/26778#issuecomment-1554589231
Not sure why java checks were triggered on this!.
Merging!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26778: Don't fail if creating a venv didn't succeed - CP of #26753
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26778:
URL: https://github.com/apache/beam/pull/26778#issuecomment-1554056026
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #26778: Don't fail if creating a venv didn't succeed - CP of #26753
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb commented on PR #26778:
URL: https://github.com/apache/beam/pull/26778#issuecomment-1554897466
Presumably the reason venv was added was to solve some problem (maybe mixing up of dependencies or something like that). Just falling back to not using it would cause it to (non-determanistically) exhibit the same issues that adding this was trying to solve.
Some alternatives would be to make it explicit whether venv should be used (either opt-in or opt-out) or make venv a requirement for Beam (if the user pre-installs beam) or at the very least give a clear error (e.g. "venv is required but not installed in this custom container).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse merged pull request #26778: Don't fail if creating a venv didn't succeed - CP of #26753
Posted by "riteshghorse (via GitHub)" <gi...@apache.org>.
riteshghorse merged PR #26778:
URL: https://github.com/apache/beam/pull/26778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #26778: Don't fail if creating a venv didn't succeed - CP of #26753
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #26778:
URL: https://github.com/apache/beam/pull/26778#issuecomment-1554791190
Do you have a specific failure mode in mind?
I could change the check to fall back on default environment if venv module is not available, instead of on any failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #26778: Don't fail if creating a venv didn't succeed - CP of #26753
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #26778:
URL: https://github.com/apache/beam/pull/26778#issuecomment-1554994631
Ok, I filed https://github.com/apache/beam/issues/26792 to follow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org