[GitHub] [geode] upthewaterspout opened pull request #3284: GEODE-6503: Moving redis into a separate module

["upthewaterspout (GitHub)" <gi...@apache.org>]

* Moving all of the geode redis apapter code to the geode-redis module
* Moving the redis specific dependencies (netty and geo) to geode-redis
* Adding a GeodeRedisService to initialize the redis server

The geode distribution will still include redis, and gfsh start server
will still include redis on it's classpath. However, consumers of
the geode-core maven module will no longer get the redis module and it's
dependencies unless they explicitly also depend on geode-redis.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3284 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] bschuchardt commented on pull request #3284: GEODE-6503: Moving redis into a separate module

["bschuchardt (GitHub)" <gi...@apache.org>]

is there a reason to stopServices before stopping cache servers?  If not I'd like to see servers stopped ASAP.  We have full control over cache server shutdown but Redis shutdown involves stopping a Netty server, over which we have less control.

[ Full content available at: https://github.com/apache/geode/pull/3284 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] upthewaterspout closed pull request #3284: GEODE-6503: Moving redis into a separate module

["upthewaterspout (GitHub)" <gi...@apache.org>]

[ pull request closed by upthewaterspout ]

[ Full content available at: https://github.com/apache/geode/pull/3284 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] upthewaterspout commented on pull request #3284: GEODE-6503: Moving redis into a separate module

["upthewaterspout (GitHub)" <gi...@apache.org>]

Not really. I can move it to after stopServers. Are you concerned that some of the services might throw an exception from stop? We should probably handle that - I can add a try/catch around service.close() as well. 

[ Full content available at: https://github.com/apache/geode/pull/3284 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] metatype commented on issue #3284: GEODE-6503: Moving redis into a separate module

["metatype (GitHub)" <gi...@apache.org>]

👏 I attempted this once before and failed.  Sounds great!!!

[ Full content available at: https://github.com/apache/geode/pull/3284 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org