You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "PrasanthV454 (via GitHub)" <gi...@apache.org> on 2023/08/11 07:31:48 UTC
[GitHub] [kafka] PrasanthV454 opened a new pull request, #14191: Disable Tests causing exit issues during the builds
PrasanthV454 opened a new pull request, #14191:
URL: https://github.com/apache/kafka/pull/14191
AK Builds are exiting while running the tests. After going through various builds here is what I found -
- Clients which ever aren't closed while running the tests are trying to connect to the broker even when broker got shutdown. And when a gradle worker starts running on the same port which is a system assigned port as gradle by default bind a worker to port:0 and if broker was running previously it starts accepting the connection from the hanging clients and result in MessageIOException and eventually gradle worker starts shutting down with a ConnectException. All the tests expect MetadataQuorumCommandTest may be the reason for this.
- Whenever the build initiates the shutdown process it starts removing the shutdown hooks and these shutdown hooks can only be removed when all the executing threads were able to gracefully shutdown. But few tests in MetadataQuorumCommandTest aren't able to catch the InterruptSignal and resulting in failure of removing shutdown hooks.
These two issues are mainly contributing for the build failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] PrasanthV454 commented on pull request #14191: Disable Tests causing exit issues during the builds
Posted by "PrasanthV454 (via GitHub)" <gi...@apache.org>.
PrasanthV454 commented on PR #14191:
URL: https://github.com/apache/kafka/pull/14191#issuecomment-1674530457
> @PrasanthV454 thank you for digging into this. Some of these are tests are important enough that we cannot release without them. But they are also making CI fail and hence making it difficult to review code.
>
> May I suggest the following path forward:
>
> 1. Create a ticket for each test that we are disabling here and mark it as "blocker" for 3.6 release
> 2. Disable the tests
> 3. Fix the tests one by one by resolving the root cause
makes sense. I don't have access to create tickets yet(requested for it). @lbradstreet is helping me with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on pull request #14191: Disable Tests causing exit issues during the builds
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #14191:
URL: https://github.com/apache/kafka/pull/14191#issuecomment-1674572876
> @divijvaidya "prasanth" it is.
Ah seems like your JIRA account is not created at all. https://issues.apache.org/jira/secure/ViewProfile.jspa?name=prasanth says "The specified user could not be found."
Did you follow the steps at https://kafka.apache.org/contributing.html, specifically, "Please request a JIRA account using [ASF's Self-serve portal](https://selfserve.apache.org/jira-account.html). After that you can assign yourself to the JIRA ticket you have started working on so others will notice."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on pull request #14191: Disable Tests causing exit issues during the builds
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #14191:
URL: https://github.com/apache/kafka/pull/14191#issuecomment-1674534365
@PrasanthV454 what's your JIRA username? I can add permissions now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on pull request #14191: Disable Tests causing exit issues during the builds
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #14191:
URL: https://github.com/apache/kafka/pull/14191#issuecomment-1674447516
@PrasanthV454 thank you for digging into this. Some of these are tests are important enough that we cannot release without them. But they are also making CI fail and hence making it difficult to review code.
May I suggest the following path forward:
1. Create a ticket for each test that we are disabling here and mark it as "blocker" for 3.6 release
2. Disable the tests
3. Fix the tests one by one by resolving the root cause
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on pull request #14191: Disable Tests causing exit issues during the builds
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #14191:
URL: https://github.com/apache/kafka/pull/14191#issuecomment-1674564363
Added you as a contributor. You should be able to create JIRA now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on pull request #14191: Disable Tests causing exit issues during the builds
Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante commented on PR #14191:
URL: https://github.com/apache/kafka/pull/14191#issuecomment-1675305377
A few extra thoughts:
- We may be unearthing fundamental limitations with the static `Exit` API if we can't cleanly/easily force testing-only clusters to not invoke `System::exit` (or similar methods). It may be more appropriate to develop a non-static API similar to the [Time interface](https://github.com/apache/kafka/blob/f5655d31d3d527dae057240570162827c6a79fb2/clients/src/main/java/org/apache/kafka/common/utils/Time.java) so that we can have complete control over our testing clusters
- Since https://github.com/apache/kafka/pull/14156 was merged, there have been no test failures on trunk for the `testOffsetTranslationBehindReplicationFlow` case. We can look into the other failing tests, but this one was the highest-priority because we had reason to believe that it was indicative of legitimate issues with MM2 (and these suspicions proved correct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disable Tests causing exit issues during the builds [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14191:
URL: https://github.com/apache/kafka/pull/14191#issuecomment-2567257813
This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disable Tests causing exit issues during the builds [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14191:
URL: https://github.com/apache/kafka/pull/14191#issuecomment-1805022042
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) <p> If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] PrasanthV454 commented on pull request #14191: Disable Tests causing exit issues during the builds
Posted by "PrasanthV454 (via GitHub)" <gi...@apache.org>.
PrasanthV454 commented on PR #14191:
URL: https://github.com/apache/kafka/pull/14191#issuecomment-1674600678
@divijvaidya I did follow the above steps. can you try Prasanth?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] AndrewJSchofield commented on a diff in pull request #14191: Disable Tests causing exit issues during the builds
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on code in PR #14191:
URL: https://github.com/apache/kafka/pull/14191#discussion_r1291101907
##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationTransactionsTest.java:
##########
@@ -31,6 +32,7 @@
* Integration test for MirrorMaker2 in which source records are emitted with a transactional producer,
* which interleaves transaction commit messages into the source topic which are not propagated downstream.
*/
+@Disabled
Review Comment:
This is the one that's been bothering me. Nice :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on pull request #14191: Disable Tests causing exit issues during the builds
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #14191:
URL: https://github.com/apache/kafka/pull/14191#issuecomment-1674434985
cc @kirktrue since you are interested in getting the CI stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] PrasanthV454 commented on pull request #14191: Disable Tests causing exit issues during the builds
Posted by "PrasanthV454 (via GitHub)" <gi...@apache.org>.
PrasanthV454 commented on PR #14191:
URL: https://github.com/apache/kafka/pull/14191#issuecomment-1674540040
@divijvaidya "prasanth" it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disable Tests causing exit issues during the builds [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #14191: Disable Tests causing exit issues during the builds
URL: https://github.com/apache/kafka/pull/14191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org