You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/21 23:01:19 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
dongjoon-hyun opened a new pull request #30456:
URL: https://github.com/apache/spark/pull/30456
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731654815
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731650899
**[Test build #131483 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131483/testReport)** for PR 30456 at commit [`e1646e1`](https://github.com/apache/spark/commit/e1646e1355f3cb9c88fb4ed1cec33d0a7cb14e58).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731779019
Ah, good question. I missed your point of the question. Let me check it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731851367
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36114/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731844448
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731660061
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36089/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731654881
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131482/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731802729
I switched to Mockito 3.4.6 to avoid any dependency change in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731844448
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731831733
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36107/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30456:
URL: https://github.com/apache/spark/pull/30456
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731662164
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731816237
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36107/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731862074
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731654738
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36088/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731678789
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731655443
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731656862
**[Test build #131484 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131484/testReport)** for PR 30456 at commit [`e1646e1`](https://github.com/apache/spark/commit/e1646e1355f3cb9c88fb4ed1cec33d0a7cb14e58).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731876968
Thank you so much, @viirya !
Merged to master for Apache Spark 3.1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731842805
**[Test build #131510 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131510/testReport)** for PR 30456 at commit [`687d122`](https://github.com/apache/spark/commit/687d1227b6c23cfb9d7b38ee9d9b9b85fd6c21a2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731842929
The Jenkins is already running SparkR tests here.
- https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131503/testReport
The last commit is an empty commit to make it sure `GitHub Action`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731862959
Could you review this again, @srowen and @maropu ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731654815
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731842929
The Jenkins is already running SparkR tests here.
- https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131503/testReport
The last commit is an empty commit to make it sure in `GitHub Action`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731831748
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731799878
@srowen . The root cause is `Twitter Chill`. It added a compile dependency for `objenesis` first and it's upgraded to 3.1.0 due to the test dependency.
```
[INFO] +- com.twitter:chill_2.12:jar:0.9.5:compile
[INFO] | \- com.esotericsoftware:kryo-shaded:jar:4.0.2:compile
[INFO] | +- com.esotericsoftware:minlog:jar:1.3.0:compile
[INFO] | \- org.objenesis:objenesis:jar:2.5.1:compile
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731654858
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731662153
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36089/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731848189
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36114/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731867720
Could you review this, @viirya ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731650064
**[Test build #131482 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131482/testReport)** for PR 30456 at commit [`1328291`](https://github.com/apache/spark/commit/1328291a3754a4fdb7ab990e97aa1c8101ac70d3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731656593
> Mockito: 3.1.0 -> 3.5.15
not `3.6.0` but `3.5.15`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731678065
**[Test build #131484 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131484/testReport)** for PR 30456 at commit [`e1646e1`](https://github.com/apache/spark/commit/e1646e1355f3cb9c88fb4ed1cec33d0a7cb14e58).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731777783
Yeah but why does mockito affect the non-test dependencies?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731844134
**[Test build #131503 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131503/testReport)** for PR 30456 at commit [`befd6cf`](https://github.com/apache/spark/commit/befd6cfd6da2cc72d8c590c32422eb59e0c1ab2e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731803186
**[Test build #131503 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131503/testReport)** for PR 30456 at commit [`befd6cf`](https://github.com/apache/spark/commit/befd6cfd6da2cc72d8c590c32422eb59e0c1ab2e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731842805
**[Test build #131510 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131510/testReport)** for PR 30456 at commit [`687d122`](https://github.com/apache/spark/commit/687d1227b6c23cfb9d7b38ee9d9b9b85fd6c21a2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731678789
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731662164
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731862074
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731851376
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731861792
**[Test build #131510 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131510/testReport)** for PR 30456 at commit [`687d122`](https://github.com/apache/spark/commit/687d1227b6c23cfb9d7b38ee9d9b9b85fd6c21a2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731831748
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731803186
**[Test build #131503 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131503/testReport)** for PR 30456 at commit [`befd6cf`](https://github.com/apache/spark/commit/befd6cfd6da2cc72d8c590c32422eb59e0c1ab2e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731851376
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731851379
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36114/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731831755
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36107/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731807087
OK. Huh weird that it can change the compile-time classpath if it's a test dependency!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #30456:
URL: https://github.com/apache/spark/pull/30456#discussion_r528357477
##########
File path: dev/deps/spark-deps-hadoop-3.2-hive-2.3
##########
@@ -161,7 +161,7 @@ metrics-json/4.1.1//metrics-json-4.1.1.jar
metrics-jvm/4.1.1//metrics-jvm-4.1.1.jar
minlog/1.3.0//minlog-1.3.0.jar
netty-all/4.1.51.Final//netty-all-4.1.51.Final.jar
-objenesis/2.6//objenesis-2.6.jar
+objenesis/3.1//objenesis-3.1.jar
Review comment:
Interesting that this is changed by only changing test dependencies. Is it because jmock-junit4 should be test scope?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30456: [SPARK-33512][BUILD] Upgrade test libraries
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30456:
URL: https://github.com/apache/spark/pull/30456#issuecomment-731656862
**[Test build #131484 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131484/testReport)** for PR 30456 at commit [`e1646e1`](https://github.com/apache/spark/commit/e1646e1355f3cb9c88fb4ed1cec33d0a7cb14e58).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org