You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/26 18:50:48 UTC
[GitHub] [beam] pabloem opened a new pull request, #17468: Improvement to Seed job configuration so we can launch seed jobs against PRs
pabloem opened a new pull request, #17468:
URL: https://github.com/apache/beam/pull/17468
r: @kennknowles
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #17468: Improvement to Seed job configuration so we can launch seed jobs against PRs
Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #17468:
URL: https://github.com/apache/beam/pull/17468#issuecomment-1111293485
Interesting. The weird thing is https://ci-beam.apache.org/job/beam_SeedJob/9555/ where I ran it from Jenkins with the same `origin/pr/X/head` parameter and it succeeded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #17468: Improvement to Seed job configuration so we can launch seed jobs against PRs
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17468:
URL: https://github.com/apache/beam/pull/17468#issuecomment-1110196988
here's an example of a seed job that ran where I manually added the parameter: https://ci-beam.apache.org/job/beam_SeedJob/9589/console
Note the output in this failed seed job: https://ci-beam.apache.org/job/beam_SeedJob/9588/console
It needs the `ghprbPullId` parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #17468: Improvement to Seed job configuration so we can launch seed jobs against PRs
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #17468:
URL: https://github.com/apache/beam/pull/17468#issuecomment-1112069701
I think Seed job broke after this change. Sample error:
https://ci-beam.apache.org/job/beam_SeedJob/9598/console
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #17468: Improvement to Seed job configuration so we can launch seed jobs against PRs
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #17468:
URL: https://github.com/apache/beam/pull/17468#issuecomment-1113955008
Seed job still failing, let's try to revert this and see if it recovers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #17468: Improvement to Seed job configuration so we can launch seed jobs against PRs
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #17468:
URL: https://github.com/apache/beam/pull/17468#issuecomment-1112075468
I can still run seed jobs from open PRs but seed job fails when I trigger it from master via Jenkins UI, cron runs also fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #17468: Improvement to Seed job configuration so we can launch seed jobs against PRs
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17468:
URL: https://github.com/apache/beam/pull/17468#issuecomment-1111360485
it needs the number to replace it in the templated commands (https://github.com/apache/beam/blob/9cd53228d9938791114ef3dcfd1e9deea8ca0d4b/.test-infra/jenkins/job_seed_standalone.groovy#L47) - I did not look much further to figure out if we could rewrite the job to not need it - I just figured that this works : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #17468: Improvement to Seed job configuration so we can launch seed jobs against PRs
Posted by GitBox <gi...@apache.org>.
pabloem merged PR #17468:
URL: https://github.com/apache/beam/pull/17468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org