You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/09/28 00:16:32 UTC

[kudu-CR] master-test: deflake a test

Hello Alexey Serbin,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/8158

to review the following change.


Change subject: master-test: deflake a test
......................................................................

master-test: deflake a test

In this test the master would periodically crash in Restart due to an
injected SysCatalogTable::Write failure.

Change-Id: Ic6bd104f818b76a74f4b56353dc6f3839e1c02cc
---
M src/kudu/master/master-test.cc
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/8158/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic6bd104f818b76a74f4b56353dc6f3839e1c02cc
Gerrit-Change-Number: 8158
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>

[kudu-CR] master-test: deflake a test

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8158 )

Change subject: master-test: deflake a test
......................................................................

master-test: deflake a test

In this test the master would periodically crash in Restart due to an
injected SysCatalogTable::Write failure.

Change-Id: Ic6bd104f818b76a74f4b56353dc6f3839e1c02cc
Reviewed-on: http://gerrit.cloudera.org:8080/8158
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/master/master-test.cc
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6bd104f818b76a74f4b56353dc6f3839e1c02cc
Gerrit-Change-Number: 8158
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] master-test: deflake a test

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8158 )

Change subject: master-test: deflake a test
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6bd104f818b76a74f4b56353dc6f3839e1c02cc
Gerrit-Change-Number: 8158
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 28 Sep 2017 00:22:37 +0000
Gerrit-HasComments: No