You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/05/21 00:01:51 UTC

Review Request: Renamed tests/zookeeper_test.hpp|cpp to zookeeper.hpp|cpp.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11272/
-----------------------------------------------------------

Review request for mesos.


Description
-------

We've got more then just the ZooKeeperTest fixture in here and I wanted the name to reflect that.


Diffs
-----

  src/Makefile.am 343a7c5288e83d20dc6dd4db5353499199b90cb1 
  src/tests/allocator_zookeeper_tests.cpp 2c7deb1ef8d4349964ffa0bdd7b97ae616be1c43 
  src/tests/group_tests.cpp PRE-CREATION 
  src/tests/master_detector_tests.cpp 521f0279b165f5d3639788ff6a00b772e6f71b7a 
  src/tests/state_tests.cpp eb124fdc10491f085007b5a7e9fd47e006f1523f 
  src/tests/zookeeper.hpp PRE-CREATION 
  src/tests/zookeeper.cpp PRE-CREATION 
  src/tests/zookeeper_test.hpp b5215b00973c9168f681832085bb29f6a8db8160 
  src/tests/zookeeper_test.cpp fb61f2d9a5f431496e459807d6723ec12cf7ec55 
  src/tests/zookeeper_tests.cpp e9180bfd35ee4477849d3a776c29eff5206d66e9 

Diff: https://reviews.apache.org/r/11272/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman

Re: Review Request: Renamed tests/zookeeper_test.hpp|cpp to zookeeper.hpp|cpp.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11272/#review21031
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On May 20, 2013, 10:01 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11272/
> -----------------------------------------------------------
> 
> (Updated May 20, 2013, 10:01 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Description
> -------
> 
> We've got more then just the ZooKeeperTest fixture in here and I wanted the name to reflect that.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 343a7c5288e83d20dc6dd4db5353499199b90cb1 
>   src/tests/allocator_zookeeper_tests.cpp 2c7deb1ef8d4349964ffa0bdd7b97ae616be1c43 
>   src/tests/group_tests.cpp PRE-CREATION 
>   src/tests/master_detector_tests.cpp 521f0279b165f5d3639788ff6a00b772e6f71b7a 
>   src/tests/state_tests.cpp eb124fdc10491f085007b5a7e9fd47e006f1523f 
>   src/tests/zookeeper.hpp PRE-CREATION 
>   src/tests/zookeeper.cpp PRE-CREATION 
>   src/tests/zookeeper_test.hpp b5215b00973c9168f681832085bb29f6a8db8160 
>   src/tests/zookeeper_test.cpp fb61f2d9a5f431496e459807d6723ec12cf7ec55 
>   src/tests/zookeeper_tests.cpp e9180bfd35ee4477849d3a776c29eff5206d66e9 
> 
> Diff: https://reviews.apache.org/r/11272/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>