You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2013/11/14 13:21:44 UTC
Review Request 15514: CLOUDSTACK-5168: Fixed test script issue related to
SSH command
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15514/
-----------------------------------------------------------
Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-5168
https://issues.apache.org/jira/browse/CLOUDSTACK-5168
Repository: cloudstack-git
Description
-------
test_egress_rules.TestRevokeEgressRule.test_revoke_egress_rule
This test case fails die to assertion error.
Ping to outside world should be allowed when egress rule is present and it should not be allowed after revoking to egress rule. The code related to this was interchanged before.
Fixed the test script issues.
This test case will still fail due to product bug filed --> https://issues.apache.org/jira/browse/CLOUDSTACK-5167
Diffs
-----
test/integration/component/test_egress_rules.py 34995ff
Diff: https://reviews.apache.org/r/15514/diff/
Testing
-------
Tested locally on Xenserver Basic Zone setup
Thanks,
Ashutosh Kelkar
Re: Review Request 15514: CLOUDSTACK-5168: Fixed test script issue related
to SSH command
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15514/#review28938
-----------------------------------------------------------
Commit 1106116b48cdb253046462c2d9d483b63876a740 in branch refs/heads/4.2 from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1106116 ]
CLOUDSTACK-5168: Fixed test script issue related to SSH
command
- ASF Subversion and Git Services
On Nov. 14, 2013, 12:21 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15514/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2013, 12:21 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5168
> https://issues.apache.org/jira/browse/CLOUDSTACK-5168
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> test_egress_rules.TestRevokeEgressRule.test_revoke_egress_rule
> This test case fails die to assertion error.
> Ping to outside world should be allowed when egress rule is present and it should not be allowed after revoking to egress rule. The code related to this was interchanged before.
> Fixed the test script issues.
>
> This test case will still fail due to product bug filed --> https://issues.apache.org/jira/browse/CLOUDSTACK-5167
>
>
> Diffs
> -----
>
> test/integration/component/test_egress_rules.py 34995ff
>
> Diff: https://reviews.apache.org/r/15514/diff/
>
>
> Testing
> -------
>
> Tested locally on Xenserver Basic Zone setup
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 15514: CLOUDSTACK-5168: Fixed test script issue related
to SSH command
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15514/#review28940
-----------------------------------------------------------
Ship it!
Committed to 4.2, 4.3 and master
- Girish Shilamkar
On Nov. 14, 2013, 12:21 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15514/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2013, 12:21 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5168
> https://issues.apache.org/jira/browse/CLOUDSTACK-5168
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> test_egress_rules.TestRevokeEgressRule.test_revoke_egress_rule
> This test case fails die to assertion error.
> Ping to outside world should be allowed when egress rule is present and it should not be allowed after revoking to egress rule. The code related to this was interchanged before.
> Fixed the test script issues.
>
> This test case will still fail due to product bug filed --> https://issues.apache.org/jira/browse/CLOUDSTACK-5167
>
>
> Diffs
> -----
>
> test/integration/component/test_egress_rules.py 34995ff
>
> Diff: https://reviews.apache.org/r/15514/diff/
>
>
> Testing
> -------
>
> Tested locally on Xenserver Basic Zone setup
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 15514: CLOUDSTACK-5168: Fixed test script issue related
to SSH command
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15514/#review28941
-----------------------------------------------------------
Commit b178d0645418faa947c414be4241e01657dcadb4 in branch refs/heads/master from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b178d06 ]
CLOUDSTACK-5168: Fixed test script issue related to SSH
command
- ASF Subversion and Git Services
On Nov. 14, 2013, 12:21 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15514/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2013, 12:21 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5168
> https://issues.apache.org/jira/browse/CLOUDSTACK-5168
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> test_egress_rules.TestRevokeEgressRule.test_revoke_egress_rule
> This test case fails die to assertion error.
> Ping to outside world should be allowed when egress rule is present and it should not be allowed after revoking to egress rule. The code related to this was interchanged before.
> Fixed the test script issues.
>
> This test case will still fail due to product bug filed --> https://issues.apache.org/jira/browse/CLOUDSTACK-5167
>
>
> Diffs
> -----
>
> test/integration/component/test_egress_rules.py 34995ff
>
> Diff: https://reviews.apache.org/r/15514/diff/
>
>
> Testing
> -------
>
> Tested locally on Xenserver Basic Zone setup
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 15514: CLOUDSTACK-5168: Fixed test script issue related
to SSH command
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15514/#review28939
-----------------------------------------------------------
Commit 0a02c7e1474d12fb494e6938d5e67018790c2bd2 in branch refs/heads/4.3 from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0a02c7e ]
CLOUDSTACK-5168: Fixed test script issue related to SSH
command
- ASF Subversion and Git Services
On Nov. 14, 2013, 12:21 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15514/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2013, 12:21 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5168
> https://issues.apache.org/jira/browse/CLOUDSTACK-5168
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> test_egress_rules.TestRevokeEgressRule.test_revoke_egress_rule
> This test case fails die to assertion error.
> Ping to outside world should be allowed when egress rule is present and it should not be allowed after revoking to egress rule. The code related to this was interchanged before.
> Fixed the test script issues.
>
> This test case will still fail due to product bug filed --> https://issues.apache.org/jira/browse/CLOUDSTACK-5167
>
>
> Diffs
> -----
>
> test/integration/component/test_egress_rules.py 34995ff
>
> Diff: https://reviews.apache.org/r/15514/diff/
>
>
> Testing
> -------
>
> Tested locally on Xenserver Basic Zone setup
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>