[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2413: LUCENE-9799: Hunspell: don't check second-level affixes when the first level isn't a continuation

[GitBox <gi...@apache.org>]

donnerpeter commented on a change in pull request #2413:
URL: https://github.com/apache/lucene-solr/pull/2413#discussion_r580104444



##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java
##########
@@ -78,9 +78,6 @@
   private static final int DEFAULT_FLAGS = 65510;
   static final char HIDDEN_FLAG = (char) 65511; // called 'ONLYUPCASEFLAG' in Hunspell
 
-  // TODO: really for suffixes we should reverse the automaton and run them backwards
-  private static final String PREFIX_CONDITION_REGEX = "%s.*";
-  private static final String SUFFIX_CONDITION_REGEX = ".*%s";

Review comment:
       Inlined to the use site to make method signature shorter to still fit one line :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org