[jira] [Commented] (HADOOP-11057) checknative command to probe for winutils.exe on windows

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-11057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14126338#comment-14126338 ] 

Hadoop QA commented on HADOOP-11057:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12667271/HADOOP-11057.0.patch
  against trunk revision d989ac0.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4673//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4673//console

This message is automatically generated.

> checknative command to probe for winutils.exe on windows
> --------------------------------------------------------
>
>                 Key: HADOOP-11057
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11057
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: native
>    Affects Versions: 2.5.0
>         Environment: windows
>            Reporter: Steve Loughran
>            Assignee: Xiaoyu Yao
>            Priority: Minor
>             Fix For: 2.4.1
>
>         Attachments: HADOOP-11057.0.patch
>
>
> hadoop's {{checknative}} command looks for native binaries and returns an error code if one is missing.
> But it doesn't check for {{winutils.exe}} on windows, which turns out to be essential for some operations. 
> Adding this check to the -a (or default) operation would allow the check to be used as a health check on windows installations



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)