You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/03/08 12:17:44 UTC
[GitHub] [bookkeeper] eolivelli opened a new pull request #2283: Make
bookkeeper script work on Git Bash on Windows
eolivelli opened a new pull request #2283: Make bookkeeper script work on Git Bash on Windows
URL: https://github.com/apache/bookkeeper/pull/2283
Descriptions of the changes in this PR:
### Motivation
Add the ability to run "bookkeeper" in a Windows environment with "Git Bash" tool.
This patch is not supposed to enable the execution of BookKeeper server in Production.
With this patch is is possible to run "bookkeeper localbookie" and "bookkeeper standalone" in a Windows environment, to ease development of client applications.
### Changes
Handle CLASSPATH, dropping double colon (::) separators.
Do not use 'exec' to start the commands.
Master Issue: #2267
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2283: Make bookkeeper
script work on Git Bash on Windows
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2283: Make bookkeeper script work on Git Bash on Windows
URL: https://github.com/apache/bookkeeper/pull/2283#issuecomment-596199376
@mino181295 @dmercuriali please take a look.
Unfortunately BK cannot be built on windows but you can use the patched 'bin/bookkeeper' script in a bookeeper 4.10.0 server tarbal in order to run "localbookie" and "standaalone"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2283:
Make bookkeeper script work on Git Bash on Windows
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #2283: Make bookkeeper script work on Git Bash on Windows
URL: https://github.com/apache/bookkeeper/pull/2283#discussion_r389579517
##########
File path: bin/bookkeeper
##########
@@ -156,26 +162,27 @@ fi
#Change to BK_HOME to support relative paths
cd "$BK_HOME"
if [ ${COMMAND} == "bookie" ]; then
- exec ${JAVA} ${OPTS} ${JMX_ARGS} org.apache.bookkeeper.server.Main --conf ${BOOKIE_CONF} $@
+ $EXECCMD ${JAVA} ${OPTS} ${JMX_ARGS} org.apache.bookkeeper.server.Main --conf ${BOOKIE_CONF} $@
elif [ ${COMMAND} == "autorecovery" ]; then
- exec ${JAVA} ${OPTS} ${JMX_ARGS} org.apache.bookkeeper.replication.AutoRecoveryMain --conf ${BOOKIE_CONF} $@
-elif [ ${COMMAND} == "localbookie" ]; then
+ $EXECCMD ${JAVA} ${OPTS} ${JMX_ARGS} org.apache.bookkeeper.replication.AutoRecoveryMain --conf ${BOOKIE_CONF} $@
+elif [ "${COMMAND}" == "localbookie" ]; then
NUMBER=$1
shift
- exec ${JAVA} ${OPTS} ${JMX_ARGS} -Dzookeeper.4lw.commands.whitelist='*' org.apache.bookkeeper.util.LocalBookKeeper ${NUMBER} ${BOOKIE_CONF} $@
+ $EXECCMD ${JAVA} ${OPTS} ${JMX_ARGS} '-Dzookeeper.4lw.commands.whitelist=*' org.apache.bookkeeper.util.LocalBookKeeper ${NUMBER} ${BOOKIE_CONF} $@
+ ${JAVA} ${OPTS} org.apache.bookkeeper.util.LocalBookKeeper ${NUMBER} ${BOOKIE_CONF} $@
Review comment:
it looks like I have committed some debug code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services