You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "klesh (via GitHub)" <gi...@apache.org> on 2023/10/18 05:32:26 UTC
[PR] fix: pr should be connected to failed deployment commit [incubator-devlake]
klesh opened a new pull request, #6270:
URL: https://github.com/apache/incubator-devlake/pull/6270
### Summary
Based on the description of #6224, it appears that the PR is connected to a failed deployment commit which is obviously wrong.
By examining the code, I found a possible cause of the problem:
1. Refdiff would only calculate `commits_diffs` for SUCCEEDED deployment commits
2. DORA would connect PR to the deployment commit by looking up the `commits_diffs` table, but it doesn't check whether the deployment commit was successful.
3. So, if somehow the failed deployment commit existed in the `commits_diffs` table, it breaks
### Does this close any open issues?
Closes #6224
### Screenshots
The case has been added to the `e2e-test`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: pr should be connected to failed deployment commit [incubator-devlake]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6270:
URL: https://github.com/apache/incubator-devlake/pull/6270#issuecomment-1767687924
🤖 cherry pick finished successfully 🎉!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: pr should be connected to failed deployment commit [incubator-devlake]
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn merged PR #6270:
URL: https://github.com/apache/incubator-devlake/pull/6270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org