You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/12/13 20:44:59 UTC
Review Request 54590: Removed unused peek function.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54590/
-----------------------------------------------------------
Review request for mesos and Daniel Pravat.
Repository: mesos
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/src/io.cpp e81f279ed4bf92f75ad2427550ca822a9b03cca5
3rdparty/libprocess/src/tests/io_tests.cpp b9825e8633f64c23e4b1ea904537cdc8da64ed5b
Diff: https://reviews.apache.org/r/54590/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 54590: Removed unused peek function.
Posted by Daniel Pravat <dp...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54590/#review159208
-----------------------------------------------------------
3rdparty/libprocess/src/io.cpp
<https://reviews.apache.org/r/54590/#comment230152>
Can you also remove the declaration from the io.hpp ?
- Daniel Pravat
On Dec. 13, 2016, 8:44 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54590/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2016, 8:44 p.m.)
>
>
> Review request for mesos and Daniel Pravat.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/io.cpp e81f279ed4bf92f75ad2427550ca822a9b03cca5
> 3rdparty/libprocess/src/tests/io_tests.cpp b9825e8633f64c23e4b1ea904537cdc8da64ed5b
>
> Diff: https://reviews.apache.org/r/54590/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 54590: Removed unused peek function.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54590/#review159119
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54590]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 13, 2016, 8:44 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54590/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2016, 8:44 p.m.)
>
>
> Review request for mesos and Daniel Pravat.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/io.cpp e81f279ed4bf92f75ad2427550ca822a9b03cca5
> 3rdparty/libprocess/src/tests/io_tests.cpp b9825e8633f64c23e4b1ea904537cdc8da64ed5b
>
> Diff: https://reviews.apache.org/r/54590/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 54590: Removed unused peek function.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54590/
-----------------------------------------------------------
(Updated Dec. 15, 2016, 5:40 p.m.)
Review request for mesos and Daniel Pravat.
Repository: mesos
Description
-------
Removed unused peek function.
Diffs (updated)
-----
3rdparty/libprocess/include/process/io.hpp f5489dc66adb136d9f53f98ac64c3fbe7831a1c2
3rdparty/libprocess/src/io.cpp 27da897894e12941a6bba5f5eda04c35100d2d73
3rdparty/libprocess/src/tests/io_tests.cpp b9825e8633f64c23e4b1ea904537cdc8da64ed5b
Diff: https://reviews.apache.org/r/54590/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 54590: Removed unused peek function.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54590/
-----------------------------------------------------------
(Updated Dec. 14, 2016, 3:49 p.m.)
Review request for mesos and Daniel Pravat.
Changes
-------
Addressed Daniel's comments.
Repository: mesos
Description (updated)
-------
Removed unused peek function.
Diffs (updated)
-----
3rdparty/libprocess/include/process/io.hpp f5489dc66adb136d9f53f98ac64c3fbe7831a1c2
3rdparty/libprocess/src/io.cpp 27da897894e12941a6bba5f5eda04c35100d2d73
3rdparty/libprocess/src/tests/io_tests.cpp b9825e8633f64c23e4b1ea904537cdc8da64ed5b
Diff: https://reviews.apache.org/r/54590/diff/
Testing
-------
Thanks,
Michael Park