You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Robin Windels (JIRA)" <ji...@apache.org> on 2008/09/10 03:07:44 UTC
[jira] Created: (FTPSERVER-175) Build test fails under Windows XP
Build test fails under Windows XP
---------------------------------
Key: FTPSERVER-175
URL: https://issues.apache.org/jira/browse/FTPSERVER-175
Project: FtpServer
Issue Type: Bug
Components: Core
Affects Versions: 1.0-M4
Environment: Windows XP, Sun JDK 1.6.0_03
Reporter: Robin Windels
Priority: Minor
excerpt from build log
Failed tests:
testFile(org.apache.ftpserver.config.spring.FileUserManagerConfigTest)
Tests run: 571, Failures: 1, Errors: 0, Skipped: 0
Excerpt from Test set: org.apache.ftpserver.config.spring.FileUserManagerConfigTest
junit.framework.ComparisonFailure: expected:<[/tmp/]foo.users> but was:<[C:\tmp\]foo.users>
Patch that works for me:
Index: FileUserManagerConfigTest.java
===================================================================
--- FileUserManagerConfigTest.java (revision 693655)
+++ FileUserManagerConfigTest.java (working copy)
@@ -41,7 +41,7 @@
public void testFile() throws Throwable {
PropertiesUserManager um = createPropertiesUserManager("<file-user-manager file=\"/tmp/foo.users\" />");
- assertEquals("/tmp/foo.users", um.getFile().getAbsolutePath());
+ assertEquals("/tmp/foo.users".replace('/', um.getFile().separatorChar), um.getFile().getPath());
}
public void testMd5PasswordEncryptor() throws Throwable {
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FTPSERVER-175) Build test fails under Windows XP
Posted by "Robin Windels (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robin Windels updated FTPSERVER-175:
------------------------------------
Attachment: FileUserManagerConfigTest.patch
> Build test fails under Windows XP
> ---------------------------------
>
> Key: FTPSERVER-175
> URL: https://issues.apache.org/jira/browse/FTPSERVER-175
> Project: FtpServer
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0-M4
> Environment: Windows XP, Sun JDK 1.6.0_03
> Reporter: Robin Windels
> Priority: Minor
> Attachments: FileUserManagerConfigTest.patch
>
>
> excerpt from build log
> Failed tests:
> testFile(org.apache.ftpserver.config.spring.FileUserManagerConfigTest)
> Tests run: 571, Failures: 1, Errors: 0, Skipped: 0
> Excerpt from Test set: org.apache.ftpserver.config.spring.FileUserManagerConfigTest
> junit.framework.ComparisonFailure: expected:<[/tmp/]foo.users> but was:<[C:\tmp\]foo.users>
> Patch that works for me:
> Index: FileUserManagerConfigTest.java
> ===================================================================
> --- FileUserManagerConfigTest.java (revision 693655)
> +++ FileUserManagerConfigTest.java (working copy)
> @@ -41,7 +41,7 @@
>
> public void testFile() throws Throwable {
> PropertiesUserManager um = createPropertiesUserManager("<file-user-manager file=\"/tmp/foo.users\" />");
> - assertEquals("/tmp/foo.users", um.getFile().getAbsolutePath());
> + assertEquals("/tmp/foo.users".replace('/', um.getFile().separatorChar), um.getFile().getPath());
> }
>
> public void testMd5PasswordEncryptor() throws Throwable {
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FTPSERVER-175) Build test fails under Windows XP
Posted by "Robin Windels (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630088#action_12630088 ]
Robin Windels commented on FTPSERVER-175:
-----------------------------------------
confirmed
build is successful
thanks
On Wed, Sep 10, 2008 at 2:07 PM, Niklas Gustavsson (JIRA)
> Build test fails under Windows XP
> ---------------------------------
>
> Key: FTPSERVER-175
> URL: https://issues.apache.org/jira/browse/FTPSERVER-175
> Project: FtpServer
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0-M4
> Environment: Windows XP, Sun JDK 1.6.0_03
> Reporter: Robin Windels
> Assignee: Niklas Gustavsson
> Priority: Minor
> Fix For: 1.0-M4
>
> Attachments: FileUserManagerConfigTest.patch
>
>
> excerpt from build log
> Failed tests:
> testFile(org.apache.ftpserver.config.spring.FileUserManagerConfigTest)
> Tests run: 571, Failures: 1, Errors: 0, Skipped: 0
> Excerpt from Test set: org.apache.ftpserver.config.spring.FileUserManagerConfigTest
> junit.framework.ComparisonFailure: expected:<[/tmp/]foo.users> but was:<[C:\tmp\]foo.users>
> Patch that works for me:
> Index: FileUserManagerConfigTest.java
> ===================================================================
> --- FileUserManagerConfigTest.java (revision 693655)
> +++ FileUserManagerConfigTest.java (working copy)
> @@ -41,7 +41,7 @@
>
> public void testFile() throws Throwable {
> PropertiesUserManager um = createPropertiesUserManager("<file-user-manager file=\"/tmp/foo.users\" />");
> - assertEquals("/tmp/foo.users", um.getFile().getAbsolutePath());
> + assertEquals("/tmp/foo.users".replace('/', um.getFile().separatorChar), um.getFile().getPath());
> }
>
> public void testMd5PasswordEncryptor() throws Throwable {
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FTPSERVER-175) Build test fails under Windows XP
Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niklas Gustavsson closed FTPSERVER-175.
---------------------------------------
Resolution: Fixed
Fix Version/s: 1.0-M4
Assignee: Niklas Gustavsson
Fixed, please verify as I don't have a Windows box available
svn commit "/media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/config/spring/FileUserManagerConfigTest.java" -m "Fixing test broken on WIndows (FTPSERVER-175 & FTPSERVER-176). Thanks goes out to David Latorre and Robin Windels." --username "ngn"
M /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/config/spring/FileUserManagerConfigTest.java
Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/config/spring/FileUserManagerConfigTest.java
Committed revision 693979
> Build test fails under Windows XP
> ---------------------------------
>
> Key: FTPSERVER-175
> URL: https://issues.apache.org/jira/browse/FTPSERVER-175
> Project: FtpServer
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0-M4
> Environment: Windows XP, Sun JDK 1.6.0_03
> Reporter: Robin Windels
> Assignee: Niklas Gustavsson
> Priority: Minor
> Fix For: 1.0-M4
>
> Attachments: FileUserManagerConfigTest.patch
>
>
> excerpt from build log
> Failed tests:
> testFile(org.apache.ftpserver.config.spring.FileUserManagerConfigTest)
> Tests run: 571, Failures: 1, Errors: 0, Skipped: 0
> Excerpt from Test set: org.apache.ftpserver.config.spring.FileUserManagerConfigTest
> junit.framework.ComparisonFailure: expected:<[/tmp/]foo.users> but was:<[C:\tmp\]foo.users>
> Patch that works for me:
> Index: FileUserManagerConfigTest.java
> ===================================================================
> --- FileUserManagerConfigTest.java (revision 693655)
> +++ FileUserManagerConfigTest.java (working copy)
> @@ -41,7 +41,7 @@
>
> public void testFile() throws Throwable {
> PropertiesUserManager um = createPropertiesUserManager("<file-user-manager file=\"/tmp/foo.users\" />");
> - assertEquals("/tmp/foo.users", um.getFile().getAbsolutePath());
> + assertEquals("/tmp/foo.users".replace('/', um.getFile().separatorChar), um.getFile().getPath());
> }
>
> public void testMd5PasswordEncryptor() throws Throwable {
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.