You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "fishy (via GitHub)" <gi...@apache.org> on 2023/06/23 16:31:15 UTC
[GitHub] [thrift] fishy opened a new pull request, #2821: Update supported go versions to 1.20 and 1.21
fishy opened a new pull request, #2821:
URL: https://github.com/apache/thrift/pull/2821
Getting the PR ready to be merged once go 1.21 releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] fishy commented on a diff in pull request #2821: Update supported go versions to 1.20 and 1.21
Posted by "fishy (via GitHub)" <gi...@apache.org>.
fishy commented on code in PR #2821:
URL: https://github.com/apache/thrift/pull/2821#discussion_r1240019866
##########
LANGUAGES.md:
##########
@@ -163,7 +163,7 @@ Thrift's core protocol is TBinary, supported by all languages except for JavaScr
<td align=left><a href="https://github.com/apache/thrift/blob/master/lib/go/README.md">Go</a></td>
<!-- Since -----------------><td>0.7.0</td>
<!-- Build Systems ---------><td><img src="/doc/images/cgrn.png" alt="Yes"/></td><td><img src="/doc/images/cred.png" alt=""/></td>
-<!-- Language Levels -------><td>1.19.5</td><td>1.20</td>
+<!-- Language Levels -------><td>1.20</td><td>1.21</td>
Review Comment:
note that I removed patch version here because now with github actions we are always using the latest patch version under the minor version in tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] fishy commented on pull request #2821: Update supported go versions to 1.20 and 1.21
Posted by "fishy (via GitHub)" <gi...@apache.org>.
fishy commented on PR #2821:
URL: https://github.com/apache/thrift/pull/2821#issuecomment-1670106334
The crosstest failures between java/kotlin and go are due to https://issues.apache.org/jira/browse/THRIFT-5653. merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] fishy merged pull request #2821: Update supported go versions to 1.20 and 1.21
Posted by "fishy (via GitHub)" <gi...@apache.org>.
fishy merged PR #2821:
URL: https://github.com/apache/thrift/pull/2821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] fishy commented on pull request #2821: Update supported go versions to 1.20 and 1.21
Posted by "fishy (via GitHub)" <gi...@apache.org>.
fishy commented on PR #2821:
URL: https://github.com/apache/thrift/pull/2821#issuecomment-1670067853
@dcelasun now 1.21 is released, I fixed the TODO in workflow file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org