You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/04 20:49:00 UTC

[jira] [Commented] (BEAM-2725) remove nullFields in BeamRecord

    [ https://issues.apache.org/jira/browse/BEAM-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114955#comment-16114955 ] 

ASF GitHub Bot commented on BEAM-2725:
--------------------------------------

GitHub user XuMingmin opened a pull request:

    https://github.com/apache/beam/pull/3691

    [BEAM-2725] remove nullFields in BeamRecord

    R: @robertwb 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/XuMingmin/beam BEAM-2725

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3691.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3691
    
----
commit a9eb603ff630fe91de61696d553dcdd871291737
Author: mingmxu <mi...@ebay.com>
Date:   2017-08-04T20:46:10Z

    remove nullFields in BeamRecord

----


> remove nullFields in BeamRecord
> -------------------------------
>
>                 Key: BEAM-2725
>                 URL: https://issues.apache.org/jira/browse/BEAM-2725
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql
>            Reporter: Xu Mingmin
>            Assignee: Xu Mingmin
>              Labels: dsl_sql_merge
>
> As {{nullFields}} is only used when encoding/decoding, it's better to calculate it on the fly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)