You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by GitBox <gi...@apache.org> on 2022/07/29 12:23:55 UTC
[GitHub] [mina-sshd] norrisjeremy opened a new pull request, #235: [SSHD-1285] Fix runtime linkage errors with Java 8 when building with…
norrisjeremy opened a new pull request, #235:
URL: https://github.com/apache/mina-sshd/pull/235
… Java versions > 8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] norrisjeremy commented on pull request #235: [SSHD-1285] Fix runtime linkage errors with Java 8 when building with…
Posted by GitBox <gi...@apache.org>.
norrisjeremy commented on PR #235:
URL: https://github.com/apache/mina-sshd/pull/235#issuecomment-1203632844
The `pom.xml` for this project already has the following, so it seems more consistent to do it the way I proposed:
```
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.8.1</version>
<configuration>
<source>${javac.source}</source>
<target>${javac.target}</target>
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] elecharny commented on pull request #235: [SSHD-1285] Fix runtime linkage errors with Java 8 when building with…
Posted by GitBox <gi...@apache.org>.
elecharny commented on PR #235:
URL: https://github.com/apache/mina-sshd/pull/235#issuecomment-1203567816
Hi,
I think this can also be done with just a property, like what we have in MINA:
```
<!-- use JDK8 compilation for JDK9+ compiler -->
<profile>
<id>java-8-compilation</id>
<activation>
<jdk>[9,)</jdk>
</activation>
<properties>
<maven.compiler.release>8</maven.compiler.release>
</properties>
</profile>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] tomaswolf merged pull request #235: [SSHD-1285] Fix runtime linkage errors with Java 8 when building with…
Posted by GitBox <gi...@apache.org>.
tomaswolf merged PR #235:
URL: https://github.com/apache/mina-sshd/pull/235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org