You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@atlas.apache.org by Jyoti Singh <sj...@gmail.com> on 2020/07/02 01:30:10 UTC

Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/
-----------------------------------------------------------

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.

Bugs: ATLAS-3875
https://issues.apache.org/jira/browse/ATLAS-3875

Repository: atlas

Description
-------

There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints.

1. TypeRest
2. EntityRest
3. LineageRest
4. DiscoveryRest
5. GlossaryRest
6. RelationshipRest

This will enable users to test and integrate with APIs more effectively via AtlasCient.

Diffs
-----

client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3
webapp/pom.xml 3c55b4dd4
webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d
webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892
webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615
webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47

Diff: https://reviews.apache.org/r/72638/diff/1/

Testing
-------

IT has been added for newly created functions in AtlasClientV2.
Validated by running IT on local system.

Thanks,

Jyoti Singh

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

Posted by Sidharth Mishra <si...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/#review221214
-----------------------------------------------------------




client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java
Lines 84 (patched)
<https://reviews.apache.org/r/72638/#comment310038>

    Please remove one extra space added before String



client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java
Lines 107 (patched)
<https://reviews.apache.org/r/72638/#comment310039>

    We don't have any v2 API at AtlasBaseClient. Could you please move this to AtlasClientV2.



client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java
Lines 489 (patched)
<https://reviews.apache.org/r/72638/#comment310040>

    Please move this as well to v2 as this is the base client.


- Sidharth Mishra


On July 10, 2020, 12:05 a.m., Jyoti Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72638/
> -----------------------------------------------------------
> 
> (Updated July 10, 2020, 12:05 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3875
>     https://issues.apache.org/jira/browse/ATLAS-3875
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints.
> 
> 1. TypeRest
> 2. EntityRest
> 3. LineageRest
> 4. DiscoveryRest
> 5. GlossaryRest
> 6. RelationshipRest
> 
> This will enable users to test and integrate with APIs more effectively via AtlasCient.
> 
> 
> Diffs
> -----
> 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 
>   client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 
>   webapp/pom.xml 3c55b4dd4 
>   webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
>   webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 
>   webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 
>   webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 
>   webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 
>   webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72638/diff/4/
> 
> 
> Testing
> -------
> 
> IT has been added for newly created functions in AtlasClientV2.
> Validated by running IT on local system.
> 
> 
> Thanks,
> 
> Jyoti Singh
> 
>

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

Posted by Sidharth Mishra <si...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/#review221213
-----------------------------------------------------------




client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Line 40 (original), 57 (patched)
<https://reviews.apache.org/r/72638/#comment310029>

    Please remove this one as its already imported above



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 103 (patched)
<https://reviews.apache.org/r/72638/#comment310030>

    Please maintain the above alignment.



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 112 (patched)
<https://reviews.apache.org/r/72638/#comment310032>

    Align below lines like:
    
    //Glossary APIs
        private static final String GLOSSARY_URI        = BASE_URI + "v2/glossary";
        private static final String GLOSSARY_TERM       = GLOSSARY_URI + "/term";
        private static final String GLOSSARY_TERMS      = GLOSSARY_URI + "/terms";
        private static final String GLOSSARY_CATEGORY   = GLOSSARY_URI + "/category";
        private static final String GLOSSARY_CATEGORIES = GLOSSARY_URI + "/categories";



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 118 (patched)
<https://reviews.apache.org/r/72638/#comment310031>

    Please have one blank line instead of two



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 220 (patched)
<https://reviews.apache.org/r/72638/#comment310033>

    Please rename getRelationShipDefByName -> getRelationshipDefByName (As RelationShip is a single word)



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 224 (patched)
<https://reviews.apache.org/r/72638/#comment310034>

    getRelationShipDefByGuid -> getRelationshipDefByGuid



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 597 (patched)
<https://reviews.apache.org/r/72638/#comment310035>

    Please remove these two extra blank lines



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 648 (patched)
<https://reviews.apache.org/r/72638/#comment310037>

    Please remove the below lines as it seems its not bMultivaluedMap<String, String> queryParams = new MultivaluedMapImpl();
                   queryParams.add("name", name);



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 650 (patched)
<https://reviews.apache.org/r/72638/#comment310036>

    Please remove the commented line


- Sidharth Mishra


On July 10, 2020, 12:05 a.m., Jyoti Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72638/
> -----------------------------------------------------------
> 
> (Updated July 10, 2020, 12:05 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3875
>     https://issues.apache.org/jira/browse/ATLAS-3875
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints.
> 
> 1. TypeRest
> 2. EntityRest
> 3. LineageRest
> 4. DiscoveryRest
> 5. GlossaryRest
> 6. RelationshipRest
> 
> This will enable users to test and integrate with APIs more effectively via AtlasCient.
> 
> 
> Diffs
> -----
> 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 
>   client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 
>   webapp/pom.xml 3c55b4dd4 
>   webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
>   webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 
>   webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 
>   webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 
>   webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 
>   webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72638/diff/4/
> 
> 
> Testing
> -------
> 
> IT has been added for newly created functions in AtlasClientV2.
> Validated by running IT on local system.
> 
> 
> Thanks,
> 
> Jyoti Singh
> 
>

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

Posted by Madhan Neethiraj <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/#review221258
-----------------------------------------------------------




client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 472 (patched)
<https://reviews.apache.org/r/72638/#comment310114>

    - please remove 'final' for method parameters
    - partialUpdateEntityAttrByGuid() => partialUpdateEntityByGuid()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 490 (patched)
<https://reviews.apache.org/r/72638/#comment310115>

    removeEntityClassifications() => removeEntityClassification()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 495 (patched)
<https://reviews.apache.org/r/72638/#comment310116>

    deleteClassificationByGuid() => removeEntityClassification()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 539 (patched)
<https://reviews.apache.org/r/72638/#comment310117>

    importBMAttributes() => bulkUpdateBusinessAttributes()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 547 (patched)
<https://reviews.apache.org/r/72638/#comment310118>

    entityGuid => typeName? Please review and update.



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 551 (patched)
<https://reviews.apache.org/r/72638/#comment310119>

    entityGuid => typeName? Please review and update.



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 556 (patched)
<https://reviews.apache.org/r/72638/#comment310120>

    exportDataForEntity() => getTemplateForBulkUpdateBusinessAttributes()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 562 (patched)
<https://reviews.apache.org/r/72638/#comment310121>

    Please remove 'final' from method parameters - line #562, #570.



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 629 (patched)
<https://reviews.apache.org/r/72638/#comment310122>

    For consistency with other methods, I suggest to reorder the parameters:
     - typeName, attrName, attrValuePrefix, limit, offset



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 775 (patched)
<https://reviews.apache.org/r/72638/#comment310123>

    - please remove 'atlas' prefix from variable names
       atlasGlossary => glossary
    - please make sure to leave a space before '{'; here and rest of the patch



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 831 (patched)
<https://reviews.apache.org/r/72638/#comment310124>

    sort => sortByAttribute
     - lines #831, #842, #853, #863, #873, #884, #894



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 936 (patched)
<https://reviews.apache.org/r/72638/#comment310125>

    importFileData() => importGlossary()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 953 (patched)
<https://reviews.apache.org/r/72638/#comment310126>

    importData() => importGlossary()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 958 (patched)
<https://reviews.apache.org/r/72638/#comment310127>

    performImportData() => importGlossary()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 972 (patched)
<https://reviews.apache.org/r/72638/#comment310128>

    getTemplateByStream() => readStreamContents()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 1175 (patched)
<https://reviews.apache.org/r/72638/#comment310130>

    GET_TEMPLATE => GET_IMPORT_GLOSSARY_TEMPLATE



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 1176 (patched)
<https://reviews.apache.org/r/72638/#comment310129>

    IMPORT_DATA => IMPORT_GLOSSARY



client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java
Lines 685 (patched)
<https://reviews.apache.org/r/72638/#comment310131>

    - hardcoded path "/src/test/resources/" doesn't look right. is this a temp location? or is the user expected have contents under this directory?
    - if this is needed only for testing, consider moving this to test code.


- Madhan Neethiraj


On July 16, 2020, 3:17 a.m., Jyoti Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72638/
> -----------------------------------------------------------
> 
> (Updated July 16, 2020, 3:17 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3875
>     https://issues.apache.org/jira/browse/ATLAS-3875
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints.
> 
> 1. TypeRest
> 2. EntityRest
> 3. LineageRest
> 4. DiscoveryRest
> 5. GlossaryRest
> 6. RelationshipRest
> 
> This will enable users to test and integrate with APIs more effectively via AtlasCient.
> 
> 
> Diffs
> -----
> 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 
>   client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 
>   webapp/pom.xml 3c55b4dd4 
>   webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
>   webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 
>   webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 
>   webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 
>   webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 
>   webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72638/diff/5/
> 
> 
> Testing
> -------
> 
> IT has been added for newly created functions in AtlasClientV2.
> Validated by running IT on local system.
> 
> 
> Thanks,
> 
> Jyoti Singh
> 
>

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

Posted by Jyoti Singh <sj...@gmail.com>.


> On July 16, 2020, 7 a.m., Sarath Subramanian wrote:
> > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
> > Lines 543 (patched)
> > <https://reviews.apache.org/r/72638/diff/5/?file=2235884#file2235884line562>
> >
> >     setLabels => setLabelsByUniqueAttributes
> >     addLabels => addLabelsByUniqueAttributes
> >     removeLabels => removeLabelsByUniqueAttributes

I have renamed it from setLabelsByTypeName() => setLabels() as comments given by Madhan


- Jyoti


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/#review221235
-----------------------------------------------------------


On July 16, 2020, 3:17 a.m., Jyoti Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72638/
> -----------------------------------------------------------
> 
> (Updated July 16, 2020, 3:17 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3875
>     https://issues.apache.org/jira/browse/ATLAS-3875
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints.
> 
> 1. TypeRest
> 2. EntityRest
> 3. LineageRest
> 4. DiscoveryRest
> 5. GlossaryRest
> 6. RelationshipRest
> 
> This will enable users to test and integrate with APIs more effectively via AtlasCient.
> 
> 
> Diffs
> -----
> 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 
>   client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 
>   webapp/pom.xml 3c55b4dd4 
>   webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
>   webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 
>   webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 
>   webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 
>   webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 
>   webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72638/diff/5/
> 
> 
> Testing
> -------
> 
> IT has been added for newly created functions in AtlasClientV2.
> Validated by running IT on local system.
> 
> 
> Thanks,
> 
> Jyoti Singh
> 
>

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

Posted by Jyoti Singh <sj...@gmail.com>.


> On July 16, 2020, 7 a.m., Sarath Subramanian wrote:
> > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
> > Lines 570 (patched)
> > <https://reviews.apache.org/r/72638/diff/5/?file=2235884#file2235884line589>
> >
> >     getLineageInfo => getLineageInfoByUniqueAttributes

This is an existing method.


- Jyoti


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/#review221235
-----------------------------------------------------------


On July 16, 2020, 3:17 a.m., Jyoti Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72638/
> -----------------------------------------------------------
> 
> (Updated July 16, 2020, 3:17 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3875
>     https://issues.apache.org/jira/browse/ATLAS-3875
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints.
> 
> 1. TypeRest
> 2. EntityRest
> 3. LineageRest
> 4. DiscoveryRest
> 5. GlossaryRest
> 6. RelationshipRest
> 
> This will enable users to test and integrate with APIs more effectively via AtlasCient.
> 
> 
> Diffs
> -----
> 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 
>   client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 
>   webapp/pom.xml 3c55b4dd4 
>   webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
>   webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 
>   webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 
>   webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 
>   webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 
>   webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72638/diff/5/
> 
> 
> Testing
> -------
> 
> IT has been added for newly created functions in AtlasClientV2.
> Validated by running IT on local system.
> 
> 
> Thanks,
> 
> Jyoti Singh
> 
>

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

Posted by Jyoti Singh <sj...@gmail.com>.


> On July 16, 2020, 7 a.m., Sarath Subramanian wrote:
> > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
> > Lines 525 (patched)
> > <https://reviews.apache.org/r/72638/diff/5/?file=2235884#file2235884line544>
> >
> >     removeBusinessAttributes => removeBusinessAttributesByName

I have renamed it to removeBusinessAttributes as suggested by Madhan


- Jyoti


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/#review221235
-----------------------------------------------------------


On July 16, 2020, 3:17 a.m., Jyoti Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72638/
> -----------------------------------------------------------
> 
> (Updated July 16, 2020, 3:17 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3875
>     https://issues.apache.org/jira/browse/ATLAS-3875
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints.
> 
> 1. TypeRest
> 2. EntityRest
> 3. LineageRest
> 4. DiscoveryRest
> 5. GlossaryRest
> 6. RelationshipRest
> 
> This will enable users to test and integrate with APIs more effectively via AtlasCient.
> 
> 
> Diffs
> -----
> 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 
>   client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 
>   webapp/pom.xml 3c55b4dd4 
>   webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
>   webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 
>   webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 
>   webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 
>   webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 
>   webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72638/diff/5/
> 
> 
> Testing
> -------
> 
> IT has been added for newly created functions in AtlasClientV2.
> Validated by running IT on local system.
> 
> 
> Thanks,
> 
> Jyoti Singh
> 
>

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

Posted by Jyoti Singh <sj...@gmail.com>.


> On July 16, 2020, 7 a.m., Sarath Subramanian wrote:
> > client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java
> > Lines 685 (patched)
> > <https://reviews.apache.org/r/72638/diff/5/?file=2235885#file2235885line687>
> >
> >     this method is not used anywhere. review and revert  if not needed.

Using it in AtlasClient


- Jyoti


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/#review221235
-----------------------------------------------------------


On July 16, 2020, 3:17 a.m., Jyoti Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72638/
> -----------------------------------------------------------
> 
> (Updated July 16, 2020, 3:17 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3875
>     https://issues.apache.org/jira/browse/ATLAS-3875
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints.
> 
> 1. TypeRest
> 2. EntityRest
> 3. LineageRest
> 4. DiscoveryRest
> 5. GlossaryRest
> 6. RelationshipRest
> 
> This will enable users to test and integrate with APIs more effectively via AtlasCient.
> 
> 
> Diffs
> -----
> 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 
>   client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 
>   webapp/pom.xml 3c55b4dd4 
>   webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
>   webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 
>   webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 
>   webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 
>   webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 
>   webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72638/diff/5/
> 
> 
> Testing
> -------
> 
> IT has been added for newly created functions in AtlasClientV2.
> Validated by running IT on local system.
> 
> 
> Thanks,
> 
> Jyoti Singh
> 
>

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

Posted by Sarath Subramanian <sa...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/#review221235
-----------------------------------------------------------




client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 117 (patched)
<https://reviews.apache.org/r/72638/#comment310069>

    SAVED_URI => SAVED_SEARCH_URI



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 118 (patched)
<https://reviews.apache.org/r/72638/#comment310070>

    QUICK_URI => QUICK_SEARCH_URI



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 132 (patched)
<https://reviews.apache.org/r/72638/#comment310071>

    nit: typo in 'relateed'



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 244 (patched)
<https://reviews.apache.org/r/72638/#comment310072>

    nit: remove additional newline



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 250 (patched)
<https://reviews.apache.org/r/72638/#comment310073>

    getBusinessMetadataDefGuid => getBusinessMetadataDefByGuid



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 525 (patched)
<https://reviews.apache.org/r/72638/#comment310074>

    removeBusinessAttributes => removeBusinessAttributesByName



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 543 (patched)
<https://reviews.apache.org/r/72638/#comment310075>

    setLabels => setLabelsByUniqueAttributes
    addLabels => addLabelsByUniqueAttributes
    removeLabels => removeLabelsByUniqueAttributes



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 570 (patched)
<https://reviews.apache.org/r/72638/#comment310076>

    getLineageInfo => getLineageInfoByUniqueAttributes



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 683 (patched)
<https://reviews.apache.org/r/72638/#comment310077>

    nit: additional space after 'void'



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 687 (patched)
<https://reviews.apache.org/r/72638/#comment310078>

    nit: additional space after 'AtlasSearchResult'



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 693 (patched)
<https://reviews.apache.org/r/72638/#comment310079>

    nit: additional space after 'AtlasSearchResult'



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 937 (patched)
<https://reviews.apache.org/r/72638/#comment310080>

    nit: fix alignment line 937-940



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 1073 (patched)
<https://reviews.apache.org/r/72638/#comment310082>

    DELETE_TYPE_BY_NAME => DELETE_TYPE_DEF_BY_NAME



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 1095 (patched)
<https://reviews.apache.org/r/72638/#comment310083>

    nit: fix alignment from line 1095-1114



client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java
Lines 685 (patched)
<https://reviews.apache.org/r/72638/#comment310068>

    this method is not used anywhere. review and revert  if not needed.



webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java
Lines 579 (patched)
<https://reviews.apache.org/r/72638/#comment310084>

    nit: remove additional new line



webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java
Lines 608 (patched)
<https://reviews.apache.org/r/72638/#comment310085>

    nit: remove additional new line


- Sarath Subramanian


On July 15, 2020, 8:17 p.m., Jyoti Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72638/
> -----------------------------------------------------------
> 
> (Updated July 15, 2020, 8:17 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3875
>     https://issues.apache.org/jira/browse/ATLAS-3875
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints.
> 
> 1. TypeRest
> 2. EntityRest
> 3. LineageRest
> 4. DiscoveryRest
> 5. GlossaryRest
> 6. RelationshipRest
> 
> This will enable users to test and integrate with APIs more effectively via AtlasCient.
> 
> 
> Diffs
> -----
> 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 
>   client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 
>   webapp/pom.xml 3c55b4dd4 
>   webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
>   webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 
>   webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 
>   webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 
>   webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 
>   webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72638/diff/5/
> 
> 
> Testing
> -------
> 
> IT has been added for newly created functions in AtlasClientV2.
> Validated by running IT on local system.
> 
> 
> Thanks,
> 
> Jyoti Singh
> 
>

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

Posted by Madhan Neethiraj <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/#review221263
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On July 19, 2020, 9:12 p.m., Jyoti Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72638/
> -----------------------------------------------------------
> 
> (Updated July 19, 2020, 9:12 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3875
>     https://issues.apache.org/jira/browse/ATLAS-3875
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints.
> 
> 1. TypeRest
> 2. EntityRest
> 3. LineageRest
> 4. DiscoveryRest
> 5. GlossaryRest
> 6. RelationshipRest
> 
> This will enable users to test and integrate with APIs more effectively via AtlasCient.
> 
> 
> Diffs
> -----
> 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 
>   client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 
>   webapp/pom.xml 3c55b4dd4 
>   webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
>   webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 
>   webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 
>   webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 
>   webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 
>   webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION 
>   webapp/src/test/resources/template.csv PRE-CREATION 
>   webapp/src/test/resources/template_metadata.csv PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72638/diff/8/
> 
> 
> Testing
> -------
> 
> IT has been added for newly created functions in AtlasClientV2.
> Validated by running IT on local system.
> 
> 
> Thanks,
> 
> Jyoti Singh
> 
>

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

Posted by Jyoti Singh <sj...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/
-----------------------------------------------------------

(Updated July 19, 2020, 9:12 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.


Changes
-------

Adding code review related change


Bugs: ATLAS-3875
    https://issues.apache.org/jira/browse/ATLAS-3875


Repository: atlas


Description
-------

There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints.

1. TypeRest
2. EntityRest
3. LineageRest
4. DiscoveryRest
5. GlossaryRest
6. RelationshipRest

This will enable users to test and integrate with APIs more effectively via AtlasCient.


Diffs (updated)
-----

  client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 
  client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 
  webapp/pom.xml 3c55b4dd4 
  webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 
  webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 
  webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 
  webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 
  webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION 
  webapp/src/test/resources/template.csv PRE-CREATION 
  webapp/src/test/resources/template_metadata.csv PRE-CREATION 


Diff: https://reviews.apache.org/r/72638/diff/8/

Changes: https://reviews.apache.org/r/72638/diff/7-8/


Testing
-------

IT has been added for newly created functions in AtlasClientV2.
Validated by running IT on local system.


Thanks,

Jyoti Singh

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

Posted by Jyoti Singh <sj...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/
-----------------------------------------------------------

(Updated July 17, 2020, 11:20 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.


Changes
-------

Adding code review related change


Bugs: ATLAS-3875
    https://issues.apache.org/jira/browse/ATLAS-3875


Repository: atlas


Description
-------

There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints.

1. TypeRest
2. EntityRest
3. LineageRest
4. DiscoveryRest
5. GlossaryRest
6. RelationshipRest

This will enable users to test and integrate with APIs more effectively via AtlasCient.


Diffs (updated)
-----

  client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 
  client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 
  webapp/pom.xml 3c55b4dd4 
  webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 
  webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 
  webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 
  webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 
  webapp/src/test/resources/csvFiles/template.csv PRE-CREATION 
  webapp/src/test/resources/csvFiles/template_metadata.csv PRE-CREATION 
  webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION 


Diff: https://reviews.apache.org/r/72638/diff/7/

Changes: https://reviews.apache.org/r/72638/diff/6-7/


Testing
-------

IT has been added for newly created functions in AtlasClientV2.
Validated by running IT on local system.


Thanks,

Jyoti Singh

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

Posted by Jyoti Singh <sj...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/
-----------------------------------------------------------

(Updated July 17, 2020, 10:27 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.


Changes
-------

Adding code review related change


Bugs: ATLAS-3875
    https://issues.apache.org/jira/browse/ATLAS-3875


Repository: atlas


Description
-------

There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints.

1. TypeRest
2. EntityRest
3. LineageRest
4. DiscoveryRest
5. GlossaryRest
6. RelationshipRest

This will enable users to test and integrate with APIs more effectively via AtlasCient.


Diffs (updated)
-----

  client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 
  client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 
  webapp/pom.xml 3c55b4dd4 
  webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 
  webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 
  webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 
  webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 
  webapp/src/test/resources/csvFiles/template.csv PRE-CREATION 
  webapp/src/test/resources/csvFiles/template_metadata.csv PRE-CREATION 
  webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION 


Diff: https://reviews.apache.org/r/72638/diff/6/

Changes: https://reviews.apache.org/r/72638/diff/5-6/


Testing
-------

IT has been added for newly created functions in AtlasClientV2.
Validated by running IT on local system.


Thanks,

Jyoti Singh

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

Posted by Jyoti Singh <sj...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/
-----------------------------------------------------------

(Updated July 16, 2020, 3:17 a.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.


Changes
-------

Addressing review comments related change


Bugs: ATLAS-3875
    https://issues.apache.org/jira/browse/ATLAS-3875


Repository: atlas


Description
-------

There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints.

1. TypeRest
2. EntityRest
3. LineageRest
4. DiscoveryRest
5. GlossaryRest
6. RelationshipRest

This will enable users to test and integrate with APIs more effectively via AtlasCient.


Diffs (updated)
-----

  client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 
  client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 
  webapp/pom.xml 3c55b4dd4 
  webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 
  webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 
  webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 
  webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 
  webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION 


Diff: https://reviews.apache.org/r/72638/diff/5/

Changes: https://reviews.apache.org/r/72638/diff/4-5/


Testing
-------

IT has been added for newly created functions in AtlasClientV2.
Validated by running IT on local system.


Thanks,

Jyoti Singh

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

Posted by Madhan Neethiraj <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/#review221212
-----------------------------------------------------------




client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 220 (patched)
<https://reviews.apache.org/r/72638/#comment309992>

    Use of 'final' for method parameters are not of much help - especially for simple/short methods of this class. I suggest to remove 'final' from all method parameters - one less distraction in the code!



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Line 274 (original), 316 (patched)
<https://reviews.apache.org/r/72638/#comment309991>

    getLineageInfo(): renaming existing method would break current callers. I suggest to retain the current method name.



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 630 (patched)
<https://reviews.apache.org/r/72638/#comment309993>

    Consider organizing the class as below:
    - static fields
    - public fields
    - protected fields
    - private fields
    - constructors
    - public static methods
    - public methods
    - protected methods
    - private methods
    - protected static methods
    - private static methods
    
    It makes reading the code a little easier.



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 631 (patched)
<https://reviews.apache.org/r/72638/#comment309995>

    Consider grouping methods in terms of functionality - like: type-defs, entity instances, search, admin, etc. It might be simper to group along the REST API the method calls.



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 634 (patched)
<https://reviews.apache.org/r/72638/#comment309994>

    - deleteAtlasTypeByName() => deleteTypeByName()
      - consider avoiding 'atlas' in method and variable names
    - name => typeName



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 638 (patched)
<https://reviews.apache.org/r/72638/#comment310002>

    guid => entityGuid
     - please review and update other such occurances



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 642 (patched)
<https://reviews.apache.org/r/72638/#comment310003>

    type => typeName
     - please review and update other occurances



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 647 (patched)
<https://reviews.apache.org/r/72638/#comment310004>

    name => attrName?



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 650 (patched)
<https://reviews.apache.org/r/72638/#comment309996>

    Consider removing this commented line.



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 654 (patched)
<https://reviews.apache.org/r/72638/#comment309997>

    getClassificationsByClassification() => getEntityClassifications()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 657 (patched)
<https://reviews.apache.org/r/72638/#comment310001>

    addClassificationsByUniqueAttribute() => addEntityClassifications()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 661 (patched)
<https://reviews.apache.org/r/72638/#comment310000>

    updateClassificationsByUniqueAttribute() => updateEntityClassifications()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 666 (patched)
<https://reviews.apache.org/r/72638/#comment309998>

    deleteClassificationByUniqueAttribute() => removeEntityClassification()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 671 (patched)
<https://reviews.apache.org/r/72638/#comment309999>

    deleteClassificationByGuid() => removeEntityClassification()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 698 (patched)
<https://reviews.apache.org/r/72638/#comment310005>

    addOrUpdateBusinessAttributesByBName() => addOrUpdateBusinessAttributes()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 701 (patched)
<https://reviews.apache.org/r/72638/#comment310006>

    removeBusinessAttributesByBName() => removeBusinessAttributes()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 711 (patched)
<https://reviews.apache.org/r/72638/#comment310010>

    deleteLabels() => removeLabels()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 715 (patched)
<https://reviews.apache.org/r/72638/#comment310007>

    - is fileDetail needed?
    - uploadedInputStream is not used?



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 719 (patched)
<https://reviews.apache.org/r/72638/#comment310008>

    - setLabelsByTypeName() => setLabels()
    - I suggest to reorder the arguments:
        typeName, uniqAttributes, labels



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 723 (patched)
<https://reviews.apache.org/r/72638/#comment310009>

    - addLabelsByTypeName() => addLabels()
    - I suggest to reorder the arguments:
        typeName, uniqAttributes, labels



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 727 (patched)
<https://reviews.apache.org/r/72638/#comment310011>

    - deleteLabelsByTypeName() => removeLabels()
    - I suggest to reorder the arguments:
        typeName, uniqAttributes, labels



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 751 (patched)
<https://reviews.apache.org/r/72638/#comment310012>

    if any of these parameters are optional, consider moving them towards end of the method; and add them to 'queryParams' only if they are not null.



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 780 (patched)
<https://reviews.apache.org/r/72638/#comment310013>

    - What value should be provided to fieldName? Consider adding a comment.
    - if this value can be null, update #783 only if the value is not null



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 792 (patched)
<https://reviews.apache.org/r/72638/#comment310014>

    - executeSavedSearchByName() => executeSavedSearch()
    - To be consistent with #774, please reorder the parameters:
      - userName, searchName



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 797 (patched)
<https://reviews.apache.org/r/72638/#comment310015>

    Make sure to leave a blank like before start of a method. Please review and update other occurances as well.



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 798 (patched)
<https://reviews.apache.org/r/72638/#comment310016>

    executeSavedSearchByGuid() => executeSavedSearch()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 801 (patched)
<https://reviews.apache.org/r/72638/#comment310017>

    getQuickSearch() => quickSearch()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 811 (patched)
<https://reviews.apache.org/r/72638/#comment310018>

    postQuickSearch() => quickSearch()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 828 (patched)
<https://reviews.apache.org/r/72638/#comment310019>

    getDetailGlossary() => getGlossaryExtInfo()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 864 (patched)
<https://reviews.apache.org/r/72638/#comment310020>

    partialUpdates => attributes



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 872 (patched)
<https://reviews.apache.org/r/72638/#comment310021>

    partialUpdates => attributes



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 880 (patched)
<https://reviews.apache.org/r/72638/#comment310022>

    partialUpdates => attributes



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 907 (patched)
<https://reviews.apache.org/r/72638/#comment310023>

    getGlossaryTermHeadersByGuid() => getGlossaryTermHeaders()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 918 (patched)
<https://reviews.apache.org/r/72638/#comment310024>

    getGlossaryCategoriesByGuid() => getGlossaryCategories()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 928 (patched)
<https://reviews.apache.org/r/72638/#comment310025>

    getGlossaryCategoriesHeaders() => getGlossaryCategoryHeaders()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 979 (patched)
<https://reviews.apache.org/r/72638/#comment310026>

    disassociateTermAssignmentFromEntities() is a duplicate of removeTermAssignmentFromEntities() - looking at GlossaryREST.java. I suggest to remove method removeTermAssignmentFromEntities()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 992 (patched)
<https://reviews.apache.org/r/72638/#comment310027>

    - produceTemplate() => getGlossaryTemplate()
    - consider returning a string



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 996 (patched)
<https://reviews.apache.org/r/72638/#comment310028>

    - inputStream is not used?
    - what would callers send for fileDetail?
    - consider returning List<AtlasGlossaryTerm> - similar to GlossaryREST.importGlossaryData()


- Madhan Neethiraj


On July 10, 2020, 12:05 a.m., Jyoti Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72638/
> -----------------------------------------------------------
> 
> (Updated July 10, 2020, 12:05 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3875
>     https://issues.apache.org/jira/browse/ATLAS-3875
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints.
> 
> 1. TypeRest
> 2. EntityRest
> 3. LineageRest
> 4. DiscoveryRest
> 5. GlossaryRest
> 6. RelationshipRest
> 
> This will enable users to test and integrate with APIs more effectively via AtlasCient.
> 
> 
> Diffs
> -----
> 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 
>   client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 
>   webapp/pom.xml 3c55b4dd4 
>   webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
>   webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 
>   webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 
>   webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 
>   webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 
>   webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72638/diff/4/
> 
> 
> Testing
> -------
> 
> IT has been added for newly created functions in AtlasClientV2.
> Validated by running IT on local system.
> 
> 
> Thanks,
> 
> Jyoti Singh
> 
>

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

Posted by Sidharth Mishra <si...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/#review221215
-----------------------------------------------------------




webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java
Lines 38 (patched)
<https://reviews.apache.org/r/72638/#comment310041>

    Please remove unused imports.



webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java
Lines 52 (patched)
<https://reviews.apache.org/r/72638/#comment310042>

    Instead of import * use below:
    
    import static org.testng.Assert.assertNotNull;
    import static org.testng.Assert.fail;
    import static org.testng.Assert.assertNull;
    import static org.testng.Assert.assertEquals;


- Sidharth Mishra


On July 10, 2020, 12:05 a.m., Jyoti Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72638/
> -----------------------------------------------------------
> 
> (Updated July 10, 2020, 12:05 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3875
>     https://issues.apache.org/jira/browse/ATLAS-3875
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints.
> 
> 1. TypeRest
> 2. EntityRest
> 3. LineageRest
> 4. DiscoveryRest
> 5. GlossaryRest
> 6. RelationshipRest
> 
> This will enable users to test and integrate with APIs more effectively via AtlasCient.
> 
> 
> Diffs
> -----
> 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 
>   client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 
>   webapp/pom.xml 3c55b4dd4 
>   webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
>   webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 
>   webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 
>   webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 
>   webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 
>   webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72638/diff/4/
> 
> 
> Testing
> -------
> 
> IT has been added for newly created functions in AtlasClientV2.
> Validated by running IT on local system.
> 
> 
> Thanks,
> 
> Jyoti Singh
> 
>

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

Posted by Jyoti Singh <sj...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/
-----------------------------------------------------------

(Updated July 10, 2020, 12:05 a.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.


Bugs: ATLAS-3875
    https://issues.apache.org/jira/browse/ATLAS-3875


Repository: atlas


Description
-------

There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints.

1. TypeRest
2. EntityRest
3. LineageRest
4. DiscoveryRest
5. GlossaryRest
6. RelationshipRest

This will enable users to test and integrate with APIs more effectively via AtlasCient.


Diffs (updated)
-----

  client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 
  client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 
  webapp/pom.xml 3c55b4dd4 
  webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 
  webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 
  webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 
  webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 
  webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION 


Diff: https://reviews.apache.org/r/72638/diff/4/

Changes: https://reviews.apache.org/r/72638/diff/3-4/


Testing
-------

IT has been added for newly created functions in AtlasClientV2.
Validated by running IT on local system.


Thanks,

Jyoti Singh

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

Posted by Jyoti Singh <sj...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/
-----------------------------------------------------------

(Updated July 10, 2020, midnight)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.


Bugs: ATLAS-3875
    https://issues.apache.org/jira/browse/ATLAS-3875


Repository: atlas


Description
-------

There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints.

1. TypeRest
2. EntityRest
3. LineageRest
4. DiscoveryRest
5. GlossaryRest
6. RelationshipRest

This will enable users to test and integrate with APIs more effectively via AtlasCient.


Diffs (updated)
-----

  client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 
  client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 
  webapp/pom.xml 3c55b4dd4 
  webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 
  webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 
  webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 
  webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 
  webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION 


Diff: https://reviews.apache.org/r/72638/diff/3/

Changes: https://reviews.apache.org/r/72638/diff/2-3/


Testing
-------

IT has been added for newly created functions in AtlasClientV2.
Validated by running IT on local system.


Thanks,

Jyoti Singh

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/#review221139
-----------------------------------------------------------




client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Line 29 (original), 32 (patched)
<https://reviews.apache.org/r/72638/#comment309921>

    Avoid * instead of individual imports.



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Line 41 (original), 46 (patched)
<https://reviews.apache.org/r/72638/#comment309922>

    Avoid replacing individual imports with '*'.



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 707 (patched)
<https://reviews.apache.org/r/72638/#comment309923>

    Remove: TODO



webapp/pom.xml
Line 744 (original), 744 (patched)
<https://reviews.apache.org/r/72638/#comment309924>

    Avoid.



webapp/src/test/java/org/apache/atlas/web/TestUtils.java
Lines 60 (patched)
<https://reviews.apache.org/r/72638/#comment309925>

    Remove.



webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java
Line 95 (original), 96 (patched)
<https://reviews.apache.org/r/72638/#comment309926>

    Remove comment.



webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java
Lines 145 (patched)
<https://reviews.apache.org/r/72638/#comment309927>

    Remove comment.



webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java
Lines 31 (patched)
<https://reviews.apache.org/r/72638/#comment309929>

    Avoid.



webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java
Lines 46 (patched)
<https://reviews.apache.org/r/72638/#comment309928>

    Avoid.



webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java
Lines 31 (patched)
<https://reviews.apache.org/r/72638/#comment309930>

    Avoid.



webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java
Lines 92 (patched)
<https://reviews.apache.org/r/72638/#comment309931>

    Can you investigate loading JSONs instead of hand coding entities.


- Ashutosh Mestry


On July 6, 2020, 5:53 p.m., Jyoti Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72638/
> -----------------------------------------------------------
> 
> (Updated July 6, 2020, 5:53 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3875
>     https://issues.apache.org/jira/browse/ATLAS-3875
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints.
> 
> 1. TypeRest
> 2. EntityRest
> 3. LineageRest
> 4. DiscoveryRest
> 5. GlossaryRest
> 6. RelationshipRest
> 
> This will enable users to test and integrate with APIs more effectively via AtlasCient.
> 
> 
> Diffs
> -----
> 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 
>   webapp/pom.xml 3c55b4dd4 
>   webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
>   webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 
>   webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 
>   webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 
>   webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 
>   webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72638/diff/2/
> 
> 
> Testing
> -------
> 
> IT has been added for newly created functions in AtlasClientV2.
> Validated by running IT on local system.
> 
> 
> Thanks,
> 
> Jyoti Singh
> 
>

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

Posted by Jyoti Singh <sj...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/
-----------------------------------------------------------

(Updated July 6, 2020, 5:53 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.


Bugs: ATLAS-3875
    https://issues.apache.org/jira/browse/ATLAS-3875


Repository: atlas


Description
-------

There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints.

1. TypeRest
2. EntityRest
3. LineageRest
4. DiscoveryRest
5. GlossaryRest
6. RelationshipRest

This will enable users to test and integrate with APIs more effectively via AtlasCient.


Diffs (updated)
-----

  client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 
  webapp/pom.xml 3c55b4dd4 
  webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 
  webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 
  webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 
  webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 
  webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION 


Diff: https://reviews.apache.org/r/72638/diff/2/

Changes: https://reviews.apache.org/r/72638/diff/1-2/


Testing
-------

IT has been added for newly created functions in AtlasClientV2.
Validated by running IT on local system.


Thanks,

Jyoti Singh