You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@teaclave.apache.org by tianjia <no...@github.com> on 2020/06/08 08:57:32 UTC

[apache/incubator-teaclave-sgx-sdk] Fix a compile error (#245)

This patch fix following compile error.

signal.c:176:6: error: &#39;for&#39; loop initial declarations are only allowed in C99 mode
      for (int i = g_signal_dispatch-&gt;signal_to_eid_set-&gt;size - 1; i &gt;= 0; i--) {
You can view, comment on, or merge this pull request online at:

  https://github.com/apache/incubator-teaclave-sgx-sdk/pull/245

-- Commit Summary --

  * Fix a compile error

-- File Changes --

    M sgx_ustdc/signal.c (3)

-- Patch Links --

https://github.com/apache/incubator-teaclave-sgx-sdk/pull/245.patch
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/245.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/245

Re: [apache/incubator-teaclave-sgx-sdk] Fix a compile error (#245)

Posted by volcano <no...@github.com>.
@uudiin thanks!  @dingelish OK,  merge this PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/245#issuecomment-641009084

Re: [apache/incubator-teaclave-sgx-sdk] Fix a compile error (#245)

Posted by Qinkun Bao <no...@github.com>.
The minimum supported Ubuntu version of the SDK is 16.04. And I believe the default version of GCC for Ubuntu 16.04 should completely support C99. Is that right?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/245#issuecomment-640483492

Re: [apache/incubator-teaclave-sgx-sdk] Fix a compile error (#245)

Posted by Yu Ding <no...@github.com>.
lgtm. @volcano0dr ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/245#issuecomment-640909548

Re: [apache/incubator-teaclave-sgx-sdk] Fix a compile error (#245)

Posted by tianjia <no...@github.com>.
> 
> 
> The minimum supported Ubuntu version of the SDK is 16.04. And I believe the default version of GCC for Ubuntu 16.04 should completely support C99. Is that right?

Not using ubuntu environment, but GCC is indeed a lower version 4.8.5.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/245#issuecomment-640488625

Re: [apache/incubator-teaclave-sgx-sdk] Fix a compile error (#245)

Posted by Yu Ding <no...@github.com>.
Merged #245 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/245#event-3422888562