You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/05/16 13:12:20 UTC

[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2260: feat(core): Add trait and public API for `append`

Xuanwo commented on code in PR #2260:
URL: https://github.com/apache/incubator-opendal/pull/2260#discussion_r1195144781


##########
core/src/raw/oio/write.rs:
##########
@@ -178,3 +180,87 @@ impl<T: BlockingWrite + ?Sized> BlockingWrite for Box<T> {
         (**self).close()
     }
 }
+
+/// AppendOperation is the name for APIs of Append.
+#[derive(Debug, Copy, Clone, Hash, Eq, PartialEq)]
+#[non_exhaustive]
+pub enum AppendOperation {

Review Comment:
   LGTM.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org