[GitHub] Xeli commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

[GitBox <gi...@apache.org>]

Xeli commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)
URL: https://github.com/apache/flink/pull/6594#issuecomment-464045292
 
 
   Hi @rmetzger 
   
   We are still eager to get the code in the flink repository, especially trying to get it in 1.8 sounds really good.
   
   I am fine with putting some more effort into this as long as we can keep up the momentum and have a 1.8 release as the goal for now.
   
   Regarding your points:
   
   A) It would help us if you could make it clear which points I can improve (such as the exception logging comment) and which points are more of a design decision comment (source/sink vs subscription/publisher) and should not be changed just yet. I am fine with multiple review rounds as long as we keep the pace. :)
   B) I don't see too many problems here for now.
   C) We have done extensive tests using our own use-case as a base (a financial transaction processing system), so, for example, at-least-once guarantees under different failure scenarios has been tested quite extensively. And this PR also has some changes in existing code to make sure we handle rescaling and such properly. 
   
   All in all, I think we're on the same level, let's try to get this in 1.8 :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services