You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2025/10/06 20:04:58 UTC
[Impala-ASF-CR] IMPALA-14473: Fix absolute path logic for sorting scan ranges oldest to newest
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23495
Change subject: IMPALA-14473: Fix absolute path logic for sorting scan ranges oldest to newest
......................................................................
IMPALA-14473: Fix absolute path logic for sorting scan ranges oldest to newest
When IMPALA-14462 added tie-breaking logic to
ScanRangeOldestToNewestComparator, it relied on absolute path
being unset if the relative path is set. However, the code
always sets absolute path and uses an empty string to indicate
whether it is set. This caused the tie-breaking logic to see
two unrelated scan ranges as equal, triggering a DCHECK when
running query_test/test_tuple_cache_tpc_queries.py.
The fix is to rearrange the logic to check whether the relative
path is not empty rather than checking whether the absolute
path is set.
Testing:
- Ran query_test/test_tuple_cache_tpc_queries.py
- Ran custom_cluster/test_tuple_cache.py
Change-Id: I449308f4a0efdca7fc238e3dda24985a2931dd37
---
M be/src/scheduling/scheduler.cc
1 file changed, 16 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/23495/1
--
To view, visit http://gerrit.cloudera.org:8080/23495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I449308f4a0efdca7fc238e3dda24985a2931dd37
Gerrit-Change-Number: 23495
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14473: Fix absolute path logic for sorting scan ranges oldest to newest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23495 )
Change subject: IMPALA-14473: Fix absolute path logic for sorting scan ranges oldest to newest
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12542/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/23495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I449308f4a0efdca7fc238e3dda24985a2931dd37
Gerrit-Change-Number: 23495
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Oct 2025 21:57:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14473: Fix absolute path logic for sorting scan ranges oldest to newest
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23495 )
Change subject: IMPALA-14473: Fix absolute path logic for sorting scan ranges oldest to newest
......................................................................
Patch Set 1: Code-Review+2
I'm going to go ahead with this
--
To view, visit http://gerrit.cloudera.org:8080/23495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I449308f4a0efdca7fc238e3dda24985a2931dd37
Gerrit-Change-Number: 23495
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 07 Oct 2025 17:02:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14473: Fix absolute path logic for sorting scan ranges oldest to newest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23495 )
Change subject: IMPALA-14473: Fix absolute path logic for sorting scan ranges oldest to newest
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/23495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I449308f4a0efdca7fc238e3dda24985a2931dd37
Gerrit-Change-Number: 23495
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 07 Oct 2025 02:43:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14473: Fix absolute path logic for sorting scan ranges oldest to newest
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23495 )
Change subject: IMPALA-14473: Fix absolute path logic for sorting scan ranges oldest to newest
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/23495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I449308f4a0efdca7fc238e3dda24985a2931dd37
Gerrit-Change-Number: 23495
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Oct 2025 20:06:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14473: Fix absolute path logic for sorting scan ranges oldest to newest
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23495 )
Change subject: IMPALA-14473: Fix absolute path logic for sorting scan ranges oldest to newest
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/23495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I449308f4a0efdca7fc238e3dda24985a2931dd37
Gerrit-Change-Number: 23495
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 07 Oct 2025 16:46:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14473: Fix absolute path logic for sorting scan ranges oldest to newest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23495 )
Change subject: IMPALA-14473: Fix absolute path logic for sorting scan ranges oldest to newest
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/20624/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I449308f4a0efdca7fc238e3dda24985a2931dd37
Gerrit-Change-Number: 23495
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Oct 2025 20:32:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14473: Fix absolute path logic for sorting scan ranges oldest to newest
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23495 )
Change subject: IMPALA-14473: Fix absolute path logic for sorting scan ranges oldest to newest
......................................................................
IMPALA-14473: Fix absolute path logic for sorting scan ranges oldest to newest
When IMPALA-14462 added tie-breaking logic to
ScanRangeOldestToNewestComparator, it relied on absolute path
being unset if the relative path is set. However, the code
always sets absolute path and uses an empty string to indicate
whether it is set. This caused the tie-breaking logic to see
two unrelated scan ranges as equal, triggering a DCHECK when
running query_test/test_tuple_cache_tpc_queries.py.
The fix is to rearrange the logic to check whether the relative
path is not empty rather than checking whether the absolute
path is set.
Testing:
- Ran query_test/test_tuple_cache_tpc_queries.py
- Ran custom_cluster/test_tuple_cache.py
Change-Id: I449308f4a0efdca7fc238e3dda24985a2931dd37
Reviewed-on: http://gerrit.cloudera.org:8080/23495
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Yida Wu <wy...@gmail.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
---
M be/src/scheduling/scheduler.cc
1 file changed, 16 insertions(+), 7 deletions(-)
Approvals:
Michael Smith: Looks good to me, but someone else must approve
Impala Public Jenkins: Verified
Yida Wu: Looks good to me, but someone else must approve
Joe McDonnell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/23495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I449308f4a0efdca7fc238e3dda24985a2931dd37
Gerrit-Change-Number: 23495
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>