[commons-numbers] 07/09: Fixed test coverage in BinomialCoefficientTest

[ah...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git

commit 36679a7ad08ffb53287f5c6ccdf6fa5c5d9821ab
Author: Alex Herbert <ah...@apache.org>
AuthorDate: Sat Apr 4 21:47:39 2020 +0100

    Fixed test coverage in BinomialCoefficientTest
---
 .../combinatorics/BinomialCoefficientTest.java     | 23 ++++++++--------------
 1 file changed, 8 insertions(+), 15 deletions(-)

diff --git a/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/BinomialCoefficientTest.java b/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/BinomialCoefficientTest.java
index b266930..8080f80 100644
--- a/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/BinomialCoefficientTest.java
+++ b/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/BinomialCoefficientTest.java
@@ -72,37 +72,30 @@ public class BinomialCoefficientTest {
     }
 
     @Test
-    public void testBinomialCoefficientFail1() {
+    public void testBinomialCoefficientKLargerThanN() {
         Assertions.assertThrows(CombinatoricsException.class,
             () -> BinomialCoefficient.value(4, 5)
         );
     }
 
     @Test
-    public void testBinomialCoefficientFail2() {
+    public void testBinomialCoefficientNegativeN() {
         Assertions.assertThrows(CombinatoricsException.class,
-            () -> BinomialCoefficient.value(-1, -2)
+            () -> BinomialCoefficient.value(-1, 1)
         );
     }
 
     @Test
-    public void testBinomialCoefficientFail3() {
-        Assertions.assertThrows(ArithmeticException.class,
-            () -> BinomialCoefficient.value(67, 30)
-        );
-    }
-
-    @Test
-    public void testBinomialCoefficientFail4() {
-        Assertions.assertThrows(ArithmeticException.class,
-            () -> BinomialCoefficient.value(67, 34)
+    public void testBinomialCoefficientNegativeK() {
+        Assertions.assertThrows(CombinatoricsException.class,
+            () -> BinomialCoefficient.value(10, -1)
         );
     }
 
     @Test
-    public void testBinomialCoefficientFail5() {
+    public void testBinomialCoefficientNAbove66ResultOverflow() {
         Assertions.assertThrows(ArithmeticException.class,
-            () -> BinomialCoefficient.value(700, 300)
+            () -> BinomialCoefficient.value(67, 30)
         );
     }