You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Alok Lal <al...@hortonworks.com> on 2015/08/21 03:12:45 UTC
Review Request 37667: RANGER-622 Hive plugin - add jar via beeline
throws NPE in ranger code
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37667/
-----------------------------------------------------------
Review request for ranger and Madhan Neethiraj.
Bugs: RANGER-622
https://issues.apache.org/jira/browse/RANGER-622
Repository: ranger
Description
-------
RANGER-622 Hive plugin - add jar via beeline throws NPE in ranger code
- This patch applies to master
- Once approved will port to 0.5
Diffs
-----
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 9075b57
Diff: https://reviews.apache.org/r/37667/diff/
Testing
-------
reproduced the problem on hive. Verified that after fix NPE goes away. Works both when jar is present and when jar is not present.
Thanks,
Alok Lal
Re: Review Request 37667: RANGER-622 Hive plugin - add jar via beeline
throws NPE in ranger code
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37667/#review96022
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Aug. 21, 2015, 1:46 a.m., Alok Lal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37667/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2015, 1:46 a.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-622
> https://issues.apache.org/jira/browse/RANGER-622
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-622 Hive plugin - add jar via beeline throws NPE in ranger code
> - This patch applies to master
> - Once approved will port to 0.5
>
>
> Diffs
> -----
>
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 9075b57
>
> Diff: https://reviews.apache.org/r/37667/diff/
>
>
> Testing
> -------
>
> reproduced the problem on hive. Verified that after fix NPE goes away. Works both when jar is present and when jar is not present.
>
>
> Thanks,
>
> Alok Lal
>
>
Re: Review Request 37667: RANGER-622 Hive plugin - add jar via beeline
throws NPE in ranger code
Posted by Alok Lal <al...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37667/
-----------------------------------------------------------
(Updated Aug. 20, 2015, 6:46 p.m.)
Review request for ranger and Madhan Neethiraj.
Changes
-------
Aded NPE check around output objects.
Re-tested to make sure the add jar works without problem.
Bugs: RANGER-622
https://issues.apache.org/jira/browse/RANGER-622
Repository: ranger
Description
-------
RANGER-622 Hive plugin - add jar via beeline throws NPE in ranger code
- This patch applies to master
- Once approved will port to 0.5
Diffs (updated)
-----
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 9075b57
Diff: https://reviews.apache.org/r/37667/diff/
Testing
-------
reproduced the problem on hive. Verified that after fix NPE goes away. Works both when jar is present and when jar is not present.
Thanks,
Alok Lal
Re: Review Request 37667: RANGER-622 Hive plugin - add jar via beeline
throws NPE in ranger code
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37667/#review96019
-----------------------------------------------------------
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java (line 276)
<https://reviews.apache.org/r/37667/#comment151214>
Please add null check here as well.
- Madhan Neethiraj
On Aug. 21, 2015, 1:12 a.m., Alok Lal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37667/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2015, 1:12 a.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-622
> https://issues.apache.org/jira/browse/RANGER-622
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-622 Hive plugin - add jar via beeline throws NPE in ranger code
> - This patch applies to master
> - Once approved will port to 0.5
>
>
> Diffs
> -----
>
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 9075b57
>
> Diff: https://reviews.apache.org/r/37667/diff/
>
>
> Testing
> -------
>
> reproduced the problem on hive. Verified that after fix NPE goes away. Works both when jar is present and when jar is not present.
>
>
> Thanks,
>
> Alok Lal
>
>