You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/04/28 14:59:21 UTC
[GitHub] [cloudstack] ravening opened a new pull request #4046: Display image store disk size used and total disk size stats
ravening opened a new pull request #4046:
URL: https://github.com/apache/cloudstack/pull/4046
## Description
Display image store disk size used and total disk size in list imagestore api response
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
Before the change, this is the api response
```
(local) 🐵 > list imagestores
{
"count": 1,
"imagestore": [
{
"id": "4c2886-191f-4bcf-b73d-b822a3f67",
"name": "nfs://10.1.1.1:/data/secondary1",
"protocol": "nfs",
"providername": "NFS",
"scope": "ZONE",
"url": "nfs://10.1.1.1:/data/secondary1",
"zoneid": "864a09-8c64-4da4-a56b-e6adsfs17d4de",
"zonename": "zone1"
}
]
}
```
This is the api response after the change
```
(local) 🐵 > list imagestores
{
"count": 1,
"imagestore": [
{
"disksizetotal": 527370027008, <<<<<<<<<<<<<<<<<<<<<<
"disksizeused": 9650569216, <<<<<<<<<<<<<<<<<<<<<<
"id": "4sdf886-191f-4bcf-b7dsd-b8sdf213f67",
"name": "nfs://10.1.1.1:/data/secondary1",
"protocol": "nfs",
"providername": "NFS",
"scope": "ZONE",
"url": "nfs://10.1.1.1:/data/secondary1",
"zoneid": "8sff0b59-8c64-4da4-a56b-e6sdfrdsf4de",
"zonename": "zone1"
}
]
}
```
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4046: Display image store disk size used and total disk size stats
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4046:
URL: https://github.com/apache/cloudstack/pull/4046#issuecomment-638594235
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4046: Display image store disk size used and total disk size stats
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4046:
URL: https://github.com/apache/cloudstack/pull/4046
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4046: Display image store disk size used and total disk size stats
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4046:
URL: https://github.com/apache/cloudstack/pull/4046#issuecomment-639105764
<b>Trillian test result (tid-1621)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44588 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4046-t1621-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4046: Display image store disk size used and total disk size stats
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4046:
URL: https://github.com/apache/cloudstack/pull/4046#issuecomment-638562332
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4046: Display image store disk size used and total disk size stats
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4046:
URL: https://github.com/apache/cloudstack/pull/4046#issuecomment-638562667
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4046: Display image store disk size used and total disk size stats
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4046:
URL: https://github.com/apache/cloudstack/pull/4046#discussion_r434955382
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/ImageStoreResponse.java
##########
@@ -60,6 +60,14 @@
@Param(description = "the scope of the image store")
private ScopeType scope;
+ @SerializedName("disksizetotal")
Review comment:
@ravening nit - can you fix this (and other serialised names) to use `ApiContant`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4046: Display image store disk size used and total disk size stats
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4046:
URL: https://github.com/apache/cloudstack/pull/4046#discussion_r434955382
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/ImageStoreResponse.java
##########
@@ -60,6 +60,14 @@
@Param(description = "the scope of the image store")
private ScopeType scope;
+ @SerializedName("disksizetotal")
Review comment:
@ravening can you fix this (and other serialised names) to use `ApiContant`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4046: Display image store disk size used and total disk size stats
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4046:
URL: https://github.com/apache/cloudstack/pull/4046#issuecomment-638583124
Packaging result: ✔centos7 ✖debian. JID-1283
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4046: Display image store disk size used and total disk size stats
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4046:
URL: https://github.com/apache/cloudstack/pull/4046
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4046: Display image store disk size used and total disk size stats
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4046:
URL: https://github.com/apache/cloudstack/pull/4046#issuecomment-638594432
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org