You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/06/17 08:08:00 UTC

[jira] [Commented] (OFBIZ-11824) Clean code according to SpotBugs and Eclipse

    [ https://issues.apache.org/jira/browse/OFBIZ-11824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138218#comment-17138218 ] 

ASF subversion and git services commented on OFBIZ-11824:
---------------------------------------------------------

Commit 50fa929b8318fe30c0a5fcab4a40e865fd047be6 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=50fa929 ]

Improved: Clean code according to SpotBugs and Eclipse (OFBIZ-11824)

Handles 2 possible NPR reported by SpotBugs
Removes the unused createPrimaryKeyFetcher method as reported by Eclipse
Reformats modified code to stay into 150 chars by line and other style issues
Sets tasks.checkstyleMain.maxErrors to 26759 (-1)


> Clean code according to SpotBugs and Eclipse
> --------------------------------------------
>
>                 Key: OFBIZ-11824
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11824
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Priority: Major
>
> While working on OFBIZ-11822 I noticed a SpotBugs issue among 92 others with 33 "scary"
> That not's much and should be handled in this sole Jira separated by type of issues when necessary (eg there are 17 possible NPE to check)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)