You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Carl Steinbach (JIRA)" <ji...@apache.org> on 2010/01/21 06:58:56 UTC
[jira] Created: (HIVE-1081) Automated source code cleanup
Automated source code cleanup
-----------------------------
Key: HIVE-1081
URL: https://issues.apache.org/jira/browse/HIVE-1081
Project: Hadoop Hive
Issue Type: Task
Reporter: Carl Steinbach
Assignee: Carl Steinbach
Attachments: cleanup-cli.patch, cleanup-common.patch, cleanup-contrib-test.patch, cleanup-contrib.patch, cleanup-hwi-test.patch, cleanup-hwi.patch
Reduce the number of Checkstyle violations by applying Eclipse's automated cleanup
tools to the Hive code base:
* Correct indentation
* Remove trailing white spaces on all lines
* Format source code
* Organize imports
* Remove unnecessary casts
* Add missing '@Deprecated' annotations
* Add missing '@Override' annotations
* Remove unused
** local variables
** private fields
** private types
** private constructors
** private methods
** imports
* Add final modifier to
** local variables (if applicable)
** private fields (if applicable)
* Convert for loops to enhanced for loops
* Convert control statement bodies to block
* Remove 'this' qualifier for non-static method accesses.
* Remove 'this' qualifier for non-static field accesses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1081) Automated source code cleanup
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1081:
---------------------------------
Attachment: cleanup-ql.2.patch
* Updated copy of cleanup-ql patch.
> Automated source code cleanup
> -----------------------------
>
> Key: HIVE-1081
> URL: https://issues.apache.org/jira/browse/HIVE-1081
> Project: Hadoop Hive
> Issue Type: Task
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: cleanup-cli.patch, cleanup-common.patch, cleanup-contrib-test.patch, cleanup-contrib.patch, cleanup-hwi-test.patch, cleanup-hwi.patch, cleanup-jdbc-test.patch, cleanup-jdbc.patch, cleanup-metastore-test.patch, cleanup-metastore.patch, cleanup-ql-test.patch, cleanup-ql.2.patch, cleanup-ql.patch, cleanup-serde-test.patch, cleanup-serde.patch, cleanup-service-test.patch, cleanup-service.patch
>
>
> Reduce the number of Checkstyle violations by applying Eclipse's automated cleanup
> tools to the Hive code base:
> * Correct indentation
> * Remove trailing white spaces on all lines
> * Format source code
> * Organize imports
> * Remove unnecessary casts
> * Add missing '@Deprecated' annotations
> * Add missing '@Override' annotations
> * Remove unused
> ** local variables
> ** private fields
> ** private types
> ** private constructors
> ** private methods
> ** imports
> * Add final modifier to
> ** local variables (if applicable)
> ** private fields (if applicable)
> * Convert for loops to enhanced for loops
> * Convert control statement bodies to block
> * Remove 'this' qualifier for non-static method accesses.
> * Remove 'this' qualifier for non-static field accesses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1081) Automated source code cleanup
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1081:
---------------------------------
Attachment: cleanup-contrib-test.patch
cleanup-common.patch
cleanup-cli.patch
> Automated source code cleanup
> -----------------------------
>
> Key: HIVE-1081
> URL: https://issues.apache.org/jira/browse/HIVE-1081
> Project: Hadoop Hive
> Issue Type: Task
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: cleanup-cli.patch, cleanup-common.patch, cleanup-contrib-test.patch, cleanup-contrib.patch, cleanup-hwi-test.patch, cleanup-hwi.patch
>
>
> Reduce the number of Checkstyle violations by applying Eclipse's automated cleanup
> tools to the Hive code base:
> * Correct indentation
> * Remove trailing white spaces on all lines
> * Format source code
> * Organize imports
> * Remove unnecessary casts
> * Add missing '@Deprecated' annotations
> * Add missing '@Override' annotations
> * Remove unused
> ** local variables
> ** private fields
> ** private types
> ** private constructors
> ** private methods
> ** imports
> * Add final modifier to
> ** local variables (if applicable)
> ** private fields (if applicable)
> * Convert for loops to enhanced for loops
> * Convert control statement bodies to block
> * Remove 'this' qualifier for non-static method accesses.
> * Remove 'this' qualifier for non-static field accesses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1081) Automated source code cleanup
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1081:
---------------------------------
Attachment: cleanup-service-test.patch
cleanup-serde.patch
cleanup-serde-test.patch
> Automated source code cleanup
> -----------------------------
>
> Key: HIVE-1081
> URL: https://issues.apache.org/jira/browse/HIVE-1081
> Project: Hadoop Hive
> Issue Type: Task
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: cleanup-cli.patch, cleanup-common.patch, cleanup-contrib-test.patch, cleanup-contrib.patch, cleanup-hwi-test.patch, cleanup-hwi.patch, cleanup-jdbc-test.patch, cleanup-jdbc.patch, cleanup-metastore-test.patch, cleanup-metastore.patch, cleanup-ql-test.patch, cleanup-ql.patch, cleanup-serde-test.patch, cleanup-serde.patch, cleanup-service-test.patch
>
>
> Reduce the number of Checkstyle violations by applying Eclipse's automated cleanup
> tools to the Hive code base:
> * Correct indentation
> * Remove trailing white spaces on all lines
> * Format source code
> * Organize imports
> * Remove unnecessary casts
> * Add missing '@Deprecated' annotations
> * Add missing '@Override' annotations
> * Remove unused
> ** local variables
> ** private fields
> ** private types
> ** private constructors
> ** private methods
> ** imports
> * Add final modifier to
> ** local variables (if applicable)
> ** private fields (if applicable)
> * Convert for loops to enhanced for loops
> * Convert control statement bodies to block
> * Remove 'this' qualifier for non-static method accesses.
> * Remove 'this' qualifier for non-static field accesses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1081) Automated source code cleanup
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1081:
---------------------------------
Attachment: cleanup-service.patch
> Automated source code cleanup
> -----------------------------
>
> Key: HIVE-1081
> URL: https://issues.apache.org/jira/browse/HIVE-1081
> Project: Hadoop Hive
> Issue Type: Task
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: cleanup-cli.patch, cleanup-common.patch, cleanup-contrib-test.patch, cleanup-contrib.patch, cleanup-hwi-test.patch, cleanup-hwi.patch, cleanup-jdbc-test.patch, cleanup-jdbc.patch, cleanup-metastore-test.patch, cleanup-metastore.patch, cleanup-ql-test.patch, cleanup-ql.patch, cleanup-serde-test.patch, cleanup-serde.patch, cleanup-service-test.patch, cleanup-service.patch
>
>
> Reduce the number of Checkstyle violations by applying Eclipse's automated cleanup
> tools to the Hive code base:
> * Correct indentation
> * Remove trailing white spaces on all lines
> * Format source code
> * Organize imports
> * Remove unnecessary casts
> * Add missing '@Deprecated' annotations
> * Add missing '@Override' annotations
> * Remove unused
> ** local variables
> ** private fields
> ** private types
> ** private constructors
> ** private methods
> ** imports
> * Add final modifier to
> ** local variables (if applicable)
> ** private fields (if applicable)
> * Convert for loops to enhanced for loops
> * Convert control statement bodies to block
> * Remove 'this' qualifier for non-static method accesses.
> * Remove 'this' qualifier for non-static field accesses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1081) Automated source code cleanup
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-1081:
-----------------------------
Resolution: Fixed
Fix Version/s: 0.6.0
Release Note: HIVE-1081. Automated source code cleanup - Part 3 - ql. (Carl Steinbach via zshao)
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
All patches committed. Thanks Carl!
> Automated source code cleanup
> -----------------------------
>
> Key: HIVE-1081
> URL: https://issues.apache.org/jira/browse/HIVE-1081
> Project: Hadoop Hive
> Issue Type: Task
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Fix For: 0.6.0
>
> Attachments: cleanup-cli.patch, cleanup-common.patch, cleanup-contrib-test.patch, cleanup-contrib.patch, cleanup-hwi-test.patch, cleanup-hwi.patch, cleanup-jdbc-test.patch, cleanup-jdbc.patch, cleanup-metastore-test.patch, cleanup-metastore.patch, cleanup-ql-test.patch, cleanup-ql.2.patch, cleanup-ql.patch, cleanup-serde-test.patch, cleanup-serde.patch, cleanup-service-test.patch, cleanup-service.patch
>
>
> Reduce the number of Checkstyle violations by applying Eclipse's automated cleanup
> tools to the Hive code base:
> * Correct indentation
> * Remove trailing white spaces on all lines
> * Format source code
> * Organize imports
> * Remove unnecessary casts
> * Add missing '@Deprecated' annotations
> * Add missing '@Override' annotations
> * Remove unused
> ** local variables
> ** private fields
> ** private types
> ** private constructors
> ** private methods
> ** imports
> * Add final modifier to
> ** local variables (if applicable)
> ** private fields (if applicable)
> * Convert for loops to enhanced for loops
> * Convert control statement bodies to block
> * Remove 'this' qualifier for non-static method accesses.
> * Remove 'this' qualifier for non-static field accesses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1081) Automated source code cleanup
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1081:
---------------------------------
Attachment: cleanup-hwi.patch
cleanup-hwi-test.patch
cleanup-contrib.patch
> Automated source code cleanup
> -----------------------------
>
> Key: HIVE-1081
> URL: https://issues.apache.org/jira/browse/HIVE-1081
> Project: Hadoop Hive
> Issue Type: Task
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: cleanup-cli.patch, cleanup-common.patch, cleanup-contrib-test.patch, cleanup-contrib.patch, cleanup-hwi-test.patch, cleanup-hwi.patch
>
>
> Reduce the number of Checkstyle violations by applying Eclipse's automated cleanup
> tools to the Hive code base:
> * Correct indentation
> * Remove trailing white spaces on all lines
> * Format source code
> * Organize imports
> * Remove unnecessary casts
> * Add missing '@Deprecated' annotations
> * Add missing '@Override' annotations
> * Remove unused
> ** local variables
> ** private fields
> ** private types
> ** private constructors
> ** private methods
> ** imports
> * Add final modifier to
> ** local variables (if applicable)
> ** private fields (if applicable)
> * Convert for loops to enhanced for loops
> * Convert control statement bodies to block
> * Remove 'this' qualifier for non-static method accesses.
> * Remove 'this' qualifier for non-static field accesses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1081) Automated source code cleanup
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1081:
---------------------------------
Status: Patch Available (was: Open)
* In combination these patches reduce the total number of Checkstyle violations from 15436 to 4728.
* There are isolated cases of the automatic formatter making the formatting worse. I will address these cases by hand during the next phase of the cleanup/refactoring project.
> Automated source code cleanup
> -----------------------------
>
> Key: HIVE-1081
> URL: https://issues.apache.org/jira/browse/HIVE-1081
> Project: Hadoop Hive
> Issue Type: Task
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: cleanup-cli.patch, cleanup-common.patch, cleanup-contrib-test.patch, cleanup-contrib.patch, cleanup-hwi-test.patch, cleanup-hwi.patch, cleanup-jdbc-test.patch, cleanup-jdbc.patch, cleanup-metastore-test.patch, cleanup-metastore.patch, cleanup-ql-test.patch, cleanup-ql.patch, cleanup-serde-test.patch, cleanup-serde.patch, cleanup-service-test.patch, cleanup-service.patch
>
>
> Reduce the number of Checkstyle violations by applying Eclipse's automated cleanup
> tools to the Hive code base:
> * Correct indentation
> * Remove trailing white spaces on all lines
> * Format source code
> * Organize imports
> * Remove unnecessary casts
> * Add missing '@Deprecated' annotations
> * Add missing '@Override' annotations
> * Remove unused
> ** local variables
> ** private fields
> ** private types
> ** private constructors
> ** private methods
> ** imports
> * Add final modifier to
> ** local variables (if applicable)
> ** private fields (if applicable)
> * Convert for loops to enhanced for loops
> * Convert control statement bodies to block
> * Remove 'this' qualifier for non-static method accesses.
> * Remove 'this' qualifier for non-static field accesses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1081) Automated source code cleanup
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1081:
---------------------------------
Attachment: cleanup-metastore-test.patch
cleanup-jdbc.patch
cleanup-jdbc-test.patch
> Automated source code cleanup
> -----------------------------
>
> Key: HIVE-1081
> URL: https://issues.apache.org/jira/browse/HIVE-1081
> Project: Hadoop Hive
> Issue Type: Task
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: cleanup-cli.patch, cleanup-common.patch, cleanup-contrib-test.patch, cleanup-contrib.patch, cleanup-hwi-test.patch, cleanup-hwi.patch, cleanup-jdbc-test.patch, cleanup-jdbc.patch, cleanup-metastore-test.patch, cleanup-metastore.patch, cleanup-ql-test.patch, cleanup-ql.patch
>
>
> Reduce the number of Checkstyle violations by applying Eclipse's automated cleanup
> tools to the Hive code base:
> * Correct indentation
> * Remove trailing white spaces on all lines
> * Format source code
> * Organize imports
> * Remove unnecessary casts
> * Add missing '@Deprecated' annotations
> * Add missing '@Override' annotations
> * Remove unused
> ** local variables
> ** private fields
> ** private types
> ** private constructors
> ** private methods
> ** imports
> * Add final modifier to
> ** local variables (if applicable)
> ** private fields (if applicable)
> * Convert for loops to enhanced for loops
> * Convert control statement bodies to block
> * Remove 'this' qualifier for non-static method accesses.
> * Remove 'this' qualifier for non-static field accesses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1081) Automated source code cleanup
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1081:
---------------------------------
Release Note: (was: HIVE-1081. Automated source code cleanup - Part 3 - ql. (Carl Steinbach via zshao))
> Automated source code cleanup
> -----------------------------
>
> Key: HIVE-1081
> URL: https://issues.apache.org/jira/browse/HIVE-1081
> Project: Hive
> Issue Type: Task
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Fix For: 0.6.0
>
> Attachments: cleanup-cli.patch, cleanup-common.patch, cleanup-contrib-test.patch, cleanup-contrib.patch, cleanup-hwi-test.patch, cleanup-hwi.patch, cleanup-jdbc-test.patch, cleanup-jdbc.patch, cleanup-metastore-test.patch, cleanup-metastore.patch, cleanup-ql-test.patch, cleanup-ql.2.patch, cleanup-ql.patch, cleanup-serde-test.patch, cleanup-serde.patch, cleanup-service-test.patch, cleanup-service.patch
>
>
> Reduce the number of Checkstyle violations by applying Eclipse's automated cleanup
> tools to the Hive code base:
> * Correct indentation
> * Remove trailing white spaces on all lines
> * Format source code
> * Organize imports
> * Remove unnecessary casts
> * Add missing '@Deprecated' annotations
> * Add missing '@Override' annotations
> * Remove unused
> ** local variables
> ** private fields
> ** private types
> ** private constructors
> ** private methods
> ** imports
> * Add final modifier to
> ** local variables (if applicable)
> ** private fields (if applicable)
> * Convert for loops to enhanced for loops
> * Convert control statement bodies to block
> * Remove 'this' qualifier for non-static method accesses.
> * Remove 'this' qualifier for non-static field accesses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1081) Automated source code cleanup
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1081:
---------------------------------
Attachment: cleanup-ql.patch
cleanup-ql-test.patch
cleanup-metastore.patch
> Automated source code cleanup
> -----------------------------
>
> Key: HIVE-1081
> URL: https://issues.apache.org/jira/browse/HIVE-1081
> Project: Hadoop Hive
> Issue Type: Task
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: cleanup-cli.patch, cleanup-common.patch, cleanup-contrib-test.patch, cleanup-contrib.patch, cleanup-hwi-test.patch, cleanup-hwi.patch, cleanup-jdbc-test.patch, cleanup-jdbc.patch, cleanup-metastore-test.patch, cleanup-metastore.patch, cleanup-ql-test.patch, cleanup-ql.patch, cleanup-serde-test.patch, cleanup-serde.patch, cleanup-service-test.patch
>
>
> Reduce the number of Checkstyle violations by applying Eclipse's automated cleanup
> tools to the Hive code base:
> * Correct indentation
> * Remove trailing white spaces on all lines
> * Format source code
> * Organize imports
> * Remove unnecessary casts
> * Add missing '@Deprecated' annotations
> * Add missing '@Override' annotations
> * Remove unused
> ** local variables
> ** private fields
> ** private types
> ** private constructors
> ** private methods
> ** imports
> * Add final modifier to
> ** local variables (if applicable)
> ** private fields (if applicable)
> * Convert for loops to enhanced for loops
> * Convert control statement bodies to block
> * Remove 'this' qualifier for non-static method accesses.
> * Remove 'this' qualifier for non-static field accesses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.